Repository navigation
test-gaps: c838fbd8d..a8ee3b188 - #1355
Merged
Merged
Conversation
…ing vault Two fixes from the last day were held only by checks CI does not run: - #1337 keeps a sidebar row's hover fill while the pointer is on its trailing actions. Only shared-controls.mjs (not in CI) checked it. The stress channel step now points at an unselected channel row, then at its settings beside it, and requires the same fill. - #1340 stopped onboarding from asking for the vault passphrase. The stress onboarding step refused a vault dialog, but over an unlocked vault, where the old code drew none either. It now locks the vault through its native session first and unlocks it after. Both new checks fail with their fix put back and hold on main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018rccRX3nxAcKBWu6gcEXWB
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
…rrors apart Review fixes for the two new stress checks: - The hover check reads the rest fill first, then waits for the control's fill to leave it under the pointer, so a late transition no longer reads as a selected row. With fewer than two channel rows and no tree branches it fails instead of passing silently. - A vault that fails to unlock after onboarding is its own failure, never in place of the window's. A setup window refused for a vault dialog is closed before the refusal, so it does not stay open for later steps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018rccRX3nxAcKBWu6gcEXWB
Varuas37
marked this pull request as ready for review
November 17, 2026 08:47
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018rccRX3nxAcKBWu6gcEXWB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Saurav · project thread
Before: Of the 11 changes merged to main in the last day, two fixes had no check in CI. A sidebar row losing its hover fill under its actions (#1337), or onboarding asking for the vault passphrase (#1340), could come back unnoticed.
After: The conversation stress suite (run by every PR's CI) fails if either comes back. 2 gaps closed, no issues opened.
Background
The daily test-gap run reviews what merged to main in the last 26 hours. For each fix it puts the bug back and checks that a test CI runs fails. A fix only a local script checks counts as a gap.
The problem
shared-controls.mjs --only rowschecked this, and no CI job runs that script.onboardingstep already refused a vault dialog, but it ran over an unlocked vault. There the old code drew no dialog either, so the step passed with the bug put back.The solution
All in
verification/desktop/scripts/conversation-stress.mjs:channelstep. Once two channels exist, it finds the channel row that is not selected (its rest and hover fills differ). It points at the row, then at its settings beside it, and requires the same hover fill both times.onboardingstep. It locks the vault through its native session, as after a restart. Then it opens the setup window, which already refuses any vault dialog. It unlocks the vault again afterwards.How we checked it
rgba(0, 0, 0, 0), not oklab(0.985 0 0 / 0.05)), holds on main--only onboarding,passphrase,channel,stopin Chromium held 9/9 on this branch.verification/desktop/scripts/lib/*.test.mjspassed 698 tests. eslint and prettier are clean.Tradeoffs and follow-ups
stopstep only one channel exists, and it is selected, so the check runs in thechannelstep.finally, so later steps see it unlocked.Rollout
Nothing special. Test-only change.
Generated by Claude Code