Skip to content

test-gaps: c838fbd8d..a8ee3b188 - #1355

Merged
Varuas37 merged 5 commits into
mainfrom
claude/test-gaps-2026-11-15
Nov 18, 2026
Merged

Varuas37 merged 5 commits into
mainfrom
claude/test-gaps-2026-11-15

Conversation

@Varuas37

Copy link
Copy Markdown
Contributor

Requested by Saurav · project thread

Before: Of the 11 changes merged to main in the last day, two fixes had no check in CI. A sidebar row losing its hover fill under its actions (#1337), or onboarding asking for the vault passphrase (#1340), could come back unnoticed.

After: The conversation stress suite (run by every PR's CI) fails if either comes back. 2 gaps closed, no issues opened.

Background

The daily test-gap run reviews what merged to main in the last 26 hours. For each fix it puts the bug back and checks that a test CI runs fails. A fix only a local script checks counts as a gap.

The problem

The solution

All in verification/desktop/scripts/conversation-stress.mjs:

  1. channel step. Once two channels exist, it finds the channel row that is not selected (its rest and hover fills differ). It points at the row, then at its settings beside it, and requires the same hover fill both times.
  2. onboarding step. It locks the vault through its native session, as after a restart. Then it opens the setup window, which already refuses any vault dialog. It unlocks the vault again afterwards.

How we checked it

Entry Bug What holds it now
#1353 A VM creation whose answer was lost never finished Existing: 2 allocation tests fail with it put back
#1351 A voice call ended when its chat left the panes Existing: 2 VoiceController V16 tests fail with it put back
#1337 Row hover dropped under its trailing actions New channel-step check: fails with the CSS put back (rgba(0, 0, 0, 0), not oklab(0.985 0 0 / 0.05)), holds on main
#1340 Onboarding asked for the passphrase New locked vault in the onboarding step: fails with the fix put back ("the setup window opened a vault dialog on its own"), holds on main
#1350 #1346 #1339 #1332 Features, copy, and SDK guard naming Not fixes
#1341 #1338 #1336 #1334 Crate moves and refactors Not fixes
  • Stress --only onboarding,passphrase,channel,stop in Chromium held 9/9 on this branch. verification/desktop/scripts/lib/*.test.mjs passed 698 tests. eslint and prettier are clean.
  • Not run: WebKit (it cannot be downloaded in the cloud sandbox).

Tradeoffs and follow-ups

  • The hover check needs an unselected channel row. In the stop step only one channel exists, and it is selected, so the check runs in the channel step.
  • The onboarding step briefly locks the shared vault. It unlocks it again in a finally, so later steps see it unlocked.

Rollout

Nothing special. Test-only change.


Generated by Claude Code

…ing vault

Two fixes from the last day were held only by checks CI does not run:

- #1337 keeps a sidebar row's hover fill while the pointer is on its
  trailing actions. Only shared-controls.mjs (not in CI) checked it. The
  stress channel step now points at an unselected channel row, then at its
  settings beside it, and requires the same fill.
- #1340 stopped onboarding from asking for the vault passphrase. The
  stress onboarding step refused a vault dialog, but over an unlocked
  vault, where the old code drew none either. It now locks the vault
  through its native session first and unlocks it after.

Both new checks fail with their fix put back and hold on main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018rccRX3nxAcKBWu6gcEXWB
@Varuas37 Varuas37 self-assigned this Nov 15, 2026
@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b8770ca5-de28-46bd-8049-efaeabe3a366
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Varuas37 and others added 2 commits November 16, 2026 06:55
…rrors apart

Review fixes for the two new stress checks:

- The hover check reads the rest fill first, then waits for the control's
  fill to leave it under the pointer, so a late transition no longer reads
  as a selected row. With fewer than two channel rows and no tree branches
  it fails instead of passing silently.
- A vault that fails to unlock after onboarding is its own failure, never
  in place of the window's. A setup window refused for a vault dialog is
  closed before the refusal, so it does not stay open for later steps.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018rccRX3nxAcKBWu6gcEXWB
@Varuas37
Varuas37 marked this pull request as ready for review November 17, 2026 08:47
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T08:49:01.370871Z 390bc74 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Varuas37
Varuas37 merged commit c6633c5 into main Nov 18, 2026
13 checks passed
@Varuas37
Varuas37 deleted the claude/test-gaps-2026-11-15 branch November 18, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants