Repository navigation
Fold an idle composer to a circle in short stacked panes - #1350
Conversation
A short pane of several that you are not in already quieted its composer to one line. With nothing typed or attached, no turn running and no notice, that line now folds to a 36px circle bearing the model's mark. Focus on the circle focuses the pane, the caret follows into the field, and the existing grow-from-corner animation opens the whole composer. The model menu's provider tiles asked for 28x28 inside nessa_ui's 16px icon slot and squeezed into a tall sliver; they now fill the slot as a 16x16 square that never shrinks. Checked by the stress `composer` step (square tiles; three stacked panes fold, a draft keeps its line, a pressed circle takes the caret), the columns `quiet-composer` check and a composer unit test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JcBpmUDZ4CR7xnDkAZqRhv
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JcBpmUDZ4CR7xnDkAZqRhv
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d439563cd9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
<!-- claude-projects-attribution: {"github_login":"Varuas37"} -->
_Requested by **Saurav** · [project
thread](https://claude.ai/code/project/chan_01UZaufydjNk2K88KGgoAfmr?thread=cmsg_01UZaufydjNk2K88KGgoAfmrX5YyyUXBGeQoMRRr3igVbS)_
**Before:** Of the 11 changes merged to main in the last day, two fixes
had no check in CI. A sidebar row losing its hover fill under its
actions (#1337), or onboarding asking for the vault passphrase (#1340),
could come back unnoticed.
**After:** The conversation stress suite (run by every PR's CI) fails if
either comes back. 2 gaps closed, no issues opened.
## Background
The daily test-gap run reviews what merged to main in the last 26 hours.
For each fix it puts the bug back and checks that a test CI runs fails.
A fix only a local script checks counts as a gap.
## The problem
- **#1337 (row hover).** When the pointer moved from a sidebar row onto
its trailing action (a channel's settings), the row lost its highlight.
Only `shared-controls.mjs --only rows` checked this, and no CI job runs
that script.
- **#1340 (onboarding vault).** The setup window opened the vault's
unlock dialog on its own. The stress `onboarding` step already refused a
vault dialog, but it ran over an unlocked vault. There the old code drew
no dialog either, so the step passed with the bug put back.
## The solution
All in `verification/desktop/scripts/conversation-stress.mjs`:
1. **`channel` step.** Once two channels exist, it finds the channel row
that is not selected (its rest and hover fills differ). It points at the
row, then at its settings beside it, and requires the same hover fill
both times.
2. **`onboarding` step.** It locks the vault through its native session,
as after a restart. Then it opens the setup window, which already
refuses any vault dialog. It unlocks the vault again afterwards.
## How we checked it
| Entry | Bug | What holds it now |
| --- | --- | --- |
| #1353 | A VM creation whose answer was lost never finished | Existing:
2 allocation tests fail with it put back |
| #1351 | A voice call ended when its chat left the panes | Existing: 2
VoiceController V16 tests fail with it put back |
| #1337 | Row hover dropped under its trailing actions | **New**
channel-step check: fails with the CSS put back (`rgba(0, 0, 0, 0), not
oklab(0.985 0 0 / 0.05)`), holds on main |
| #1340 | Onboarding asked for the passphrase | **New** locked vault in
the onboarding step: fails with the fix put back ("the setup window
opened a vault dialog on its own"), holds on main |
| #1350 #1346 #1339 #1332 | Features, copy, and SDK guard naming | Not
fixes |
| #1341 #1338 #1336 #1334 | Crate moves and refactors | Not fixes |
- Stress `--only onboarding,passphrase,channel,stop` in Chromium held
9/9 on this branch. `verification/desktop/scripts/lib/*.test.mjs` passed
698 tests. eslint and prettier are clean.
- Not run: WebKit (it cannot be downloaded in the cloud sandbox).
## Tradeoffs and follow-ups
- The hover check needs an unselected channel row. In the `stop` step
only one channel exists, and it is selected, so the check runs in the
`channel` step.
- The onboarding step briefly locks the shared vault. It unlocks it
again in a `finally`, so later steps see it unlocked.
## Rollout
Nothing special. Test-only change.
---
_Generated by [Claude
Code](https://claude.ai/code/session_018rccRX3nxAcKBWu6gcEXWB)_
---------
Co-authored-by: Claude <noreply@anthropic.com>
Requested by Saurav · project thread
Before: with three chats stacked in a short column, every pane you are not in still shows a composer bar ("What would you like to work on?") taking scarce height, and the model menu's provider icons look squeezed into tall slivers.
After: an idle pane's composer folds to a small circle with the model's mark in its bottom corner; pressing it opens the full composer with the caret in it. The model menu's icons are square.
Background
When the window is split, each pane has its own composer at its foot. A pane under 420px tall that you are not in already "quiets" its composer: one line with the placeholder and Send, or Stop alone while its turn runs. The pane you are in always shows the whole composer, and moving into a quiet pane grows its composer out of the bottom-right corner.
The problem
flowchart LR subgraph Before["Before: three short stacked panes"] direction TB B1["Pane you are in: whole composer"] B2["Pane you are not in: one-line bar, placeholder and Send"] B3["Pane you are not in: one-line bar, placeholder and Send"] end subgraph After["After: the same panes"] direction TB A1["Pane you are in: whole composer"] A2["Pane you are not in, nothing typed: circle with the model's mark"] A3["Pane you are not in, a draft typed: one-line bar, as before"] end Before ~~~ AfterThe solution
Commits: b48ba3a (the fold, the tile fix and their checks), d439563 (evidence screenshots).
How we checked it
Saurav approved a mockup of the behaviour first.
Three stacked panes: the two you are not in show circles
Model menu with square provider tiles
composerstep, extended. It checks that the model menu's tiles are square and fit their slot. It then stacks three panes in a short window and checks that empty panes you are not in fold to circles and that a pane left with a draft keeps its line. Last, it checks that pressing a circle focuses that pane with the caret in its field.--only composer,menu: 6/6 held (Chromium).columns.mjs --only quiet-composerextended the same way: 6/6 Chromium layouts held.composerstep, and it held 6/6 on this head.Tradeoffs and follow-ups
Rollout
Nothing special.
🤖 Generated with Claude Code
https://claude.ai/code/session_01JcBpmUDZ4CR7xnDkAZqRhv