Skip to content

fix(launcher): handle headless open fallback - #18

Merged
oll4com merged 1 commit into
mainfrom
fix/open-headless-fallback
Jul 25, 2026
Merged

oll4com merged 1 commit into
mainfrom
fix/open-headless-fallback

Conversation

@oll4com

@oll4com oll4com commented Jul 25, 2026 •

Copy link
Copy Markdown
Owner

Summary:

  • make spaceapp open print the exact manual URL when no native browser opener is available
  • return success once an actionable manual access path is provided
  • stage launcher metadata and release documentation as 0.1.9

Verification:

  • npm run test:public
  • npm audit --audit-level=high (0 vulnerabilities)
  • npm run public:export:verify
  • npm run check -w run-spaceapp
  • npm run pack:dry-run -w run-spaceapp
  • git diff --check

Release safety:

  • 0.1.9 must remain on npm tag next until clean-room acceptance passes
  • do not promote, tag, or create a GitHub Release before acceptance

Summary by CodeRabbit

  • New Features

    • spaceapp open now reports when the native browser opener is unavailable and provides the URL for manual opening while completing successfully.
    • Released run-spaceapp version 0.1.9.
  • Bug Fixes

    • Improved handling of browser-launch failures so users receive clear recovery instructions.
  • Documentation

    • Updated release notes, command examples, operations guidance, and public release procedures for version 0.1.9.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3a37896c-9f20-4c3c-ae63-e5b718513545

📥 Commits

Reviewing files that changed from the base of the PR and between 9415b97 and 8ca05b0.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (8)
  • CHANGELOG.md
  • README.md
  • docs/operations.md
  • docs/public-release.md
  • packages/run-spaceapp/package.json
  • packages/run-spaceapp/src/cli.mjs
  • packages/run-spaceapp/tests/command-contracts.test.mjs
  • scripts/tests/public-package-metadata.test.mjs

📝 Walkthrough

Walkthrough

The CLI now falls back to displaying the SpaceApp URL when the native opener fails while returning success. Package metadata, tests, release documentation, operational examples, and changelog references are updated from version 0.1.8 to 0.1.9.

Changes

Release 0.1.9

Layer / File(s) Summary
Open command fallback
packages/run-spaceapp/src/cli.mjs, packages/run-spaceapp/tests/command-contracts.test.mjs
spaceapp open prints a manual URL and exits successfully when the native opener returns a non-zero code; the behavior is covered by a command-contract test.
Version and state alignment
packages/run-spaceapp/package.json, packages/run-spaceapp/tests/command-contracts.test.mjs, scripts/tests/public-package-metadata.test.mjs
Package metadata and update/rollback expectations now use version 0.1.9.
Release documentation and notes
CHANGELOG.md, README.md, docs/operations.md, docs/public-release.md
Release notes, update examples, acceptance checks, promotion commands, and rollback procedures reference 0.1.9.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant spaceapp_open
  participant openBrowser
  User->>spaceapp_open: Run spaceapp open
  spaceapp_open->>openBrowser: Open SpaceApp URL
  openBrowser-->>spaceapp_open: Non-zero exit code
  spaceapp_open-->>User: Print manual URL and return 0
Loading

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: improving the launcher’s headless open fallback behavior.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@oll4com
oll4com merged commit bca19d7 into main Jul 25, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant