Repository navigation
fix: bypass Edge first-run during Windows setup - #21
Conversation
📝 WalkthroughWalkthroughThe Windows browser opener now uses a validated PowerShell operation with Changesrun-spaceapp opener and release updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/run-spaceapp/tests/prerequisites.test.mjs (1)
50-58: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winCover invalid URL behavior, not only script markers.
Add Windows-level or equivalent behavioral tests for rejecting
https, external hosts, and ports outside1024–65535, plus accepting an allowed local URL. The current assertions can pass even if the validation logic is accidentally weakened.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/run-spaceapp/tests/prerequisites.test.mjs` around lines 50 - 58, Add behavioral coverage around windowsPowerShellArgs for URL validation: assert that https URLs, external hosts, and ports outside 1024–65535 are rejected, while an allowed local URL is accepted. Retain the existing script-marker assertions, but verify the actual validation outcomes rather than only generated-script contents.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/run-spaceapp/tests/prerequisites.test.mjs`:
- Around line 50-58: Add behavioral coverage around windowsPowerShellArgs for
URL validation: assert that https URLs, external hosts, and ports outside
1024–65535 are rejected, while an allowed local URL is accepted. Retain the
existing script-marker assertions, but verify the actual validation outcomes
rather than only generated-script contents.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 40d23d06-9fa0-4e5c-ab3d-21fb96d127a3
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (8)
packages/run-spaceapp/package.jsonpackages/run-spaceapp/src/cli.mjspackages/run-spaceapp/src/prerequisites.mjspackages/run-spaceapp/tests/cli.test.mjspackages/run-spaceapp/tests/command-contracts.test.mjspackages/run-spaceapp/tests/prerequisites.test.mjspackages/run-spaceapp/tests/runtime.test.mjsscripts/tests/public-package-metadata.test.mjs
Summary by CodeRabbit
run-spaceapppackage to version0.1.12.