Skip to content

Fix Windows Docker Desktop one-command installation - #14

Merged
oll4com merged 2 commits into
mainfrom
fix/windows-docker-signature-20260724
Jul 24, 2026
Merged

oll4com merged 2 commits into
mainfrom
fix/windows-docker-signature-20260724

Conversation

@oll4com

@oll4com oll4com commented Jul 24, 2026 •

Copy link
Copy Markdown
Owner

Prefer the hash-pinned Docker.DockerDesktop Windows Package Manager manifest, retain the signed direct-download fallback, add regression coverage, and prepare run-spaceapp 0.1.6. Local verification passed the public, launcher, API, web, typecheck, audit, package-readiness, and metadata gates.

Summary by CodeRabbit

  • New Features

    • Windows setup now prefers Docker Desktop installation through Windows Package Manager, with verified direct-download fallback.
    • Installation guidance now covers license acceptance, UAC prompts, restarts, and Docker readiness checks.
    • Released run-spaceapp version 0.1.6.
  • Documentation

    • Updated installation, operations, release, and Windows setup instructions for version 0.1.6.
  • Bug Fixes

    • Improved verification when Windows Package Manager reports success but Docker Desktop is unavailable.

oll4com added 2 commits July 24, 2026 19:41
Use the hash-pinned Docker.DockerDesktop manifest before the signed direct-download fallback so Windows trust-chain status does not block the one-command prerequisite flow.
@coderabbitai

coderabbitai Bot commented Jul 24, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 74665e6b-5555-4eaa-a559-62ddee3a6bf1

📥 Commits

Reviewing files that changed from the base of the PR and between 3f88521 and 3c714ac.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (12)
  • CHANGELOG.md
  • README.md
  • docs/getting-started.md
  • docs/operations.md
  • docs/public-release.md
  • packages/run-spaceapp/README.md
  • packages/run-spaceapp/package.json
  • packages/run-spaceapp/src/cli.mjs
  • packages/run-spaceapp/src/prerequisites.mjs
  • packages/run-spaceapp/tests/cli.test.mjs
  • packages/run-spaceapp/tests/prerequisites.test.mjs
  • scripts/tests/public-package-metadata.test.mjs

📝 Walkthrough

Walkthrough

The PR adds winget-based Docker Desktop installation on Windows, retains the existing fallback path, updates tests and Windows setup guidance, and advances package, changelog, operational, and release-runbook references to version 0.1.6.

Changes

Windows Docker installation and validation

Layer / File(s) Summary
Winget Docker Desktop installation
packages/run-spaceapp/src/cli.mjs, packages/run-spaceapp/src/prerequisites.mjs, packages/run-spaceapp/tests/*
Adds winget.exe to trusted command execution, installs Docker Desktop using fixed arguments when available, verifies the executable afterward, and tests the preferred path and fallback behavior.
Windows setup guidance
README.md, docs/getting-started.md, packages/run-spaceapp/README.md, scripts/tests/public-package-metadata.test.mjs
Documents hash-pinned Windows Package Manager installation, Authenticode-verified fallback downloads, UAC handling, confirmations, restarts, and Docker readiness checks.

0.1.6 release metadata and runbook

Layer / File(s) Summary
Version and release references
packages/run-spaceapp/package.json, CHANGELOG.md, README.md, docs/operations.md, scripts/tests/public-package-metadata.test.mjs
Updates package and command examples to 0.1.6 and adds the corresponding changelog and release-link references.
Promotion and rollback procedures
docs/public-release.md
Updates staged acceptance, npm maintainer verification, promotion, rollback, deprecation, and artifact-preservation instructions for 0.1.6.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant SpaceAppCLI
  participant winget.exe
  participant DockerDesktop
  participant FallbackInstaller
  SpaceAppCLI->>winget.exe: Check availability
  SpaceAppCLI->>winget.exe: Install Docker Desktop
  winget.exe-->>SpaceAppCLI: Return installation status
  SpaceAppCLI->>DockerDesktop: Verify executable paths
  SpaceAppCLI->>FallbackInstaller: Use direct download if winget is unavailable or fails
Loading

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: improving Windows Docker Desktop one-command installation.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@oll4com
oll4com merged commit 81bf4f1 into main Jul 24, 2026
20 checks passed
@oll4com
oll4com deleted the fix/windows-docker-signature-20260724 branch July 24, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant