Skip to content

fix(installer): handle Docker Desktop first-run onboarding - #15

Merged
oll4com merged 8 commits into
mainfrom
fix/windows-docker-first-run
Jul 25, 2026
Merged

oll4com merged 8 commits into
mainfrom
fix/windows-docker-first-run

Conversation

@oll4com

@oll4com oll4com commented Jul 25, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • explain Docker Desktop's first-run Welcome to Docker handoff on Windows
  • start Docker through the official detached CLI and existing GUI launcher
  • keep the same spaceapp install process waiting for up to ten minutes
  • continue automatically when Docker becomes ready, including at the timeout boundary
  • document the Windows clean-room acceptance path
  • prepare run-spaceapp@0.1.7

Root cause

Docker Desktop installs successfully but does not start its Engine until the user completes Docker's own first-run onboarding. The launcher previously waited silently for only three minutes, so a clean Windows installation appeared stuck or failed before the user knew to select Skip.

Verification

  • npm run test:public — passed
  • public suite — 57/57
  • launcher suite — 46/46
  • npm audit --omit=dev --audit-level=high — 0 vulnerabilities
  • npm pack --dry-run --workspace run-spaceapp — run-spaceapp@0.1.7, 11 files

Summary by CodeRabbit

  • New Features

    • Windows installation now guides users through Docker Desktop’s first-launch setup.
    • Installation waits up to ten minutes for Docker to become ready and continues automatically when possible.
    • Clear guidance is provided for prompts, UAC approval, restarts, and safely rerunning installation.
  • Documentation

    • Updated installation, testing, operations, and release guidance for Docker readiness and version 0.1.7.
    • Added Windows-specific verification steps for first-run Docker behavior.
  • Release

    • SpaceApp launcher version updated to 0.1.7.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@oll4com, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 36 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b8620647-0e4a-4776-a15b-4da3a88eb03d

📥 Commits

Reviewing files that changed from the base of the PR and between 7ab8337 and 67ae177.

📒 Files selected for processing (6)
  • .trivyignore
  • Dockerfile
  • scripts/public-export.mjs
  • scripts/tests/public-docker-distribution.test.mjs
  • scripts/tests/public-export.test.mjs
  • scripts/tests/public-package-metadata.test.mjs
📝 Walkthrough

Walkthrough

Docker Desktop first-run handling now triggers onboarding and waits up to ten minutes for readiness. Windows documentation reflects this flow, while package metadata and release procedures advance from version 0.1.6 to 0.1.7.

Changes

Windows Docker readiness and release updates

Layer / File(s) Summary
Docker Desktop first-run flow
packages/run-spaceapp/src/prerequisites.mjs, packages/run-spaceapp/tests/prerequisites.test.mjs
Windows startup triggers Docker Desktop first-run setup, waits up to 300 attempts, and tests both successful readiness and timeout behavior.
Windows installation guidance
README.md, docs/clean-room-testing.md, docs/getting-started.md, packages/run-spaceapp/README.md
Documentation explains handling the Welcome to Docker prompt, waiting for Docker readiness, and safely rerunning installation after a restart.
0.1.7 release references
packages/run-spaceapp/package.json, scripts/tests/public-package-metadata.test.mjs, docs/operations.md, docs/public-release.md
Package metadata, publishability assertions, update examples, and promotion or rollback instructions now reference version 0.1.7.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant ensureDockerAvailable
  participant DockerCLI
  participant DockerEngine
  ensureDockerAvailable->>DockerCLI: Start Docker Desktop first-run setup
  ensureDockerAvailable->>DockerEngine: Poll readiness for up to 300 attempts
  DockerEngine-->>ensureDockerAvailable: Report ready or timeout
Loading

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: installer support for Docker Desktop first-run onboarding.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@oll4com
oll4com merged commit d76d4a7 into main Jul 25, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant