Repository navigation
fix: make Windows clean install resume automatically - #20
Conversation
|
Warning Review limit reached
Next review available in: 41 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThe release updates the universal installer, light-profile defaults, Windows restart resumption, package metadata, release documentation, web security headers, and authentication form accessibility and field stability. ChangesInstaller and release workflow
Web security and authentication forms
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant run-spaceapp
participant DockerPrerequisites
participant Windows
participant ResumeScript
User->>run-spaceapp: run npx --yes run-spaceapp install
run-spaceapp->>DockerPrerequisites: check WSL and Docker readiness
DockerPrerequisites->>Windows: detect pending restart
DockerPrerequisites->>ResumeScript: register one-time continuation
DockerPrerequisites->>Windows: request restart
Windows->>ResumeScript: execute after sign-in
ResumeScript->>run-spaceapp: continue installation
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
packages/run-spaceapp/tests/prerequisites.test.mjs (1)
141-149: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse the real PowerShell operation in the mocked execute branch.
windows-wsl-readyis not defined inwindowsPowerShellArgs, whileensureWindowsDockercallsexecutefor"windows-restart-pending"immediately after its WSL install path. Update both mock branches to handle"windows-restart-pending"so the test exercises that real operation instead of an unknown branch.♻️ Suggested fix (apply to both occurrences)
- if (spec.operation === "windows-wsl-ready") { + if (spec.operation === "windows-restart-pending") { return 0; }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/run-spaceapp/tests/prerequisites.test.mjs` around lines 141 - 149, Update both mocked powershell.exe execute branches in the prerequisite test to recognize the real "windows-restart-pending" operation instead of "windows-wsl-ready", returning the same success result so ensureWindowsDocker exercises its actual restart-pending flow.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/web/src/App.tsx`:
- Around line 5491-5499: Update the email input within the operator email field
to include the email input type, while preserving its existing id, name, value,
change handler, and autocomplete behavior.
In `@apps/web/tests/server-routing.test.mjs`:
- Around line 28-38: Add route-level coverage for a non-/homepage HTML response
in the local app security-header tests, using the actual routing/integration
path rather than calling localAppSecurityHeaders() directly. Assert the complete
local header contract, including the expected permissions-policy value alongside
the existing CSP, referrer, frame, and absent HSTS checks.
In `@packages/run-spaceapp/src/index.mjs`:
- Around line 493-503: Update initializeInstallation so a requested profile is
resolved before the clean-root createDefaultConfig call; ensure profile "auto"
is converted via resolveInstallProfile before validation while preserving
explicit profile behavior and the existing version update flow.
---
Nitpick comments:
In `@packages/run-spaceapp/tests/prerequisites.test.mjs`:
- Around line 141-149: Update both mocked powershell.exe execute branches in the
prerequisite test to recognize the real "windows-restart-pending" operation
instead of "windows-wsl-ready", returning the same success result so
ensureWindowsDocker exercises its actual restart-pending flow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 8a449d93-5462-4bf1-a554-d88813efdbf9
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (21)
CHANGELOG.mdREADME.mdapps/web/server-routing.mjsapps/web/server.mjsapps/web/src/App.tsxapps/web/src/features/auth/OwnerSetupScreen.tsxapps/web/tests/owner-setup.test.tsxapps/web/tests/server-routing.test.mjsdocs/clean-room-testing.mddocs/getting-started.mddocs/operations.mddocs/public-release.mdpackages/run-spaceapp/README.mdpackages/run-spaceapp/package.jsonpackages/run-spaceapp/src/cli.mjspackages/run-spaceapp/src/index.mjspackages/run-spaceapp/src/prerequisites.mjspackages/run-spaceapp/tests/command-contracts.test.mjspackages/run-spaceapp/tests/config.test.mjspackages/run-spaceapp/tests/prerequisites.test.mjsscripts/tests/public-package-metadata.test.mjs
Summary
npx --yes run-spaceapp installthe universal Linux, macOS, and Windows 11 Command Prompt installerVerification
npm audit --audit-level=high: 0 vulnerabilities/readyz200Release
This prepares
0.1.11. The release workflow should publish npm and GHCR undernext; keeplatest=0.1.10until the final public clean-room Windows acceptance passes.Summary by CodeRabbit
New Features
spaceappandrun-spaceapplauncher commands.npx --yes run-spaceapp installworkflow across supported platforms.Bug Fixes
Documentation