Skip to content

No comments: Rust app: main, model, frame loop and logs #1599

Closed
2 of 2 issues completed
Closed

Description

@omesser

Part of #1597.

Scope

2600 comment lines in 15 commented files (comment/code 0.17) at main 83733db. Expand the globs in bash; ** means everything under that directory.

src-tauri/src/{main,lib,model,frame_loop,menu,tray,chat_surface,pill_focus,debug,action_log,process_log,session_log,dev_flags,content_mark,names_hint}.rs

Do

Run /no-comments from pstack with exactly these paths as the scope. Follow the rules in #1597:

  • Scope: touch nothing outside these paths. Report anything out of scope as open work in the PR.
  • Comments only: each section PR edits comments only, matching docs/agents/comments.md. When /no-comments finds a code fix (a dead path, a parameter to drop, a real API to use, a shape for /architect, or a type, test or lint encoding for a constraint comment), the agent changes no code in that PR.
  • Follow-ups: the agent files each such fix as its own issue: V1 milestone, ready-for-agent, a priority label per docs/agents/labels.md, and a sub-issue of No comments: Rust app: main, model, frame loop and logs #1599 (of the umbrella if that is not possible). The issue quotes the comment it came from and proposes the fix. The section PR body lists those follow-up issues.
  • Constraint comments: a "do not remove"-style comment whose encoding needs code stays in the comments-only PR, and the encoding is filed as a follow-up, so the constraint is not lost before it is enforced.
  • Length: a surviving comment is 3 lines or fewer, following docs/agents/comments.md and its exceptions (Rust //! module headers, ponytail: markers and the other cases it lists).
  • PR: one PR for this section, opened undrafted when ready, with Closes #1599. P. Architect gates it Soft+Hard, and Oded merges.

Acceptance criteria

  • The skill's full report (deletion count, restores, fixes, encoding offers, open work) is pasted in the PR description.
  • CI is green.
  • The diff edits comments only, and the PR body lists every follow-up issue filed.
  • The diff touches only files matched by the globs above.

— Cursor agent (subagent of P. Architect), on @omesser's behalf.

Activity

  1. added this to the V1 milestone on Oct 18, 2026
  2. added
    ready-for-agentFully specified, ready for an AFK agent
    p2Eventually: real, but nothing waits on it
    on Oct 18, 2026
  3. self-assigned this
    on Oct 22, 2026
  4. moved this from Todo to In Progress in Fidgeton Oct 22, 2026
  5. moved this from In Progress to Done in Fidgeton Oct 22, 2026
  6. omesser commented on Oct 22, 2026

    @omesser
    OwnerAuthor

    Shipped in #1777 (merged to main at 3aea9ea). I checked each acceptance item against the merged PR and ticked all four:

    I also ticked this section in #1597, which stays open.

    — Cursor agent (P. Coder), on @omesser's behalf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

p2Eventually: real, but nothing waits on itready-for-agentFully specified, ready for an AFK agentrefactoring

Projects

  • Status
    Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions