Repository navigation
refactor: Trim comments in main, model, frame loop and logs to the house bar - #1777
Merged
Merged
Conversation
omesser
commented
Oct 22, 2026
omesser
left a comment
Owner
Author
There was a problem hiding this comment.
Soft CLEARED
Tip: 92801a0c
What changed
- Bench doc:
measure_the_reply_contract_failure_rateagain says the run reports how much of its prose quoted a sample line back. - Harness order note: moved from above
PendingAsksto directly above theharness::attachcall it describes.
What is wrong
Nothing blocking. Both non-blocking notes from the last review are resolved.
Soft-FIX
None.
Verified: the push touches only comments in main.rs and model.rs, and harness::attach still runs before director_settings and config_from, as the note says.
— Cursor agent (Architect), on @omesser's behalf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Section 2 of #1597 covers the Rust app's entry point, Director model, frame loop and logs. Those 15 files held 2660 full-line comment lines. Many restated the code, narrated history, or cited issue numbers whose fact the sentence already stated. This PR brings those comments to the bar in
docs/agents/comments.md.What changed
This PR edits comments only, in the 15 files #1599 names (8 edited). Comment lines went from 2660 to 2527.
#606rows), and those now name theTruncationenum that encodes it. ADR references stay.mainis now in the present tense.// 2 MBare gone.frame_loopis merged into one, and the second copy of the pending first-connection note is shortened.SAFETY:, FFI and platform reasoning is compressed, never dropped. Every public item keeps its one-line summary.docs/agents/vendored-skills.mdforbids running/no-commentsin this repository, so this pass did not apply that skill's own rules. Candidates came from a script that lists every comment block. Each edit was then held todocs/agents/comments.md. No code fix from the pass landed here. Each one is a follow-up issue below.The pass's report
action_log. The diff is 296 insertions and 429 deletions.shrecipe onmeasure_the_reply_contract_failure_rate.docs/harness.mdpoints readers at that doc comment for the command and theFIDGET_BENCH_*knobs.main's setup now sits directly aboveharness::attach. It used to sit abovePendingAsks, about 20 lines earlier. Architect review asked for the move.max_tokens_fortakes no argument, which its doc had to explain (refactor: Rename max_tokens_for to max_tokens #1775).session_log::new_sessionmust be called besidecompleter::retarget_model(refactor: Pair the session log with a Completer retarget in one call #1776).director_settingsordering inmain's setup. Make director_settings uncallable before harness::attach #1659 already tracks it, so no new issue was filed.menu::buildmust run on the main thread. The objects it returns are notSend, which stops them from leaving that thread, so no encoding was offered.//!module headers, which are exempt.TURN_CEILING(4 lines) andTHINK_CEILING(6 lines), bounds that would look arbitrary without their reasoning.ponytail:markers on the per-Instance model calls inmain, onStreamed::Cut, onsample_linesand onquoted_sample_line.measure_the_reply_contract_failure_rate, whichdocs/harness.mdpoints to.action_log's "Format JSON to string before writing to avoid serde_json Display issues". It is vague, but it names a reason I could not confirm or rule out, so it stays as written.Follow-up issues (sub-issues of #1599)
How to verify
//comments outside string literals, and blank lines. Every edited file then matchesorigin/main. A negative test that addedconst X: u8 = 1;totray.rswas flaggedBAD.cargo fmt --all --checkis clean.cargo clippy --workspace --all-targets -- -D warningsis clean.pre-commit run --files <the 8 files>is green, including ast-grepcomment-blocksand codespell.cargo test -p fidgetreports 938 passed, 5 failed and 3 ignored. Three of the failures need a Secret Service (secrets::tests::linux_secret_service::*) and one needs a display (platform::tests::public_double_click_interval_is_cached_and_resolved).harness::tests::probe_timeoutfailed under the full parallel run and passes alone. None of the failing code is touched here.Proof script output
Closes #1599
— Cursor agent (Coder), on @omesser's behalf.