Skip to content

fix(security): Parse Shimeji XML with defusedxml, move to zip 9, and audit dependencies in CI - #1735

Merged
omesser merged 26 commits into
mainfrom
security/scan-followups-2026-10
Oct 22, 2026
Merged

omesser merged 26 commits into
mainfrom
security/scan-followups-2026-10

Conversation

@omesser

@omesser omesser commented Oct 21, 2026 •

Copy link
Copy Markdown
Owner

Summary

Follow-ups from the October security review. Secret scanning already landed in #1773.

 scripts/import-pet.py
-  xml.etree + a byte scan for <!ENTITY            # missed UTF-16 packs
+  defusedxml, refusal turned into the same exit message
 src-tauri/
-  zip 8.6 + fidget's own inflate cap in package.rs
+  zip 9.0.5, which refuses an entry inflating past its declared size
+  // SAFETY: on the stderr capture, macOS activation and process-group teardown
 .github/workflows/
+  security.yml        # PRs, main, nightly; in parallel to PR Tests
+    cargo-audit       # latest stable cargo-audit from crates.io, cached by version
+    npm-audit         # --audit-level=high over package-lock.json
   pstack-sync.yml, mattpocock-skills-sync.yml
+    dispatch security.yml at the sync branch, next to PR Tests and Secret Scanning
  • Importer: Image.Resampling.NEAREST / .LANCZOS in import-pet.py and generate-readme-gifs.py. scripts/requirements-import.txt pins pillow>=9.1 and adds defusedxml.
  • zip 9: Only fidget's own zip and the four TLS patch crates move in Cargo.lock. The zip-bomb test now pins zip's own check.
  • cargo audit: It reads the lockfiles and builds nothing. .cargo/audit.toml ignores only the updater's zip 4.6.1 advisories.
  • npm audit: package.json gains marked@18.0.13 as a devDependency with a lockfile. A test keeps that pin equal to the vendored src/vendor/marked.esm.js, which src/vendor/README.md documents along with the ReDoS finding.
  • Docs: docs/DEVELOPMENT.md gets a Dependency Audits section and the importer's new setup line.

Evidence

  • Importer: import-pet.py --self-test passes. With xml.etree swapped back in, the UTF-16 entity pack gets through and the self-test fails.
  • Zip-bomb test: cargo test --locked --bins package:: passes 30/30 on macOS. It fails if zip stops checking declared sizes.
  • Clippy: cargo clippy --workspace --all-targets -- -D warnings is clean.
  • marked pin: node --test tests/chat-markdown.test.js passes. It fails if package.json or the lock moves off the vendored version alone.
  • Secret scan: main's detect-secrets job command passes over the merged tree with no baseline change.
  • CI: Security (cargo-audit, npm-audit) and PR Tests pass at 4d127e8e.

Risk accepted (no code change)

  • marked ReDoS rule: the lexer runs literal patterns only (src/markdown.js).
  • homebrew-cask.rb Open3: argv array, no shell.
  • AX Linux bandit hits: try/except and the xdotool path are verify tooling only.
  • ax-window-linux.py:84 "unsubscriptable": guarded by the best is None short-circuit.

Human follow-ups (out of repo)

  • .env keys: delete the commented keys and rotate the live ones.
  • Stale local worktrees: rebase or prune.
  • GenAI policy sign-offs: corporate accounts, human PR review, audit logging.

Merge Danger

Door: two-way

Blast Radius: CI

A new advisory against any locked crate or npm package now fails Security on every pull request, even one that didn't touch it, until it's bumped or ignored in .cargo/audit.toml. Character Package import now needs defusedxml, so a stale venv needs uv pip install -r scripts/requirements-import.txt.

— Cursor agent, on @omesser's behalf.

omesser and others added 7 commits October 21, 2026 09:30
Document pillow and defusedxml in a shared requirements file for the importer.

Co-authored-by: Cursor <cursoragent@cursor.com>
Keeps resize filters valid on Pillow 10+ without breaking older aliases.

Co-authored-by: Cursor <cursoragent@cursor.com>
Covers stderr capture pipes, macOS window activation, and harness SIGKILL paths.

Co-authored-by: Cursor <cursoragent@cursor.com>
Refresh the lockfile; document RUSTSEC-2024-0429 until Tauri pulls glib 0.20+.

Co-authored-by: Cursor <cursoragent@cursor.com>
Runtime still serves src/vendor/marked.esm.js; devDependency mirrors the pinned version.

Co-authored-by: Cursor <cursoragent@cursor.com>
The vendored file is minified; src/markdown.js never feeds user regex patterns.

Co-authored-by: Cursor <cursoragent@cursor.com>
Covers Homebrew checksums, updater public keys, and test token field names.

Co-authored-by: Cursor <cursoragent@cursor.com>
omesser

This comment was marked as outdated.

Bump fidget's zip to 9.0.5; restore main lockfile aside from that line.
Document ignored transitive zip/glib and unmaintained advisories in .cargo/audit.toml only.
Drop deny.toml, exclude .venv-security from scans and gitignore, refresh baseline.

Co-authored-by: Cursor <cursoragent@cursor.com>
@omesser

omesser commented Oct 21, 2026 •

Copy link
Copy Markdown
Owner Author

Addressed the Soft Open at c33b1b41:

  • cargo audit: Restored Cargo.lock to main except zip 8.6 → 9.0.5 (direct fidget dep). Extended .cargo/audit.toml with ignores for updater’s transitive zip 4.6.1 (read-only archive parse, no extract) and the four unmaintained zbus/proc-macro advisories. Removed duplicate deny.toml.
  • Baseline: Regenerated without .venv-security/; added that path to .gitignore.
  • Docstring: import-pet.py header now mentions defusedxml.

Expect Linux cargo audit --deny warnings to pass on the next run.

— Cursor agent, on @omesser's behalf.

omesser and others added 2 commits October 21, 2026 21:58
Drop unsupported audit.toml unmaintained section; run cargo audit without --deny warnings.

Co-authored-by: Cursor <cursoragent@cursor.com>
Align audit ignores with unmaintained advisories; bump rustls/webpki for audit DB.

Co-authored-by: Cursor <cursoragent@cursor.com>
@omesser

omesser commented Oct 21, 2026 •

Copy link
Copy Markdown
Owner Author

Follow-up at e9717c24: all PR checks are green.

  • Linux cargo audit passes (rustls/webpki bumped; glib/zip/updater/unmaintained ignores in .cargo/audit.toml).
  • zip 9: FileOptions lifetimes + zip-bomb test expects `declared` in the error text.
  • Prior Soft-FIX items (baseline, lockfile scope, docstring, dropped deny.toml) remain in c33b1b41.

Ready for another look when you have a moment.

— Cursor agent, on @omesser's behalf.

omesser

This comment was marked as outdated.

@omesser omesser added the security Security related - secrets, password, key-chain management, etc label Oct 21, 2026
Reset Cargo.lock to main, then bump only fidget's zip 9 and the four
rustls/webpki crates cargo-audit needs. Clarify why updater zip 4.6.1
advisories are ignored.

Co-authored-by: Cursor <cursoragent@cursor.com>
@omesser

omesser commented Oct 21, 2026 •

Copy link
Copy Markdown
Owner Author

Addressed second Soft Open at 0c7a1f33:

  • Lockfile: Reset to main, then only zip@8.6.0 → 9.0.5 and the four TLS crates (rustls, rustls-webpki, webpki-root-certs, webpki-roots) — no Harness/updater bumps.
  • Audit ignore comment: Updater signed Windows bundles; advisories are Unix permission/symlink handling.
  • PR body: Dropped deny.toml / whole-lockfile wording.

— Cursor agent, on @omesser's behalf.

omesser

This comment was marked as outdated.

omesser

This comment was marked as outdated.

omesser

This comment was marked as outdated.

- import-pet: defusedxml is the only entity guard; its refusal exits
  cleanly, and the self-test covers UTF-16, which the byte scan missed.
- Pillow: Image.Resampling directly; requirements state pillow>=9.1.
- package.rs: drop the cap zip 9 makes unreachable; the zip-bomb test
  now says it pins zip's own declared-size check.
- CI: prebuilt cargo-audit; audit.toml keeps only the ignores that
  change the exit code.
- npm: package name fidget; test ties package.json and the lock to the
  vendored marked version.
- DEVELOPMENT.md: name defusedxml, drop "glance".

Co-authored-by: Cursor <cursoragent@cursor.com>
@omesser

omesser commented Oct 21, 2026

Copy link
Copy Markdown
Owner Author

Addressed both Soft+Hard reviews at 6364235f:

  1. defusedxml: The <!ENTITY byte scan is gone. DefusedXmlException exits with the same "declares an XML entity" message. --self-test now writes the bomb in UTF-8 and UTF-16, and it fails when xml.etree is swapped back in.
  2. Zip-bomb test: fidget's take and size check are removed, because zip 9 makes them unreachable. The comment and the test doc now say the test pins zip's own declared-size check. Budget::charge returns (), since nothing reads the remainder anymore.
  3. Pillow: Image.Resampling.NEAREST / .LANCZOS directly, with no fallbacks, and _RESAMPLE_LANCZOS is deleted. requirements-import.txt says pillow>=9.1.
  4. Audit ignores: The five warning-only ignores (glib and the four unmaintained crates) are dropped. Only the updater's three zip 4.6.1 IDs remain, because they are the ones that change the exit code.
  5. cargo-audit install: taiki-e/install-action pinned by SHA (v2.87.30) replaces cargo install.
  6. npm: package.json gets "name": "fidget", so the lock is named fidget. The vendored-hash test also asserts that package.json and package-lock.json pin the version in the vendored file's header.
  7. Docs: DEVELOPMENT.md names defusedxml, and "glance" is dropped.
  8. Signing: The PR body and my three earlier comments are now signed.

The audit-on-every-PR policy question is listed under human follow-ups in the PR body.

Checked locally (macOS): --self-test, package:: 30/30, workspace clippy, and tests/chat-markdown.test.js. Linux CI is running now.

— Cursor agent, on @omesser's behalf.

omesser

This comment was marked as outdated.

omesser

This comment was marked as outdated.

taiki-e/install-action is not on the repo's Actions allowlist, so PR
Tests hit startup_failure. Download cargo-audit v0.22.2 and check its
sha256 in a run step instead. The vendored-marked test uses one version
constant for the hash message and both pin checks.

Co-authored-by: Cursor <cursoragent@cursor.com>
omesser

This comment was marked as outdated.

omesser

This comment was marked as outdated.

@omesser

omesser commented Oct 21, 2026

Copy link
Copy Markdown
Owner Author

CI is green at 3f6721ee, which meets the "pending CI" condition on the Soft+Hard clear. The ubuntu job ran Install cargo-audit (the pinned v0.22.2 release, sha256 checked) and Cargo audit, and both passed. The job took 3m16s, down from 6m58s when it built cargo-audit from source. macOS, Windows and renderer also passed.

— Cursor agent, on @omesser's behalf.

omesser

This comment was marked as outdated.

@omesser

omesser commented Oct 22, 2026

Copy link
Copy Markdown
Owner Author

Secret scanning moved to its own workflow, .github/workflows/secret-scanning.yml (e604eb0), adapted from the shared secret-scanning.yaml:

  • trufflehog: TruffleHog 3.99.3 from its digest-pinned Docker image. The trufflesecurity/trufflehog action isn't on this repo's Actions allowlist and would cause a startup_failure. It scans PR base..head, push before..after, or full history on dispatch, and fails only on verified secrets.
  • detect-secrets: the former security.yml secrets job, moved unchanged.

security.yml now carries only cargo-audit and npm-audit. Both sync workflows also dispatch Secret Scanning and link its runs. This push also brings in a merge of main and a pragma for main's e2e-macos.yml run block, which tripped detect-secrets on the merge ref.

— Cursor agent, on @omesser's behalf.

omesser

This comment was marked as outdated.

omesser

This comment was marked as outdated.

…wlist the whole block.

Co-authored-by: Cursor <cursoragent@cursor.com>

omesser commented Oct 22, 2026

Copy link
Copy Markdown
Owner Author

Oded decided: secret scanning stays in its own secret-scanning.yml, and the pragma on the TruffleHog IMAGE line stays, like his other five. Neither is a fix item.
The one open fix is unchanged: move the two run: | # pragma: allowlist secret lines (e2e-macos.yml:56, secret-scanning.yml:73) into .secrets.baseline entries.

— Cursor agent (P. Architect), on @omesser's behalf.

@omesser

omesser commented Oct 22, 2026

Copy link
Copy Markdown
Owner Author

Fixes from the Soft+Hard gate and the Soft Open at e604eb0f, in bbf5e8d0:

  • Run-block pragmas (Hard fix): Removed both run: | # pragma: allowlist secret pragmas, e2e-macos.yml:56 and secret-scanning.yml:73. Their two hits are now baseline entries, which match only those hashed values. Checked locally with 1.5.0: the clean tree exits 0. A planted export DEPLOY_PASSWORD=… inside either block exits 1. docs/DEVELOPMENT.md now says that a hit inside a YAML block goes in the baseline.
  • IMAGE pragma: Dropped. Neither 1.5.0 nor glance's 1.5.47 build flags the digest line without it, so it marked nothing. The five Oded chose to keep are unchanged.
  • One workflow file or two: Oded asked for the dedicated secret-scanning.yml, so the split is intentional.

— Cursor agent, on @omesser's behalf.

omesser

This comment was marked as outdated.

omesser

This comment was marked as outdated.

…ining them.

Co-authored-by: Cursor <cursoragent@cursor.com>
@omesser

omesser commented Oct 22, 2026

Copy link
Copy Markdown
Owner Author

Fixes from the Soft+Hard gate at bbf5e8d0, in e6a36fc7:

  • Run blocks have no hits, and both baseline entries are gone.
    • e2e-macos.yml: FIDGET_DIRECTOR_API_KEY: x is now in the warm-up step's env:, so it's off the command line.
    • secret-scanning.yml: The suggested quoting, pip install 'detect-secrets==1.5.0', doesn't work. 1.5.0 keeps only a block's first keyword match and then filters out the quoted value. The block reports nothing, and a DB_PASSWORD=… planted anywhere below the line still exits 0, with no baseline entry. The pin is now env: SCANNER: detect-secrets==1.5.0 with pip install "$SCANNER". The env key avoids secret so the mapping line doesn't trip the keyword detector itself.
    • Mutation pass with 1.5.0 over every tracked file: the clean tree exits 0. A planted DB_PASSWORD exits 1 at the top and the bottom of both blocks.
  • IMAGE pragma restored, following Oded's call.
  • DEVELOPMENT.md: A hit in a YAML block goes into the step's env:, never a pragma or baseline entry. It also notes that quoting hides every later hit.

— Cursor agent, on @omesser's behalf.

omesser

This comment was marked as outdated.

omesser

This comment was marked as outdated.

Comment thread .pre-commit-config.yaml Outdated

# Rewrites `.secrets.baseline` when a known hit moves; commit the rewrite.
# CI runs it in secret-scanning.yml, which fails on new secrets only.
- repo: https://github.com/Yelp/detect-secrets

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's either a lint or isn't. if it's fast enough to be a lint step, don't skip in CI, and remove from secret scanning workflow

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, it's a lint. Done in 382be4a8. The hook takes about 1.3 s on a typical commit locally and about 30 s for a full-tree scan of 1,219 files. PR Tests' pre-commit step no longer skips it, docs-only runs included. The detect-secrets job is gone from secret-scanning.yml, which now runs only TruffleHog. A stale baseline line number now fails CI like any other fixer hook, instead of the old job's warning.

— Cursor agent, on @omesser's behalf.

…nning keeps only TruffleHog.

Co-authored-by: Cursor <cursoragent@cursor.com>
omesser

This comment was marked as outdated.

omesser

This comment was marked as outdated.

Co-authored-by: Cursor <cursoragent@cursor.com>
@omesser

omesser commented Oct 22, 2026

Copy link
Copy Markdown
Owner Author

Split done, per the Soft+Hard gate at 382be4a8:

  • Fix 1 (move out): #1773, based on main at 16838a95, now has:
    • secret-scanning.yml (TruffleHog only) and .secrets.baseline, refreshed against its own tree.
    • The detect-secrets hook and its pre-commit-scans-everything test change, moved together.
    • Every pragma, including the one on chat-markdown.test.js:529. The vendored constant and the lock pin check stay here.
    • The e2e-macos.yml env: move and the docs paragraph, now under Pre-commit Hooks.
    • The sync-workflow dispatch of secret-scanning.yml. PR Tests' pre-commit step there skips nothing.
    • Here, 483e9299 returns all of those to main's versions or deletes them.
  • Fix 2: The security.yml:5 line naming secret-scanning.yml is dropped.
  • Fix 3: tests.yml is back to main's text and is out of the diff.
  • Fix 4: In the PR body, the secret-scanning bullet, the detect-secrets risk item and the three secrets test-plan lines are gone, replaced by a link to ci: Scan for secrets with detect-secrets in pre-commit and TruffleHog on each pull request #1773.
  • Fix 5: Both sync workflows dispatch only tests.yml and security.yml. Their body text says "both" and links those two runs.

19 files remain against main. node --test tests/pre-commit-scans-everything.test.js tests/chat-markdown.test.js passes 43/43, and every pre-commit hook passes. #1773 and this PR both touch the sync workflows and tests/chat-markdown.test.js, so whichever merges second merges main first.

— Cursor agent, on @omesser's behalf.

omesser

This comment was marked as outdated.

omesser

This comment was marked as outdated.

…ps-2026-10

Co-authored-by: Cursor <cursoragent@cursor.com>

# Conflicts:
#	.github/workflows/mattpocock-skills-sync.yml
#	.github/workflows/pstack-sync.yml
#	tests/chat-markdown.test.js
@omesser omesser changed the title Harden import-pet XML and address security-review follow-ups fix(security): Parse Shimeji XML with defusedxml, move to zip 9, and audit dependencies in CI Oct 22, 2026

@omesser omesser left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soft CLEARED

Tip: 4d127e8e

What changed

  • Main merged in: brings in secret scanning from #1773 plus eight other main commits; the PR's own changes are untouched.
  • Sync workflows resolved: pstack-sync.yml and mattpocock-skills-sync.yml now dispatch PR Tests, Security and Secret Scanning at the sync branch, and the PR body text names all three.
  • Docs and test resolved: the Security paragraph moves under its own Dependency Audits heading in docs/DEVELOPMENT.md, and the marked hash in tests/chat-markdown.test.js keeps its allowlist pragma.

What is wrong
Nothing blocking. Each conflict keeps both sides, and all three dispatched workflows accept workflow_dispatch.

Soft-FIX
None

Verified: read the merge's conflict resolutions, ran the chat-markdown, skills-layout, skills-ownership and scenario-cleanup tests green at this tip, and parsed every workflow.

— Cursor agent (Architect), on @omesser's behalf.

@omesser omesser left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soft+Hard — tip 4d127e8e — Not cleared

Axis Verdict
Soft Fail
Spec Pass
Hard Pass
Total Not cleared

The code at this tip is ready. The one fix is a broken sentence in the PR body. Since my gate at 483e9299, the only new commit merges main, which brings in secret scanning from #1773, now merged. I checked how each conflict was resolved. The other-account reviews agree on the code: Soft CLEARED at 4d127e8e and Soft CLEARED at 483e9299. Neither covers the PR body.

Checklist

  • Head is 4d127e8e, open, not a draft, mergeable. Its parents are 483e9299 and main at 6cf630d1 (#1773).
  • No secret scanning in the diff. Against main, 19 files change, and none of them is secret-scanning.yml, .secrets.baseline, .pre-commit-config.yaml, tests.yml, e2e-macos.yml, src/settings.js, the three settings tests or pre-commit-scans-everything.test.js. The PR adds no allowlist pragma, and tests/chat-markdown.test.js:529's pragma comes unchanged from main. DEVELOPMENT.md's Secret Scanning section is main's text.
  • Nothing lost in the split. Compared with the cleared e6a36fc7, only files on the move-out list dropped out. security.yml, .cargo/audit.toml, package.json and its lock, the marked pin test, the import-pet.py defusedxml change, requirements-import.txt, the Image.Resampling changes, zip 9 with its package.rs changes, and the SAFETY: comments in acp_wire.rs, platform.rs and process_log.rs are all here. The SAFETY: comments survived #1777's comment trim in the merge.
  • Merge resolution: both sync workflows dispatch tests.yml, security.yml and secret-scanning.yml. Each dispatch is non-fatal and logs its own ::error::. Their actions: write comment, step name and PR body text all say "all three". All three workflows accept workflow_dispatch. The line in security.yml naming secret-scanning.yml came back with the merge, and it is accurate now that the file is on main.
  • security.yml follows your cargo-audit decision. It reads max_stable_version from the crates.io API with jq and fails fast on an empty or null answer. It caches ~/.cargo/bin/cargo-audit with the SHA-pinned actions/cache keyed on that version and runs cargo install cargo-audit --locked --version on a miss. npm-audit runs --audit-level=high over package-lock.json. The jobs run in parallel to PR Tests. Every action is GitHub's own and pinned to the same SHA used in tests.yml, so the allow-list needs nothing. actionlint reports nothing on security.yml.
  • Tests at this tip: node --test tests/*.test.js gives 816 pass and 0 fail. import-pet.py --self-test passes. cargo test --locked --bins package:: passes 31/31 on Linux.
  • House rules: no sleeps or polls, and no string-then-regex parsing (jq reads the version). Every new comment is 3 lines or fewer. Harness text is untouched.

Mutation pass

Each mutation was reverted afterwards, and the tree is clean.

Mutation Result
import-pet.py back on xml.etree self-test fails
import-pet.py back on main's guard (xml.etree and the ASCII <!ENTITY scan) self-test fails on the UTF-16 pack, so the new test is red without the fix
package.rs swallowing zip's read error (let _ = entry.read_to_end(..)) an_archive_entry_that_inflates_past_what_it_declares_is_refused fails
package.json marked moved to 18.0.12 alone the pin test in chat-markdown.test.js fails
package.rs ignoring budget.charge(entry.size()) survives: all 31 pass. No test covers the budget on either path, and that gap is on main too. See Non-blocking

CI at 4d127e8e

Every check run is on this head SHA and none is a startup_failure. Security passed: cargo-audit in 3m20s and npm-audit in 10s. PR Tests passed: checks on ubuntu and macos, renderer and windows. Secret Scanning (detect-secrets, trufflehog) from main passed, and so did Pages build, with deploy skipped. cargo-audit 0.22.2 was a cache miss this time and was installed with --locked. The cache entry from 483e9299 was gone, and the new one is saved.

Soft — Fail

  • Fix: the PR body's Evidence list stops mid-sentence: "CI: Security (cargo-audit, npm-audit) and PR Tests". Finish it, for example "…and PR Tests pass at 4d127e8e", or drop the bullet.

Spec — Pass

The scope after the split is all here and nothing more: security.yml, its dispatch from the two sync workflows, the marked devDependency and lock with the pin test, the defusedxml hardening of import-pet.py, and the other security-review follow-ups (zip 9, SAFETY: comments, Image.Resampling, the vendor README note). No secret-scanning content remains, and the PR body links #1773.

Hard — Pass

  • Importer: defusedxml refuses entity declarations in any encoding. Proven at step 4: the self-test passes, and main's guard fails it on UTF-16.
  • Zip: zip 9 refuses an entry that inflates past the size it declares. Proven at step 4: the zip-bomb test passes, and it fails when the read error is swallowed. The budget charge's behaviour is unchanged from main, and it still returns early with ?.
  • CI blast radius: a new advisory fails Security on every PR until it is bumped or ignored. The PR body's Merge Danger accepts that. The sync dispatches cannot fail their jobs.

Non-blocking

  • The surviving mutant above: nothing tests that an archive declaring more than MAX_PACKAGE_BYTES, or holding more than MAX_PACKAGE_FILES entries, is refused. The new read_archive comment relies on that charge ("a zip bomb stops at what was charged"). The gap is on main too, so a follow-up test fits better than a fix here.
  • The cargo-audit cache saved on a PR ref serves only that PR. Once security.yml runs on main, its cache is shared by every PR.
  • Carried over: .gitignore's .venv-security/ is a local scratch venv and can stay.

Fix list: finish or drop the CI bullet in the PR body. Oded merges himself.

— Cursor agent (subagent of P. Architect), on @omesser's behalf.

@omesser omesser left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soft+Hard — tip 4d127e8 — Cleared

Axis Result
Spec Pass
Hard Pass
Soft Pass. The one open item from the previous gate, the cut-off CI bullet under Evidence, is now finished in the PR body (a body-only edit, with no code change since that gate).
CI Green at this tip

Fix list empty. The other account's Soft CLEARED review at this tip (5619725090) agrees.

A non-blocking gap that is also on main: nothing tests the archive size or file-count limits in package.rs. A follow-up issue is filed for it.

— Cursor agent (P. Architect), on @omesser's behalf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security Security related - secrets, password, key-chain management, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant