Repository navigation
chore: Prune dead code and tests that restate their own setup - #1778
Merged
Merged
Conversation
…26-10-22 # Conflicts: # src-tauri/src/session_log.rs
omesser
commented
Oct 22, 2026
omesser
left a comment
Owner
Author
There was a problem hiding this comment.
Soft CLEARED
Tip: 723b7d6c
What changed
- Merge from main: brings in #1777 and #1779 on top of the prune I cleared at
a794f7b2. - Conflict in
session_log.rs: resolved by keeping this branch's merged test and comment and taking main's trimmed issue references elsewhere in the file.
What is wrong
Nothing blocking. The resolution keeps both sides, and the PR's diff against main is the same prune I reviewed before.
Soft-FIX
None
Verified: fidget-core tests pass, and src-tauri tests pass except the Linux Secret Service tests, which fail on this headless box with or without this change.
— Cursor agent (Architect), on @omesser's behalf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
model::config()wrapper (already#[expect(dead_code)], no callers) and theActivity::with_frontmostfixture, whose last caller went in feat(director): Send the desktop as short labelled lines #1377.Placed.maskandoverlay_rects_forare read off macOS, andDockSourceis built on macOS, so each blanket#[allow(dead_code)]becomes acfg_attron the one platform where the item really is dead.window_source_rect_accepts_as_engine_rect, which checked that apub usere-export is the same type.retarget_forgets_the_old_sessionanda_switched_buddy_does_not_forget_the_others. Both callLog::forgetdirectly, likeforgetting_one_instance_leaves_the_others_conversation, which asserts a superset of what they check. Its doc now names Retarget and a Character switch.tabTitles()fromsrc/settings.js. Only its test used it, so the test now mapsform.tabsinline.scripts/scenarios/helpers/test-trace-formats.ps1, which checked hand-copied regexes against hand-written sample lines. Nothing references it and CI doesn't run it.Why
Sendwitnesses and ignored desktop probes chore: Prune unread mask-rebuild counters and restated tests #1236 kept, are all left alone.How to test
cargo fmt --checkcargo clippy --workspace --all-targets -- -D warnings, on each CI lane. The macOS and Windows lanes check the narrowedcfg_attrs.cargo test --workspacenode --test tests/— Cursor agent (Coder), on @omesser's behalf.