Skip to content

chore: Prune dead code and tests that restate their own setup - #1778

Merged
omesser merged 2 commits into
mainfrom
chore/weekly-prune-2026-10-22
Oct 22, 2026
Merged

omesser merged 2 commits into
mainfrom
chore/weekly-prune-2026-10-22

Conversation

@omesser

@omesser omesser commented Oct 22, 2026

Copy link
Copy Markdown
Owner

What

  • Dead code: drops the env-only model::config() wrapper (already #[expect(dead_code)], no callers) and the Activity::with_frontmost fixture, whose last caller went in feat(director): Send the desktop as short labelled lines #1377.
  • Dead-code attributes narrowed: Placed.mask and overlay_rects_for are read off macOS, and DockSource is built on macOS, so each blanket #[allow(dead_code)] becomes a cfg_attr on the one platform where the item really is dead.
  • Assertion-free test: drops window_source_rect_accepts_as_engine_rect, which checked that a pub use re-export is the same type.
  • Duplicate coverage: drops retarget_forgets_the_old_session and a_switched_buddy_does_not_forget_the_others. Both call Log::forget directly, like forgetting_one_instance_leaves_the_others_conversation, which asserts a superset of what they check. Its doc now names Retarget and a Character switch.
  • Test-only export: drops tabTitles() from src/settings.js. Only its test used it, so the test now maps form.tabs inline.
  • Tautological script: deletes scripts/scenarios/helpers/test-trace-formats.ps1, which checked hand-copied regexes against hand-written sample lines. Nothing references it and CI doesn't run it.

Why

How to test

  • Format: cargo fmt --check
  • Lint: cargo clippy --workspace --all-targets -- -D warnings, on each CI lane. The macOS and Windows lanes check the narrowed cfg_attrs.
  • Rust tests: cargo test --workspace
  • Node tests: node --test tests/

— Cursor agent (Coder), on @omesser's behalf.

omesser

This comment was marked as outdated.

…26-10-22

# Conflicts:
#	src-tauri/src/session_log.rs

@omesser omesser left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soft CLEARED

Tip: 723b7d6c

What changed

  • Merge from main: brings in #1777 and #1779 on top of the prune I cleared at a794f7b2.
  • Conflict in session_log.rs: resolved by keeping this branch's merged test and comment and taking main's trimmed issue references elsewhere in the file.

What is wrong
Nothing blocking. The resolution keeps both sides, and the PR's diff against main is the same prune I reviewed before.

Soft-FIX
None

Verified: fidget-core tests pass, and src-tauri tests pass except the Linux Secret Service tests, which fail on this headless box with or without this change.

— Cursor agent (Architect), on @omesser's behalf.

@omesser
omesser merged commit d0210f5 into main Oct 22, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants