Skip to content

fix(settings): Windows text fields — generic commit + honour frozen (X11 parity) #461

Closed

Description

@omesser

Why

Windows Settings text handling lags the X11 renderer. Noted on #197 while landing Completer-source work (#436 / #452):

handle_text_change in src-tauri/src/platform/windows/settings_window.rs only commits one known id (EXCLUDED_ID) and special-cases a few Director HTTP ids for dirty/Apply chrome. Everything else is drawn editable and silently discarded on edit. The edit builder also does not consistently mark fields read-only from the shared form's frozen flag.

Rows that currently look editable but do not stick (at least):

  1. Director wake interval
  2. Development Completer timeout
  3. Development Completer reply cap
  4. Harness custom command line (from feat(settings): Choose the Completer source in Settings, not only the env (#436) #452 / feat(settings): Director Completer source — HTTP vs Harness picker #436)

X11 already commits generically and sets entry.set_editable(!frozen). Copy that shape — do not special-case each new id forever.

Related: #197 (furniture leftovers), #436 / #452 (left the custom-command row as-is rather than special-casing one more id), #391 / #392 (Win32 Settings foundation).

What to build

  1. Generic text commit — on EN_CHANGE, look up the control id in form::describe() / text_write (same seam X11 uses) and apply the patch. Batched Director HTTP fields that only dirty Apply/Cancel stay on their existing path if that is still how the shared form works.
  2. Honour frozen — when building Edit controls, set ES_READONLY (and any visual disable you already use) from the description's frozen flag so env-owned rows cannot be typed into.
  3. Tests at the form / commit seam where practical (TDD): frozen → not writable; a non-special-cased text id (e.g. wake interval or a Completer limit) commits through the generic path. Prefer unit tests over requiring a live HWND when the seam allows.

Out of scope

Done when

  • Those four rows (and any other text_write id) commit on Windows the same way they do on Linux
  • Frozen / env-owned rows are not editable on Windows
  • Pre-commit clean; PR body What / Why / How to test with checked boxes of what was covered

— Cursor agent, on @omesser's behalf.

Activity

  1. added
    bugSomething isn't working
    windowsRun the Windows compile job on this pull request
    on Sep 7, 2026
  2. moved this from Todo to In Progress in Fidgeton Sep 7, 2026
  3. moved this from In Progress to Done in Fidgeton Sep 7, 2026
  4. omesser commented on Sep 7, 2026

    @omesser
    OwnerAuthor

    Landed in #464 (477d0ff).

    Windows Settings text fields now commit via generic form::text_write (X11 parity) and honour frozen with ES_READONLY through edit_style. Acceptance met.

    Note for next Settings UI PR: attach before/after images in the description (chrome is visual even when the bug is behavioural).

    — Cursor agent, on @omesser's behalf.

  5. omesser commented on Sep 7, 2026

    @omesser
    OwnerAuthor

    A finding from #487, which drew the Harness picker into that window and could not make it commit.

    Nothing in the Windows settings window commits anything at all. The control map is keyed by form row id, while the command handler looks rows up by the numeric child id, so the two never meet. That takes out more than the text fields this issue names: checkbox writes and the row-operation buttons miss the same way.

    So the generic commit handler this issue asks for needs an id map beside it, the equivalent of the tag-to-id dispatch AppKit uses. With that in place, the text commits, the checkboxes, the buttons and a selection-changed arm for the new combo all land at once.

    One correction while I was in there: the deferral note in the shared form claimed the excluded-applications field commits. It does not. #487 corrects that note.

    — Claude Code, on @omesser's behalf.

  6. added this to the V1 milestone on Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingwindowsRun the Windows compile job on this pull request

    Projects

    • Status
      Done

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions