Repository navigation
feat(settings): Choose the Completer source in Settings, not only the env (#436) - #452
Merged
Merged
Conversation
This was referenced Sep 7, 2026
omesser
added a commit
that referenced
this pull request
Sep 7, 2026
Six review findings on #452. A configured Harness that never spawned left a handle, which froze the three HTTP rows and hid the only Completer left; the state line now separates set-from-answering and names what the row will do on the next launch. An exported blank AI_BUDDY_HARNESS is the kill switch again. A command line in the source field moves to the row that writes it, so re-picking Custom is not a silent Off, a pick of the entry already shown writes nothing, and the patch debug prints the program name rather than a command line that may carry a token (ADR-0010 rule 7). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
7 tasks done
… env One picker over the four values `AI_BUDDY_HARNESS` already takes, frozen while the variable is exported. The three HTTP rows say so when a Harness is attached: it is the Completer, so they drive nothing. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
A popup reached by tag, like every field already is, so a second one needs no selector of its own. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Six review findings on #452. A configured Harness that never spawned left a handle, which froze the three HTTP rows and hid the only Completer left; the state line now separates set-from-answering and names what the row will do on the next launch. An exported blank AI_BUDDY_HARNESS is the kill switch again. A command line in the source field moves to the row that writes it, so re-picking Custom is not a silent Off, a pick of the entry already shown writes nothing, and the patch debug prints the program name rather than a command line that may carry a token (ADR-0010 rule 7). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ntence Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
omesser
force-pushed
the
feat/436-harness-settings-row
branch
from
September 7, 2026 06:35
60dd300 to
bd9a28a
Compare
This was referenced Sep 7, 2026
This was referenced Sep 7, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #436.
What changed
claude,hermesandopencode, plus a text field for a custom command line. It bindsAI_BUDDY_HARNESSwith the same env-ownership pattern as the other Director rows, so a variable that owns the row shows its value, names itself, and takes no edit.What it looks like
The Director tab on AppKit, in the three states the section can be in. Click a shot for full size. Checked in under
docs/pr/and linked by commit SHA, perdocs/agents/writing.md.Not attached. The HTTP Completer above is the Director's mind.Its rows above stay live, so Apply is enabled.hermes attached, session 655092d4…The HTTP rows above are frozen, which shows in Apply and Cancel going grey.nosuchharness is set but not running…and the HTTP rows stay live. This is the review finding: a missing binary cannot leave the Director with no reachable Completer.In the last two the picker is frozen and labelled because
AI_BUDDY_HARNESSwas exported to force the state for the photograph. With the variable unset the picker is the editable control the first shot shows.Restart, not live switching
The row's help says any change takes the next launch. The attached Session is a process-global held for the app's lifetime by ADR-0008, so live switching means a re-initialisable global plus shutdown ordering in files two sibling pull requests are editing. The issue's fourth item is satisfied structurally instead: the source rows are absent from the retarget set, so a Retarget never touches the attached handle and keeps handing the Completer the Session already up. A test pins that.
ADR-0010
No credential field anywhere, asserted by a test. The login command is display-only text and is never run. Nothing writes a provider key into the child environment.
Platforms, plainly
AppKit is built and tested here, and the picker, the state line and the command line all work there.
How to verify
cargo test -p ai-buddy253 tests pass, sixteen of them new.
cargo fmt --check,cargo clippy --workspace --all-targets -- -D warnings,cargo test --workspace, andpre-commit run --all-filesall pass.One known limit
A dead attachment still counts as configured deeper in
model.rs, so a key typed into the now-live HTTP rows is not used until relaunch. Making HTTP take over live would contradict ADR-0008's failure-to-Static policy and sits in files the sibling pull requests own. What this change guarantees is a way back that does not need a text editor.Conflicts to expect
This edits ADR-0017 at its old path and #449 renames that file. It also changes
harness::attachand its caller, which #450 and #451 both touch. Whichever of the four lands last wants a rebase, and the ADR one is a rename against an edit rather than a textual clash.— Claude Code, on @omesser's behalf.