Skip to content

docs/naming: Optional Completer vocabulary sync (post-#466) #589

Closed

Description

@omesser

Why

#466 / #561 are UX-only (option A): keep Director as the domain role, keep AI_BUDDY_DIRECTOR_*, user-facing AI / Model / API / AI source / HTTP limits — not Completer-as-brand. Shell identifier half-renames (DirectorDraft→CompleterDraft, etc.) are reverted on that PR.

This issue tracks option B: a deliberate pass to make docs/identifiers match the type model if anything still drifts after A. It is not “rename Completer → ModelDirector” (wrong layer).

Type model (source of truth)

Director (role)
├── StaticDirector
└── ModelDirector<C: Completer>
         └── Completer (trait) = HTTP Endpoint | Harness Session
              └── AnyCompleter picks one

Env: AI_BUDDY_DIRECTOR_* = HTTP Completer knobs under the Director role; AI_BUDDY_HARNESS = sibling fill. Do not Completer-ize env names.

Honest gap analysis vs main (after A)

On main, naming is already close to the model above:

Piece On main today Verdict
Completer trait HTTP | Harness Correct
ModelDirector / StaticDirector Strategies Correct
AnyCompleter / Endpoint Picker / HTTP impl Correct
AI_BUDDY_DIRECTOR_* HTTP knobs Correct — keep
CONTEXT Completer “Whatever answers… Harness or HTTP” Correct vs trait
CONTEXT Director Role Correct; #466 adds UX guidance only
director_settings / DirectorDraft / DirectorRun Shell names for Settings/AI tab + HTTP resolve Acceptable; they sit under the Director role
director_enabled Role on/off (Static vs AI path) Correct — not “is Completer present”

So B is optional cleanup, not a mandatory architecture repair. Do not open a large rename PR unless a gap below still hurts after #466 merges.

Remaining gaps (explicit — only these)

G1 — CONTEXT Completer _Avoid_ and user-facing rule (docs)

Main Completer _Avoid_: Model, LLM, provider, API.
Missing: Avoid Completer as Settings/README brand (say AI / Model / Harness).
#466 UX copy should also be reflected in Director _Avoid_ (don’t label Completer knobs “Director” on screen).

Change if needed: 1–2 sentences in CONTEXT. No code.

G2 — “Completer” still on screen in Development (UX leftover)

If after #466 any Settings string still brands Completer (e.g. old “Completer limits”, “Completer source”, help text “Harness is the Completer” shown to users), rephrase to AI source / HTTP limits / “Harness fills Director”.

Change if needed: copy only. Grep Settings form strings for user-visible Completer.

G3 — Mild imprecision: DirectorSettings / DirectorConfig mean HTTP Completer config

These types hold base URL / model / key for the HTTP Completer, not the whole Director role (Harness ignores them). Name is slightly wide.

Optional rename: HttpCompleterSettings / HttpCompleterConfig (or keep; low value). Env stays AI_BUDDY_DIRECTOR_*.

G4 — Do not treat as gaps

G5 — #561 tip-only regression (should die with A)

Tip briefly redefined CONTEXT Completer as HTTP-only and renamed shell helpers to Completer* while leaving director_enabled / env as Director*. That hybrid is not the target; A reverts it. If any of that lands on main, fix under #466 — not here.

Acceptance

Related

— Cursor agent (Architect), on @omesser's behalf.

Activity

  1. added this to the V1 milestone on Sep 9, 2026
  2. self-assigned this
    on Sep 17, 2026
  3. omesser commented on Sep 17, 2026

    @omesser
    OwnerAuthor

    Replacement for #766, which already landed as #778. One owner, one PR off main. Watch reviews until approved. Will not merge.

    — Grok Build agent, on @omesser's behalf.

  4. moved this from 👷 Todo to 🏗 In Progress in Fidgeton Sep 17, 2026
  5. moved this from 🏗 In Progress to 🏁 Done in Fidgeton Sep 18, 2026
  6. omesser commented on Sep 18, 2026

    @omesser
    OwnerAuthor

    Shipped on main via #833 (4fd15a9).

    Acceptance is met:

    • G1 — CONTEXT Completer _Avoid_ now names Settings/README replacements (AI, Model, API, AI source, Harness).
    • G2 — README no longer brands Completer; Settings → AI matches the shipped tab. PR grep found no user-visible Completer in Settings form strings.
    • G3 — Decision recorded: keep DirectorSettings / DirectorConfig (HTTP knobs under the Director role).
    • No env rename; no Completer → ModelDirector.

    Closing as completed (already closed by Closes keyword).

    — Cursor agent (Coder), on @omesser's behalf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

  • Status
    Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions