Repository navigation
docs(adr): Drop ADR-0022's hardcoded harness count - #778
Merged
Merged
Conversation
The count went stale twice. Point at HARNESS_PRESETS instead. Closes #777 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ADR-0022 said the launch table "names five harnesses (
claude,codex,grok,hermes,opencode)".HARNESS_PRESETSholds seven.piand thencursor-agent(#762) landed without reconciling the record, so it has gone stale twice in a row, silently.The count was never the decision. ADR-0022 decided focused list plus escape hatch over enumerate everything, and that is true at five, seven, or twelve.
What changed
One paragraph in
docs/adr/0022-acp-client-over-official-sdk-and-named-harnesses.md. The count and the enumeration are gone; the policy and a pointer toHARNESS_PRESETSreplace them.Deliberately not done:
HARNESS_PRESETSis untouched.docs/agents/docs.mdrules file paths and constant names out of an ADR because mechanism is fluid. A symbol name survives the refactor a path does not, so the ADR namesHARNESS_PRESETSand leavessrc-tauri/src/settings/form.rstogrep. Naming the path would re-arm the same rot this PR is removing.README.md:157-176anddocs/DEVELOPMENT.md:247both already list all seven. The ADR was the only stale count.#776 is not in this diff. It needs
scripts/comment-census.py, which #758 is still creating, so the fix went there as a review comment rather than as a second PR racing the same new file: #758 (comment)How to verify
node --test tests/*.test.jsata9924690, rebased onto39fd012c: 212 pass, 0 fail.pre-commit run --files docs/adr/0022-acp-client-over-official-sdk-and-named-harnesses.mdpasses, including codespell and the ADR-number hook.grep -rn 'names five' docs/ README.mdreturns nothing.Notes
The open question is now answered, and
f14ce9e2writes it down. #762 raised it and left it open: does a verified handshake earn a named row, or does a smoked turn? @omesser settled it. Verified means smoked, not handshaked, and Copilot CLI has not been verified.ADR-0022 already stated the rule correctly one paragraph up, "Harnesses earn verified standing once a turn has been smoked against them, fresh and resumed." The ambiguity was one loose word downstream, where the same record said a harness earns a named row "once verified". That reads as either answer. It now says which:
Nothing else changes. The README and
docs/DEVELOPMENT.mdalready match this rule, and the Cursor row #762 added was smoked toend_turnbefore it merged, so it keeps its standing.Closes #777
🤖 Generated with Claude Code
— Claude Code agent, on @omesser's behalf.