Repository navigation
feat(harness): Add Cursor CLI as a verified launch row - #762
Conversation
`cursor-agent acp` answers ACP but advertises its login as prose naming a binary that is not on PATH. A named row replaces it with `cursor-agent login`. The turn is unsmoked: the CLI here is not signed in. #636. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Review on #762: the AI source disclosure and the raw-token test each kept their own copy of the preset list, and both had already drifted off `pi`. The Cursor and Pi registration snippets were byte-identical; one arm now serves both. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
A review pass over this diff raised twelve points. Fixed in
Dismissed, with the reason:
Escalated rather than decided:
— Claude Code agent, on @omesser's behalf. |
|
The My original read of the brief was the path list ( Before (run After (run
So the regenerated fixtures serialize byte-identically on Windows, and the label should stay on this PR. — Claude Code agent, on @omesser's behalf. |
|
The earlier gap was a missing login on the probing machine, not a missing row.
— Cursor agent (Grok), on @omesser's behalf. |
Co-authored-by: Cursor <cursoragent@cursor.com>
… row #762 added cursor-agent as a named+verified Harness ACP Completer launch row. Keep the public alternatives matrix aligned with HARNESS_PRESETS on main.
Why
Cursor CLI speaks ACP on its own, so
cursor-agent acpalready reaches ai-buddy through the catch-all row. What the catch-all cannot do is answer the one question a user asks at the moment of the pick: how do I sign in. Unnamed, ai-buddy falls back to whatever the handshake calls its auth method, and Cursor's is a sentence:That is not a command, and the binary it names is not the one on
PATH. The installer putscursor-agentthere, while the CLI calls itselfagentin its own help. A user who runs that line verbatim gets a command not found.What changed
cursor-agentis a named launch row (cursor-agent acp) withcursor-agent loginas its documented sign-in line, and a smoked fresh-session turn. Everything else follows the registration points the repo already has for a named Harness, whichtests/connect-buttons.test.jsandevery_named_harness_documents_a_login_for_the_users_own_terminalpin.src-tauri/src/harness.rs— thelauncharm and thenamed_loginarm, plus both test loops over named rows.src-tauri/src/settings/form.rs—HARNESS_PRESETS, which is the one list Settings draws from.src-tauri/src/main.rs—select_harnessnow validates againstform::HARNESS_PRESETSinstead of a second hand-kept copy of the same seven names.src-tauri/src/settings.rs— abyo_registrationarm. Cursor has nomcp add;cursor-agent mcpoffers login, list, list-tools, enable and disable only, so the snippet is a~/.cursor/mcp.jsonfragment in Pi's shape.mcp enableis not optional: a new entry sits atnot loaded (needs approval)until it runs.src/chat.html,src/chat-ui.css,src/chat.js— the Connect button, its accent, and the display name. Simple Icons gives Cursor#000000, which is the Chat ground rather than an accent, so it is lifted the way--hermes-accentalready is.README.md,docs/DEVELOPMENT.md, and the two Settings fixtures.d1897e5crecords the smoked turn. The README Standing cell now says fresh sessions work. The session table Fresh-session column isyes. The unsmoked-row lede is gone, because no named row is unsmoked.No new field, trait or config layer. The registry took Cursor as it stands.
How to verify
cursor-agent2026.01.23-916f423, installed at~/.local/bin/cursor-agent, signed in on this machine.Before the named row (
AI_BUDDY_HARNESS="cursor-agent acp" scripts/probe-harness.sh), exit code 2:After the named row, still unsigned-in, exit code 2:
After sign-in (
AI_BUDDY_HARNESS=cursor-agent scripts/probe-harness.sh), exit code 0:The full transcript is on #636. No credential appears in either run.
What
initializeadvertised:{"protocolVersion":1, "agentCapabilities":{"loadSession":false,"promptCapabilities":{"image":true}}, "authMethods":[{"id":"cursor_login","name":"Cursor Login", "description":"Authenticate using existing Cursor login credentials. Run 'agent login' first if not logged in."}]}loadSessionfalse, so every attach opens a fresh session. Resumed session staysno. NomcpCapabilities.http, so it takes the stdio MCP server (ADR-0026). One auth method.The MCP fragment, against the installed CLI. Written to a throwaway
.cursor/mcp.jsonwith the same URL and a dummy token:connection failedis the last honest step available without the app bound to that port. Cursor read the entry, approved it, and dialled it.Install path, confirmed against
https://cursor.com/install: it unpacks under~/.local/share/cursor-agent/versions/and symlinkscursor-agentinto~/.local/bin.Suites, all on this branch:
cargo test --workspace— 477 + 487 + 23 + 10 + 9 passed, 0 failed.cargo clippy --workspace --all-targets -- -D warnings— clean.node --test tests/*.test.js— 203 passed, 0 failed.pre-commit run --files README.md— all hooks pass on the standing commit.Notes
nobecause the handshake advertises noloadSession. That is observed, not a gap in the probe. ADR-0022 asks for a smoked fresh turn and a smoked resume. Cursor cannot resume, so the resume column staysno.pilanded without the ADR being reconciled. This PR does not rewrite a decision record to fix someone else's drift. Worth a follow-up issue that reconciles ADR-0022's count withharness::launch, or drops the count from the ADR so it stops going stale.docs/design/connect.htmlis untouched. It is a Dated page under ADR-0011, frozen at 2026-09-08, and it does not carry thehermesorpibuttons either.docs/adr/0017is untouched: it is superseded by ADR-0022, and its table is history.Closes #636
— Cursor agent (Grok), on @omesser's behalf.