Repository navigation
Description
Why
Native Settings is three renderers. Win32 has more mod tests than GTK and an existing scripts/verify-settings-win.ps1 (#392: window opens, tab switch, label-wipe). That script does not cover the AI tab, freeze/unfreeze, disclosure, or clip/scroll (#601). Comments in the renderer still said frozen cannot change while the window lives — a P0-class lie if a user switches AI source. We need a diligent Windows pass: extend tests and e2e.
Sister issues: macOS AppKit, Linux GTK (same epic). This ticket owns Win32 Settings only.
Related: #601 (clip, no scroll, row bars bleed — fix or explicitly block e2e until reachable), #625 (runtime freeze — verify Win32 WM_ENABLE / ES_READONLY on draw), #548 / #593 (disclosure toggle).
Two workstreams
1. Complete missing tests (automated)
-
apply_enabled_states(or equivalent) ondraw()re-appliesfrozenfrom a freshform::describe()— freeze and unfreeze HTTP rows, picker, Clear key. Table-driven Harness driving vs Model API. Lock thatfrozencan change while the window lives. -
edit_style/EnableWindow/ES_READONLYstay in sync (do not enable a still-readonly edit). - AI tab section order: AI → AI source → Model / API → Last user turn.
- Env-owned rows stay frozen across source switch.
- Disclosure control: “What is this?” toggles the STATIC (if feat(settings): Progressive disclosure data structures for everyday Settings #593 landed).
- Layout: window has a vertical scroll or grows to fit; row backgrounds stay inside the tab inset (fix(windows): Settings clips bottom rows, no scroll, row bars bleed past tab chrome #601 — if still broken, this ticket does not absorb the layout fix; it fails e2e and stays blocked on fix(windows): Settings clips bottom rows, no scroll, row bars bleed past tab chrome #601).
Extend scripts/verify-settings-win.ps1:
- Keep existing open + tab-switch + label persistence.
- AI tab: section titles present in child windows.
- No Harness: Base URL / Model edits are enabled.
- With Harness (or after picking
Harness · …if commit works on Win32 — see fix(settings): Windows text fields — generic commit + honour frozen (X11 parity) #461 if picks still do not commit): HTTP rows disabled. - Runtime switch to Model API in the same HWND: rows enabled without relaunch.
- Screenshot + log under
.verify/settings-win-<stamp>/. - Assert clip: Launch / last Presence row
GetWindowRectis inside parent client (or skip with#601still open).
Win32 How-to-test in older PRs often said “cannot compile here.” Run this script on DESKTOP-UQIE144 (or CI windows job if HWND automation is stable).
2. Live e2e verification (must run on Windows)
Build tip under test (ai-buddy.exe). Throwaway HOME.
Walk every tab (Presence, Character, AI, Privacy, Development):
- Opens from tray; close/reopen without process restart.
- fix(windows): Settings clips bottom rows, no scroll, row bars bleed past tab chrome #601: all sections reachable (scroll or no clip); row chrome inside the tab. If fail, stop and keep fix(windows): Settings clips bottom rows, no scroll, row bars bleed past tab chrome #601 blocking.
- Tab switch does not wipe labels (the original feat(platform): Windows native settings window with full FormRow support (#391 #399) #392 bug).
- Edits commit. Honest note: if Win32 still cannot commit some popups (fix(settings): Windows text fields — generic commit + honour frozen (X11 parity) #461), tick that as a known fail and file/link — do not pretend Apply works.
- AI source Model API vs Harness — freeze/unfreeze without relaunch.
- Development remains on the strip.
- Env override freezes First wake.
File bugs as separate issues; link them here.
Done when
- Win32 unit tests in CI (
windowsjob). -
verify-settings-win.ps1covers runtime source switch + AI tab; documented in DEVELOPMENT.md. - A comment on this issue records a live pass (date, Windows version, machine, SHA) with the checklist ticked, or links filed bugs (fix(windows): Settings clips bottom rows, no scroll, row bars bleed past tab chrome #601 etc.).
— Cursor agent (Architect), on @omesser's behalf.
Metadata
Metadata
Assignees
Labels
Projects
- StatusShow more project fieldsDone
Activity
omesser commentedon Sep 11, 2026
Sisters: macOS #629, Linux #630. Clip/scroll #601; freeze class #625; existing script
scripts/verify-settings-win.ps1; Settings PR #593.— Cursor agent (Architect), on @omesser's behalf.
omesser commentedon Sep 16, 2026
Implemented via PR #768.
Unit tests (8 new Win32
mod testsinsettings_window::tests):ai_tab_section_order_matches_director_sections— AI tab sections matchdirector_sections()orderdisclosure_present_on_ai_and_source_sections— AI and AI source sections have disclosure textstatus_present_when_env_owned— Base URL / Model rows show status when env-ownedhttp_rows_have_frozen_field— Base URL / Model / API key rows have frozen fieldenv_owned_rows_stay_frozen_across_describe_calls— Env-owned freeze state persistsbase_url_picker_frozen_with_base_url_field— Base URL picker follows field's frozen statefrozen_can_change_while_window_lives— Frozen changes when Harness attaches/detachesE2e script (
scripts/verify-settings-win.ps1+scripts/ax-settings-win.ps1):Removed false comments claiming frozen cannot change while window lives (lines 1866, 2088).
Head SHA:
b7c9e2f9749e462aaccab56b587ea8f9f9ed2c02— Cursor agent (Coder), on @omesser's behalf.
test(windows): Settings e2e + fill Win32 renderer gaps
test(windows): Settings e2e + fill Win32 renderer gaps
test(windows): Settings e2e + fill Win32 renderer gaps
Fix Windows test assertions and FormDescription
fix(windows): Assert enablement via GWL_STYLE, not IsWindowEnabled
Use IsWindowEnabled FFI for button/checkbox enabled state checks
omesser commentedon Sep 16, 2026
Progress from merged #768 (
08d8721onmain)Shipped on main (does not close this issue — Spec leftover remains):
Win32 unit tests (CI
windowsjob):frozencan change while the window lives (Harness attach/detach)apply_enabled_statesHWND proof: Edit →EM_SETREADONLY/ES_READONLY; Button/Checkbox →WM_ENABLE/IsWindowEnabledfreeze and unfreezeMachine-local e2e:
scripts/verify-settings-win.ps1+scripts/ax-settings-win.ps1(managed UI Automation); documented indocs/DEVELOPMENT.md. DESKTOP-UQIE144 PASS for Presence/Director/Development tabs, AI tab structure + disclosure, Model API ↔ Harness source switch (see #768).Still open on this ticket:
.verify/settings-win-<stamp>/if still required by the script checklistLeaving open until that remainder is honest.
— Cursor agent (Coder), on @omesser's behalf.
omesser commentedon Sep 22, 2026
#706 Step 9 deletes the Win32 Settings renderer this e2e epic owned.
The leftover on this ticket after #768 was a live walk of the native HWND (every tab, clip/scroll blocked on #601). That window is gone. Settings is the webview; Windows smoke is
scripts/verify-settings-webview-phase2-win.ps1, notverify-settings-win.ps1.#871
— Grok Build agent, on @omesser's behalf.