Skip to content

test(windows): Verify Settings disclosure against #642 failure modes #667

Closed

Description

@omesser

Why

#642 / #660 fixed macOS Settings progressive disclosure: a stray clipped W (title forced onto NSBezelStyle::Disclosure) plus an inert control that still reserved a full-height blank band under every help line.

After #660 merged, Architect confirmed Linux does not have this bug (code path on main): GTK builds a real gtk::Expander titled "What is this?" and adds the disclosure copy as the expander child (disclosure_line in src-tauri/src/platform/x11/settings_window.rs). An unexpanded Expander does not allocate the child, so there is neither a clipped single-letter chrome nor a reserved closed band. No Linux fix ticket.

Windows still needs a live verify (and fix only if the failure modes show up). #631 mentions disclosure in the broader Settings e2e epic; this issue is the narrow #642 parity check so it does not get lost inside that umbrella.

What to verify (live on Windows)

On a debug build with Settings open, every tab that shows "What is this?":

  1. No stray / clipped letter chrome — the control shows the full "What is this?" label (Win32 already creates a BS_PUSHBUTTON with that title, so this half is expected clean; still confirm live).
  2. Closed disclosure reserves no blank band — with every disclosure closed, help lines should not sit above an empty gap the height of the hidden copy. Code smell on main: after creating the hidden STATIC copy, layout still does y += label_height + HINT_GAP while handle_disclosure_toggle only ShowWindows the label (no reflow). That is the reserved-band half fix(macos): Draw the whole "What is this?" label #660 deliberately left out of the macOS PR.
  3. Toggle works — click expands/collapses the copy; open → closed returns layout to the closed baseline (or document the scroll/reflow gap if rows below do not move).

Out of scope

Done when

Related

Activity

  1. added this to the V1 milestone on Sep 13, 2026
  2. omesser commented on Sep 15, 2026

    @omesser
    OwnerAuthor

    Live Windows verify (Done-when)

    Built and ran debug main on DESKTOP-UQIE144.

    • Tip SHA: c1916614ae59d26cdf5dbacfdf7f40ab4e2b324a
    • Binary: target/debug/ai-buddy.exe (VsDevCmd + cargo build -p ai-buddy)
    • Drive: PostMessage / BM_CLICK to HWNDs (no global cursor); Settings + presence parked on secondary (-1200,-209)

    PASS/FAIL matrix

    Tab 1. Full "What is this?" 2. No reserved band 3a. Toggle 3b. Reflow on toggle
    Presence (2 disclosures) PASS FAIL PASS FAIL (rows below delta=0)
    AI (8 disclosures) PASS FAIL PASS FAIL (rows below delta=0)

    Closed-state measurements (button → next visible; hidden STATIC height):

    • Presence: gap=47 / hiddenStaticH=39; gap=34 / hiddenStaticH=26
    • AI: gaps 47,60,47,60,47,26,47,34 with matching hiddenStaticH 39,52,39,52,65,18,39,26

    Code match on main: after creating the non-visible disclosure STATIC, layout still does y += label_height + HINT_GAP; handle_disclosure_toggle only ShowWindows — no reflow.

    Screenshots

    Closed Open (first disclosure)
    Presence closed open
    AI closed open

    Local copies also under C:\Users\oded\src\ai-buddy\.verify\667-disclosure-20260915-034852\ (PrintWindow recapture).

    Follow-up

    Reserved-band / no-reflow confirmed → opened #713 fix(windows): Collapse closed Settings disclosure height / reflow on toggle with a clear Done-when.

    Closing #667: verify complete; Win32 does not share the #642 stray-W chrome, but does share the reserved-band half — tracked in #713.

    — Cursor agent (Coder), on @omesser's behalf.

  3. omesser commented on Sep 15, 2026

    @omesser
    OwnerAuthor

    Done-when met: live Presence+AI notes + screenshots on tip c191661; reserved-band confirmed → follow-up #713. Win32 does not share the #642 stray-W chrome.

    — Cursor agent (Coder), on @omesser's behalf.

  4. moved this from 👷 Todo to 🏁 Done in Fidgeton Sep 15, 2026
  5. added
    windowsRun the Windows compile job on this pull request
    on Sep 15, 2026
  6. omesser commented on Sep 22, 2026

    @omesser
    OwnerAuthor

    #706 Step 9 deletes the Win32 Settings renderer whose disclosure layout this ticket was verifying.

    Already closed. The reserved-band / stray-chrome failure modes were native widget layout. The webview draws "What is this?" as <details>, which does not reserve a closed band.

    #871

    — Grok Build agent, on @omesser's behalf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    windowsRun the Windows compile job on this pull request

    Projects

    • Status
      Done

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions