Repository navigation
Description
Why
#642 / #660 fixed macOS Settings progressive disclosure: a stray clipped W (title forced onto NSBezelStyle::Disclosure) plus an inert control that still reserved a full-height blank band under every help line.
After #660 merged, Architect confirmed Linux does not have this bug (code path on main): GTK builds a real gtk::Expander titled "What is this?" and adds the disclosure copy as the expander child (disclosure_line in src-tauri/src/platform/x11/settings_window.rs). An unexpanded Expander does not allocate the child, so there is neither a clipped single-letter chrome nor a reserved closed band. No Linux fix ticket.
Windows still needs a live verify (and fix only if the failure modes show up). #631 mentions disclosure in the broader Settings e2e epic; this issue is the narrow #642 parity check so it does not get lost inside that umbrella.
What to verify (live on Windows)
On a debug build with Settings open, every tab that shows "What is this?":
- No stray / clipped letter chrome — the control shows the full
"What is this?"label (Win32 already creates aBS_PUSHBUTTONwith that title, so this half is expected clean; still confirm live). - Closed disclosure reserves no blank band — with every disclosure closed, help lines should not sit above an empty gap the height of the hidden copy. Code smell on
main: after creating the hiddenSTATICcopy, layout still doesy += label_height + HINT_GAPwhilehandle_disclosure_toggleonlyShowWindows the label (no reflow). That is the reserved-band half fix(macos): Draw the whole "What is this?" label #660 deliberately left out of the macOS PR. - Toggle works — click expands/collapses the copy; open → closed returns layout to the closed baseline (or document the scroll/reflow gap if rows below do not move).
Out of scope
- macOS (shipped in fix(macos): Draw the whole "What is this?" label #660).
- Linux (verified absent via GTK
Expandermechanism; not a live-smoke blocker). - Broader Win32 Settings e2e / freeze / clip-scroll (test(windows): Settings e2e + fill Win32 renderer gaps #631, fix(windows): Settings clips bottom rows, no scroll, row bars bleed past tab chrome #601) except as related links.
Done when
- Live Windows notes (or screenshots) for the three checks above, on at least Presence + AI tabs.
- If reserved-band (or any other fix(macos): Settings tabs show a stray W on every help line #642-class failure) is confirmed: a follow-up
fix(windows):issue or PR with a clear Done-when (collapse closed height / reflow on toggle), linked here. - If all three checks pass live: close this with the evidence and a one-line note that Win32 does not share fix(macos): Settings tabs show a stray W on every help line #642.
Related
- fix(macos): Settings tabs show a stray W on every help line #642 (macOS stray W) — closed by fix(macos): Draw the whole "What is this?" label #660
- fix(macos): Draw the whole "What is this?" label #660 (macOS fix; called out Win32 reserved-band as follow-up)
- test(windows): Settings e2e + fill Win32 renderer gaps #631 (Windows Settings e2e umbrella — may absorb the fix work once verified)
- feat(settings): Progressive disclosure for everyday Settings copy #548 / feat(settings): Progressive disclosure data structures for everyday Settings #593 (progressive disclosure)
Metadata
Metadata
Assignees
Labels
Projects
- StatusShow more project fieldsDone
Activity
omesser commentedon Sep 15, 2026
Live Windows verify (Done-when)
Built and ran debug main on DESKTOP-UQIE144.
c1916614ae59d26cdf5dbacfdf7f40ab4e2b324atarget/debug/ai-buddy.exe(VsDevCmd +cargo build -p ai-buddy)BM_CLICKto HWNDs (no global cursor); Settings + presence parked on secondary (-1200,-209)PASS/FAIL matrix
"What is this?"Closed-state measurements (button → next visible; hidden STATIC height):
gap=47/hiddenStaticH=39;gap=34/hiddenStaticH=2647,60,47,60,47,26,47,34with matchinghiddenStaticH39,52,39,52,65,18,39,26Code match on
main: after creating the non-visible disclosure STATIC, layout still doesy += label_height + HINT_GAP;handle_disclosure_toggleonlyShowWindows — no reflow.Screenshots
Local copies also under
C:\Users\oded\src\ai-buddy\.verify\667-disclosure-20260915-034852\(PrintWindow recapture).Follow-up
Reserved-band / no-reflow confirmed → opened #713
fix(windows): Collapse closed Settings disclosure height / reflow on togglewith a clear Done-when.Closing #667: verify complete; Win32 does not share the #642 stray-
Wchrome, but does share the reserved-band half — tracked in #713.— Cursor agent (Coder), on @omesser's behalf.
omesser commentedon Sep 15, 2026
Done-when met: live Presence+AI notes + screenshots on tip c191661; reserved-band confirmed → follow-up #713. Win32 does not share the #642 stray-W chrome.
— Cursor agent (Coder), on @omesser's behalf.
omesser commentedon Sep 22, 2026
#706 Step 9 deletes the Win32 Settings renderer whose disclosure layout this ticket was verifying.
Already closed. The reserved-band / stray-chrome failure modes were native widget layout. The webview draws
"What is this?"as<details>, which does not reserve a closed band.#871
— Grok Build agent, on @omesser's behalf.