Repository navigation
Conversation
d32fadb to
5056448
Compare
omesser
left a comment
There was a problem hiding this comment.
Architect review — NOT CLEARED (rebase first)
Tip d32fadbf. Three-line honesty fix is right: cursor-agent drops handed MCP; transport none; footnote separates Pi (no capability) vs cursor-agent (handed + dropped). Measurement table in the body is the evidence.
Hard
- PR is CONFLICTING with main — rebase onto current main (and onto #1017 if that merges first so Copilot rows + this discard note coexist).
- Re-gate after clean tip; do not merge dirty.
Soft
- None on the intended wording once rebased.
— Cursor agent (Architect), on @omesser's behalf.
The table read as though ai-buddy's tools reach a cursor-agent session. They do not. It is handed the stdio entry on `session/new` and never spawns it. Measured by instrumenting the shim's own entry point, so the log does not depend on the Harness forwarding stderr. `hermes` takes a byte-identical entry and connects within a second; `cursor-agent` writes no line at all. Their ACP handler never reads `mcpServers`, and their docs say servers come from an approved `.cursor/mcp.json`. The transport column now reads `none`, the way `pi`'s already does, because `stdio` named a transport that carries nothing. This is today's behavior, not a verdict. A fix through Cursor's own config is measured and tracked, so the row says so rather than reading as permanent. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
5056448 to
de3a8b8
Compare
|
Blocked. just implement #1020 instead |
|
Closing per your call. Documenting behavior that is about to be false is worse than leaving the table as it is for another day. #1020 carries the measured design and the six routes that were killed getting to it. Implementing that now. The branch — Claude Code agent, on @omesser's behalf. |
Why
The Harness tables read as though ai-buddy's tools reach a
cursor-agentsession. They do not. Anyone choosing a Harness from that table would pick
cursor-agentand quietly lose every ai-buddy tool.What is measured
choose_mcphandscursor-agentthe stdio shim, because it advertises nomcpCapabilities. The entry on the wire is byte-identical to the onehermesgets, apart from the port.
The shim's own entry point was instrumented to append a line keyed on pid, so
the evidence does not depend on the Harness forwarding its child's stderr.
hermes, ourmcpServersinitialize,tools/listcursor-agent, ourmcpServerscursor-agent, aftercursor-agent mcp enable ai-buddyinitialize,tools/listhermesis the control that matters. Same binary, same bytes, connects in undera second, so this is not a broken shim.
cursor-agent2026.01.23-916f423 vendors an ACP SDK that parsesmcpServers(two occurrences in
8657.index.js) and an agent bundle that never reads it(zero in
7414.index.js). Their ACP docssay servers come from a
.cursor/mcp.jsonyou have approved.What changed
Three lines of
README.md.The tools row says the MCP we hand it is discarded today, names its own
approved config as the one door that works, and points at #1020.
The transport column reads
nonerather thanstdio, which is whatpi's rowalready says for the same outcome.
stdionamed a transport that carriesnothing.
The footnote separates the two reasons, since
piadvertises no MCP capabilityat all while
cursor-agentis handed an entry and drops it.Why this is not the whole story
An earlier draft of this pull request argued the gap was not worth closing, on
three costs. All three have since been measured away, which is why the row now
reads as today's behavior rather than a verdict:
AttachCwd::resolvereturnsdata_dir()for a blank Working directory.the entry's
env. Without one the approval hash is stable andenablerunsonce per directory.
file carrying a token. The measured design has no token at all.
#1020 carries that work. This pull request is only the correction, so the table
stops overclaiming while the fix is decided.
How to verify
node --test tests/passes 342. Documentation only, no product code.🤖 Generated with Claude Code
— Claude Code agent, on @omesser's behalf.