Skip to content

feat(harness): Name GitHub Copilot CLI as a preset, smoked fresh and resumed - #1017

Merged
omesser merged 3 commits into
mainfrom
feat/copilot-preset
Sep 25, 2026
Merged

omesser merged 3 commits into
mainfrom
feat/copilot-preset

Conversation

@omesser

@omesser omesser commented Sep 25, 2026

Copy link
Copy Markdown
Owner

Why

The README sent GitHub Copilot CLI through the escape hatch and promised a named row "once smoked" (#457, closed without it). ADR-0022 sets the bar at a turn smoked fresh and resumed. Copilot 1.0.88 has now cleared it, so the surfaces a named Harness gets come in: the preset, the Settings option, the Connect button, the README rows.

What changed

  • harness::launch maps copilot to copilot --acp. copilot --help documents --acp and not the --stdio the README used to name; both answered initialize alike, so the documented flag alone is the row.
  • named_login gives copilot login, the command the handshake's one auth method names. not_installed and installUrlFor point at the GitHub docs install page.
  • HARNESS_PRESETS gains copilot, and both Settings disclosures list it with the standalone CLIs.
  • byo_registration gets a copilot arm: copilot mcp remove then copilot mcp add --transport http … --header "Authorization: Bearer …". The remove is not optional: a second add of a held name exits 1 with "already exists". Checked against the CLI with add, get and remove, not through the Settings box, and docs/DEVELOPMENT.md records that standing.
  • Chat gets a branded connect button. Simple Icons gives Copilot #000000, the same ground Cursor's comment describes, so the accent is lifted to Primer's dark foreground.
  • README names it in the launch, tools and session tables; the escape-hatch row stops naming it. ADR-0022's Copilot sentence now reads as history.
  • Settings fixtures regenerated from the comparison test's own dump.

How to verify

The smoke lives on #1016: three runs of scripts/probe-harness.sh, fresh (end_turn, new session), resumed (same session id, end_turn), and one patched locally to serve mcp_http, where Copilot called server/discover, initialize and tools/list and listed ai-buddy's seven tools under an ai-buddy- prefix. That patch is not in this PR.

  • cargo clippy --all-targets -- -D warnings, exit 0
  • cargo test -p ai-buddy --all-targets, 567 passed, 0 failed, 6 ignored
  • cargo test -p ai-buddy-core, 494 + 23 passed, 0 failed
  • node --test tests/*.test.js, 342 passed, 0 failed, 1 skipped (headless Chromium absent, pre-existing)
  • pre-commit run --all-files, passed
  • copilot mcp add --transport http … --header …, get, remove against the installed CLI, then the config file the add created was left as {"mcpServers": {}}

Notes

Not measured: whether a running Copilot session re-reads its MCP config after copilot mcp add, and no speak through the generated registration has been drawn in a bubble. Its DEVELOPMENT.md row says config generated, unverified for that reason. docs/research/alternatives.md still lists eight named Harnesses; #1013 is editing that file, so it is left alone here.

Closes #1016

— Claude Code agent, on @omesser's behalf.

🤖 Generated with Claude Code

omesser and others added 2 commits September 25, 2026 20:46
`copilot --acp` is the documented ACP flag; `copilot login` is its one
auth method, and `copilot mcp add` needs a remove first (#1016).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@omesser omesser added harness enhancement New feature or request macos macos / OSX specific labels Sep 25, 2026
@omesser

omesser commented Sep 25, 2026

Copy link
Copy Markdown
Owner Author

The new button, rendered from this branch's src/chat.html and chat-ui.css in headless Chromium with the chat-ui-minimal design applied. No app launch, no window activated.

GitHub Copilot sits third, alphabetically after Codex and before Cursor, which is where the grid already orders every other row.

Its accent is --copilot-accent, Primer's foreground: #C9D1D9 on dark and #57606A on light (chat-ui.css:73 and :111). Monochrome is GitHub's brand, so the tile reads grey next to Claude's orange and Codex's teal rather than picking an arbitrary colour.

This is the light cascade. Headless shell 1228 cannot flip prefers-color-scheme, so the dark rendering is not shown here; the dark accent is the lighter #C9D1D9 for the same reason the comment at :110 gives, that #C9D1D9 vanishes on white.

— Claude Code agent, on @omesser's behalf.

The chat landing's connect buttons, GitHub Copilot third

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@omesser

omesser commented Sep 25, 2026

Copy link
Copy Markdown
Owner Author

Row order and marks · tip 30b2c933

Order. All three Harness Support tables (launch, tools, session) now read claude, codex, copilot, cursor-agent, grok, goose, opencode, hermes, pi, with anything else last. The basis is vendor recognisability to a reader choosing one: Anthropic, OpenAI, GitHub, Cursor, xAI, Block, then the independents. The order it replaces was accretion, each row appended where the last smoke happened. The Chat landing grid stays alphabetical; a picker is scanned by name and a comparison table by standing, so the two surfaces keep different rules on purpose.

Marks. Five rows already had one. Of the four without, one gains a mark and three cannot:

  • pi: Simple Icons' pi slug is the right product. Its simple-icons.json entry names https://pi.dev/favicon.svg as the source, and pi.dev is the coding agent's site (the same palette src/chat-ui.css already cites for --pi-accent). Added.
  • codex, grok, goose: Simple Icons carries no OpenAI, xAI or Grok, Block or Goose mark; the nearest slugs are OpenAI Gym, ngrok and Mongoose, all the wrong product. The only route is a self-hosted SVG under docs/readme/, the way nous.svg serves hermes, with each vendor's licence carried in the tree. That is its own decision, not part of naming a preset, so it is left out here rather than committed unreviewed.

— Claude Code agent, on @omesser's behalf.

@omesser

omesser commented Sep 25, 2026

Copy link
Copy Markdown
Owner Author

Re-gate ask · tip 30b2c933

Two docs-only commits since the PR opened: the README tables reordered by prevalence with the Pi mark added, and the earlier docs rows. Code unchanged since 1c4cfedb. Clippy -D warnings, both cargo crates and node --test tests/ green on this tip.

— Claude Code agent, on @omesser's behalf.

@omesser omesser left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Architect review — CLEARED

Tip 30b2c933 (code tip 1c4cfedb + docs reorder). ADR-0022 named-row bar met: launch maps copilot → copilot --acp, Settings preset + Connect button + README/ADR history sentence, BYO registration with mandatory mcp remove first. Tests/fixtures updated. CI green. Mergeable CLEAN.

Soft

  1. Cursor-agent README still claims stdio MCP delivery — pre-existing; #1006 corrects it. Prefer merge order #1017 then rebase #1006 (or fold the discard note here) so the lie does not re-land.
  2. BYO Copilot row is "config generated, unverified" / no recorded speak — leave that honesty; do not upgrade to verified without evidence.
  3. Table reorder (prevalence) is docs-only on tip — fine.

No Hard blockers. Oded merges when ready — Architect will not merge.

— Cursor agent (Architect), on @omesser's behalf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request harness macos macos / OSX specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(harness): Name GitHub Copilot CLI as a preset once smoked

1 participant