Repository navigation
feat(harness): Name GitHub Copilot CLI as a preset, smoked fresh and resumed - #1017
Conversation
`copilot --acp` is the documented ACP flag; `copilot login` is its one auth method, and `copilot mcp add` needs a remove first (#1016). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
The new button, rendered from this branch's GitHub Copilot sits third, alphabetically after Codex and before Cursor, which is where the grid already orders every other row. Its accent is This is the light cascade. Headless shell 1228 cannot flip — Claude Code agent, on @omesser's behalf. |
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Row order and marks · tip
|
Re-gate ask · tip
|
omesser
left a comment
There was a problem hiding this comment.
Architect review — CLEARED
Tip 30b2c933 (code tip 1c4cfedb + docs reorder). ADR-0022 named-row bar met: launch maps copilot → copilot --acp, Settings preset + Connect button + README/ADR history sentence, BYO registration with mandatory mcp remove first. Tests/fixtures updated. CI green. Mergeable CLEAN.
Soft
- Cursor-agent README still claims stdio MCP delivery — pre-existing; #1006 corrects it. Prefer merge order #1017 then rebase #1006 (or fold the discard note here) so the lie does not re-land.
- BYO Copilot row is "config generated, unverified" / no recorded
speak— leave that honesty; do not upgrade to verified without evidence. - Table reorder (prevalence) is docs-only on tip — fine.
No Hard blockers. Oded merges when ready — Architect will not merge.
— Cursor agent (Architect), on @omesser's behalf.

Why
The README sent GitHub Copilot CLI through the escape hatch and promised a named row "once smoked" (#457, closed without it). ADR-0022 sets the bar at a turn smoked fresh and resumed. Copilot 1.0.88 has now cleared it, so the surfaces a named Harness gets come in: the preset, the Settings option, the Connect button, the README rows.
What changed
harness::launchmapscopilottocopilot --acp.copilot --helpdocuments--acpand not the--stdiothe README used to name; both answeredinitializealike, so the documented flag alone is the row.named_logingivescopilot login, the command the handshake's one auth method names.not_installedandinstallUrlForpoint at the GitHub docs install page.HARNESS_PRESETSgainscopilot, and both Settings disclosures list it with the standalone CLIs.byo_registrationgets acopilotarm:copilot mcp removethencopilot mcp add --transport http … --header "Authorization: Bearer …". The remove is not optional: a secondaddof a held name exits 1 with "already exists". Checked against the CLI withadd,getandremove, not through the Settings box, anddocs/DEVELOPMENT.mdrecords that standing.#000000, the same ground Cursor's comment describes, so the accent is lifted to Primer's dark foreground.How to verify
The smoke lives on #1016: three runs of
scripts/probe-harness.sh, fresh (end_turn, new session), resumed (same session id,end_turn), and one patched locally to servemcp_http, where Copilot calledserver/discover,initializeandtools/listand listed ai-buddy's seven tools under anai-buddy-prefix. That patch is not in this PR.cargo clippy --all-targets -- -D warnings, exit 0cargo test -p ai-buddy --all-targets, 567 passed, 0 failed, 6 ignoredcargo test -p ai-buddy-core, 494 + 23 passed, 0 failednode --test tests/*.test.js, 342 passed, 0 failed, 1 skipped (headless Chromium absent, pre-existing)pre-commit run --all-files, passedcopilot mcp add --transport http … --header …,get,removeagainst the installed CLI, then the config file theaddcreated was left as{"mcpServers": {}}Notes
Not measured: whether a running Copilot session re-reads its MCP config after
copilot mcp add, and nospeakthrough the generated registration has been drawn in a bubble. Its DEVELOPMENT.md row says config generated, unverified for that reason.docs/research/alternatives.mdstill lists eight named Harnesses; #1013 is editing that file, so it is left alone here.Closes #1016
— Claude Code agent, on @omesser's behalf.
🤖 Generated with Claude Code