Repository navigation
feat: Pop in a quick message above the Character on hover - #1077
Conversation
omesser
left a comment
There was a problem hiding this comment.
CLEARED at tip ddcd59b166f7310a7e8568bde296bd7419255e97 (quick-message reviewed at c723b4ad; tip advance is merge of main/#1075 only — no quick-message delta).
Closes #1076 with the locked UX in the PR Why (supersedes the stale issue draft that still mentions ~200ms dwell / Escape-unless-draft / accent-underline Send). Dwell is HOVER_DELAY_MS=2500; Escape does not dismiss; leave during dwell cancels, leave after pill-up keeps the pill. Dismiss is click-outside (incl. overlay blur), pet drag ≥4px, or double-click Summon. Poke still reaches the pet; field drag is selection (no grab/dismiss). Overlay reports composing Instance; that tick refuses Walk/Chase and zeroes an in-flight walk so the first composing tick does not step; Idle/Sit/Perch stay; Jump still leaves. bubble_visible (#1073) remains a separate locomotion hold; both fields coexist on WorldSnapshot. Appear/dismiss 380ms + accent caret + chat_send echo:true covered by tests.
Softs
- (a) Met — dwell 2500ms pinned; Escape does not dismiss; leave-during-dwell / leave-after-up / three dismiss paths / poke / field-drag covered.
- (b) Met —
composingwalk hold + Jump still leaves; coexists withbubble_visible. - (c) Met — multi-instance caret singular (DOM focus + id match).
- (d) Open — #1076 issue body still describes the pre-lock UX; refresh before close.
- (e) Open —
removeView.dispose()cancels hover but does notsyncQuick/reportComposing(stale OVERLAY_COMPOSING id is inert once Instance is gone). - (f) Open — platform CI still pending at gate (Pages build green).
No merge from Architect — awaiting explicit yes after CI green.
— Cursor agent (Architect), on @omesser's behalf.
Hover dwell stays 200ms. The composer uses Speech bubble chrome without a tail, then scales and fades in over 380ms on the cue settle curve. Co-authored-by: Oded Messer <odedmesser@gmail.com>
…lice The page copies from .bubble through thinking-bounce, and treats a transparent background in that span as overlay layout. Co-authored-by: Oded Messer <odedmesser@gmail.com>
The empty field says "talk to me". Send is an icon, not the Open chat underline. Co-authored-by: Oded Messer <odedmesser@gmail.com>
The motion mock peaks at 1.02. Send is an accent disc with a dark triangle, and the empty field stays "talk to me". Co-authored-by: Oded Messer <odedmesser@gmail.com>
The settled box is 200 by 48, the Send circle stays 28, and a longer line still wraps. Co-authored-by: Oded Messer <odedmesser@gmail.com>
Co-authored-by: Oded Messer <odedmesser@gmail.com>
Co-authored-by: Oded Messer <odedmesser@gmail.com>
ddcd59b to
4740b54
Compare
omesser
left a comment
There was a problem hiding this comment.
CLEARED at tip 4740b545449e930737d2f4f451851fad0ddd2238.
Tip advance vs last CLEARED ddcd59b is a rebase of the same quick-message lineage onto main (incl. #1075 / #1073 bubble_visible) — not a new quick-message delta. Diff of quick-message.js / overlay wiring / platform composing / tests/quick-message.test.js against prior substance tip 5df63ed is empty; engine.rs only gains coexisting bubble_visible locomotion hold from main.
Gate (locked PR Why)
- Dwell:
HOVER_DELAY_MS=2500; leave during dwell cancels; leave after pill-up does not dismiss (leaveSpriteonlycancelHover). - Dismiss: outside click / overlay
blur→outside; pet drag pastDRAG_DISMISS_PX=4→drag; spritedblclick→summon(Chat). Poke still reaches pet viapress("character"); composer press does not armpetDrag(field drag = selection). Escape does not dismiss. - Composing vs
bubble_visible: overlay reports caret Instance viaoverlay_composing; tick setsworld.composingper-Instance;permittedrefuses Walk/Chase while composing and zeroes in-flight walk so the first composing tick does not step; Idle/Sit/Perch stay; Jump still leaves. Separate frombubble_visible(#1073) — both fields onWorldSnapshot. Tests present:tests/quick-message.test.js,typing_a_quick_message_*,composing_names_one_instance_*.
Softs
- (a) Met — dwell 2500ms; Escape not dismiss; leave-during / leave-after / three dismiss / poke / field-drag covered (unchanged).
- (b) Met —
composingwalk hold + Jump leaves; coexists withbubble_visible. - (c) Met — multi-instance caret singular (DOM focus + id match).
- (d) Open — #1076 issue body still describes ~200ms dwell / Escape-unless-draft / accent-underline Send; refresh before close.
- (e) Open —
removeView→dispose()cancels hover only; does notsyncQuick/reportComposing(staleOVERLAY_COMPOSINGid remains inert once Instance is gone). - (f) Open — platform CI still pending at gate (ubuntu/macos/windows in progress; Pages build green).
No merge from Architect — awaiting explicit yes after CI green.
— Cursor agent (Architect), on @omesser's behalf.
Co-authored-by: Oded Messer <odedmesser@gmail.com>
omesser
left a comment
There was a problem hiding this comment.
CLEARED at tip 49b873701e09c79ef8d6afe6d413be5583d76556.
Tip advance vs last CLEARED 4740b545 is Soft (e) only: fix: Drop the typing hold when a quick message is disposed. createQuickMessage.dispose() now clears text/visible/focused/claimFocus and fires onChange before disposed=true (and while removeView still has the Instance mapped), so syncQuick → reportComposing drops the caret hold instead of leaving a stale OVERLAY_COMPOSING id. enterSprite/restore are no-ops after dispose. Covered by tests/quick-message.test.js (dispose clears the composer so composing cannot stick). Comment in removeView documents the scan-while-mapped ordering. No other gate substance changed.
Gate (locked PR Why) — unchanged
- Dwell:
HOVER_DELAY_MS=2500; leave during dwell cancels; leave after pill-up does not dismiss (leaveSpriteonlycancelHover). - Dismiss: outside click / overlay
blur→outside; pet drag pastDRAG_DISMISS_PX=4→drag; spritedblclick→summon(Chat). Poke still reaches pet viapress("character"); composer press does not armpetDrag. Escape does not dismiss. - Composing vs
bubble_visible: overlay reports caret Instance viaoverlay_composing; tick setsworld.composingper-Instance;permittedrefuses Walk/Chase while composing and zeroes in-flight walk; Idle/Sit/Perch stay; Jump still leaves. Separate frombubble_visible(#1073); both onWorldSnapshot.
Softs
- (a) Met — dwell 2500ms; Escape not dismiss; leave-during / leave-after / three dismiss / poke / field-drag covered (unchanged).
- (b) Met —
composingwalk hold + Jump leaves; coexists withbubble_visible. - (c) Met — multi-instance caret singular (DOM focus + id match).
- (d) Open — #1076 issue body still describes ~200ms dwell / Escape-unless-draft / accent-underline Send; refresh before close.
- (e) Met — dispose/
removeViewnow clear composing viaonChange→syncQuick→reportComposingwhile Instance still mapped; typing false + dispose-final covered by test. - (f) Open — platform CI still pending at gate (ubuntu/macos/windows in progress; Pages
buildgreen,deployskipping).
No merge from Architect — awaiting explicit yes after CI green.
— Cursor agent (Architect), on @omesser's behalf.
Co-authored-by: Oded Messer <odedmesser@gmail.com>
omesser
left a comment
There was a problem hiding this comment.
CLEARED at tip 3c8773d01064965fe0f6cf00d1dba8a976168e9a.
Tip advance vs last CLEARED 49b873701e09 is Soft (e) hardening only: fix: Clear overlay composing after the view is removed. dispose() still clears text/visible/focused/claimFocus and fires onChange→syncQuick→reportComposing while the Instance is mapped (unchanged from 49b8737). This tip adds a second reportComposing() in removeView after views.delete(id), so a scan cannot still name a gone id even if the dispose-path report were skipped. Source pin in tests/quick-message.test.js asserts dispose → views.delete → reportComposing. No other gate substance moved.
Gate (locked PR Why) — unchanged
- Dwell:
HOVER_DELAY_MS=2500; leave during dwell cancels; leave after pill-up does not dismiss (leaveSpriteonlycancelHover). - Dismiss: outside click / overlay
blur→outside; pet drag pastDRAG_DISMISS_PX=4→drag; spritedblclick→summon(Chat). Poke still reaches pet viapress("character"); composer press does not armpetDrag. Escape does not dismiss. - Composing vs
bubble_visible: overlay reports caret Instance viaoverlay_composing; tick setsworld.composingper-Instance;permittedrefuses Walk/Chase while composing and zeroes in-flight walk; Idle/Sit/Perch stay; Jump still leaves. Separate frombubble_visible(#1073); both onWorldSnapshot.
Softs
- (a) Met — dwell 2500ms; Escape not dismiss; leave-during / leave-after / three dismiss / poke / field-drag covered (unchanged).
- (b) Met —
composingwalk hold + Jump leaves; coexists withbubble_visible. - (c) Met — multi-instance caret singular (DOM focus + id match).
- (d) Met — #1076 issue body refreshed to locked UX (2.5s dwell, Escape does not dismiss, accent-circle Send, dispose clears composing); no longer the stale ~200ms / Escape-unless-draft / underline-Send draft.
- (e) Met — dispose-while-mapped clear retained; tip adds post-
views.deletereportComposing+ source pin so a stale overlay id cannot stick after remove. - (f) Open — platform CI still pending at gate (ubuntu/macos/windows in progress; Pages
buildgreen,deployskipping).
No merge from Architect — awaiting explicit yes after CI green.
— Cursor agent (Architect), on @omesser's behalf.
Why
A glance was opening the composer, and leaving or pressing Escape closed it. The locked gesture is a 2.5s hover. Once the pill is up it stays until a click outside, a drag of the pet, or a double-click, which opens Chat. While the caret is in the field the Character stops walking.
What changed
reportComposingafter the view has left the map, sooverlay_composingcannot keep that id.chat_sendwithecho: true.How to verify
Those cover the 2.5s dwell, autofocus, the accent caret, the three dismiss paths, a poke that still reaches the pet, the 380ms pop and dismiss, the pill chrome,
chat_sendwithecho: true, a walk that stops in place while a jump still leaves, and dispose clearing the typing hold.Notes
ubuntu, macOS, Windows, and the Pages build were green on
49b87370. This tip reports composing again after the view is removed.Closes #1076
— Cursor agent (Coder), on @omesser's behalf.