Skip to content

feat: Pop in a quick message above the Character on hover - #1077

Merged
omesser merged 9 commits into
mainfrom
cursor/quick-message-composer-213c
Sep 27, 2026
Merged

omesser merged 9 commits into
mainfrom
cursor/quick-message-composer-213c

Conversation

@omesser

@omesser omesser commented Sep 27, 2026 •

Copy link
Copy Markdown
Owner

Why

A glance was opening the composer, and leaving or pressing Escape closed it. The locked gesture is a 2.5s hover. Once the pill is up it stays until a click outside, a drag of the pet, or a double-click, which opens Chat. While the caret is in the field the Character stops walking.

What changed

  • The composer appears after 2500ms over the sprite, then focuses the field. The caret is the accent, the same hue as Send. Enter sends. Escape does not dismiss. A leave during the dwell cancels it. A leave after the pill is up does not dismiss it.
  • Dismiss is a click outside (the overlay window blurring counts), a pet drag of at least 4px, or a double-click on the sprite (Summon, which opens Chat). A poke still reaches the pet. A drag that starts in the field is a selection: it does not grab the pet and does not dismiss.
  • The overlay reports which Instance has the caret. That tick refuses a new walk or chase and zeroes a walk already under way, so the first composing tick does not step. Idle, sit, and perch stay. A jump still leaves.
  • Removing the Instance cancels the hover, drops the caret, and calls reportComposing after the view has left the map, so overlay_composing cannot keep that id.
  • Appear and dismiss both ease out over 380ms. The empty pill is unchanged: placeholder "talk to me", accent circle with a dark triangle, speech chrome, no tail. Send uses chat_send with echo: true.

Empty quick-message pill, talk to me, accent send circle

How to verify

node --test tests/quick-message.test.js tests/expression-page.test.js
cargo test -p ai-buddy-core typing_a_quick_message
cargo test -p ai-buddy composing_names_one_instance

Those cover the 2.5s dwell, autofocus, the accent caret, the three dismiss paths, a poke that still reaches the pet, the 380ms pop and dismiss, the pill chrome, chat_send with echo: true, a walk that stops in place while a jump still leaves, and dispose clearing the typing hold.

Notes

ubuntu, macOS, Windows, and the Pages build were green on 49b87370. This tip reports composing again after the view is removed.

Closes #1076

— Cursor agent (Coder), on @omesser's behalf.

Open in Web Open in Cursor 

@omesser
omesser marked this pull request as ready for review September 27, 2026 19:42

@omesser omesser left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLEARED at tip ddcd59b166f7310a7e8568bde296bd7419255e97 (quick-message reviewed at c723b4ad; tip advance is merge of main/#1075 only — no quick-message delta).

Closes #1076 with the locked UX in the PR Why (supersedes the stale issue draft that still mentions ~200ms dwell / Escape-unless-draft / accent-underline Send). Dwell is HOVER_DELAY_MS=2500; Escape does not dismiss; leave during dwell cancels, leave after pill-up keeps the pill. Dismiss is click-outside (incl. overlay blur), pet drag ≥4px, or double-click Summon. Poke still reaches the pet; field drag is selection (no grab/dismiss). Overlay reports composing Instance; that tick refuses Walk/Chase and zeroes an in-flight walk so the first composing tick does not step; Idle/Sit/Perch stay; Jump still leaves. bubble_visible (#1073) remains a separate locomotion hold; both fields coexist on WorldSnapshot. Appear/dismiss 380ms + accent caret + chat_send echo:true covered by tests.

Softs

  • (a) Met — dwell 2500ms pinned; Escape does not dismiss; leave-during-dwell / leave-after-up / three dismiss paths / poke / field-drag covered.
  • (b) Met — composing walk hold + Jump still leaves; coexists with bubble_visible.
  • (c) Met — multi-instance caret singular (DOM focus + id match).
  • (d) Open — #1076 issue body still describes the pre-lock UX; refresh before close.
  • (e) Open — removeView.dispose() cancels hover but does not syncQuick/reportComposing (stale OVERLAY_COMPOSING id is inert once Instance is gone).
  • (f) Open — platform CI still pending at gate (Pages build green).

No merge from Architect — awaiting explicit yes after CI green.

— Cursor agent (Architect), on @omesser's behalf.

cursoragent and others added 7 commits September 27, 2026 20:12
Hover dwell stays 200ms. The composer uses Speech bubble chrome without a tail, then scales and fades in over 380ms on the cue settle curve.

Co-authored-by: Oded Messer <odedmesser@gmail.com>
…lice

The page copies from .bubble through thinking-bounce, and treats a transparent background in that span as overlay layout.

Co-authored-by: Oded Messer <odedmesser@gmail.com>
The empty field says "talk to me". Send is an icon, not the Open chat underline.

Co-authored-by: Oded Messer <odedmesser@gmail.com>
The motion mock peaks at 1.02. Send is an accent disc with a dark triangle, and the empty field stays "talk to me".

Co-authored-by: Oded Messer <odedmesser@gmail.com>
The settled box is 200 by 48, the Send circle stays 28, and a longer line still wraps.

Co-authored-by: Oded Messer <odedmesser@gmail.com>
Co-authored-by: Oded Messer <odedmesser@gmail.com>
Co-authored-by: Oded Messer <odedmesser@gmail.com>
@cursor
cursor Bot force-pushed the cursor/quick-message-composer-213c branch from ddcd59b to 4740b54 Compare September 27, 2026 20:13

@omesser omesser left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLEARED at tip 4740b545449e930737d2f4f451851fad0ddd2238.

Tip advance vs last CLEARED ddcd59b is a rebase of the same quick-message lineage onto main (incl. #1075 / #1073 bubble_visible) — not a new quick-message delta. Diff of quick-message.js / overlay wiring / platform composing / tests/quick-message.test.js against prior substance tip 5df63ed is empty; engine.rs only gains coexisting bubble_visible locomotion hold from main.

Gate (locked PR Why)

  • Dwell: HOVER_DELAY_MS=2500; leave during dwell cancels; leave after pill-up does not dismiss (leaveSprite only cancelHover).
  • Dismiss: outside click / overlay blur → outside; pet drag past DRAG_DISMISS_PX=4 → drag; sprite dblclick → summon (Chat). Poke still reaches pet via press("character"); composer press does not arm petDrag (field drag = selection). Escape does not dismiss.
  • Composing vs bubble_visible: overlay reports caret Instance via overlay_composing; tick sets world.composing per-Instance; permitted refuses Walk/Chase while composing and zeroes in-flight walk so the first composing tick does not step; Idle/Sit/Perch stay; Jump still leaves. Separate from bubble_visible (#1073) — both fields on WorldSnapshot. Tests present: tests/quick-message.test.js, typing_a_quick_message_*, composing_names_one_instance_*.

Softs

  • (a) Met — dwell 2500ms; Escape not dismiss; leave-during / leave-after / three dismiss / poke / field-drag covered (unchanged).
  • (b) Met — composing walk hold + Jump leaves; coexists with bubble_visible.
  • (c) Met — multi-instance caret singular (DOM focus + id match).
  • (d) Open — #1076 issue body still describes ~200ms dwell / Escape-unless-draft / accent-underline Send; refresh before close.
  • (e) Open — removeView → dispose() cancels hover only; does not syncQuick/reportComposing (stale OVERLAY_COMPOSING id remains inert once Instance is gone).
  • (f) Open — platform CI still pending at gate (ubuntu/macos/windows in progress; Pages build green).

No merge from Architect — awaiting explicit yes after CI green.

— Cursor agent (Architect), on @omesser's behalf.

Co-authored-by: Oded Messer <odedmesser@gmail.com>

@omesser omesser left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLEARED at tip 49b873701e09c79ef8d6afe6d413be5583d76556.

Tip advance vs last CLEARED 4740b545 is Soft (e) only: fix: Drop the typing hold when a quick message is disposed. createQuickMessage.dispose() now clears text/visible/focused/claimFocus and fires onChange before disposed=true (and while removeView still has the Instance mapped), so syncQuick → reportComposing drops the caret hold instead of leaving a stale OVERLAY_COMPOSING id. enterSprite/restore are no-ops after dispose. Covered by tests/quick-message.test.js (dispose clears the composer so composing cannot stick). Comment in removeView documents the scan-while-mapped ordering. No other gate substance changed.

Gate (locked PR Why) — unchanged

  • Dwell: HOVER_DELAY_MS=2500; leave during dwell cancels; leave after pill-up does not dismiss (leaveSprite only cancelHover).
  • Dismiss: outside click / overlay blur → outside; pet drag past DRAG_DISMISS_PX=4 → drag; sprite dblclick → summon (Chat). Poke still reaches pet via press("character"); composer press does not arm petDrag. Escape does not dismiss.
  • Composing vs bubble_visible: overlay reports caret Instance via overlay_composing; tick sets world.composing per-Instance; permitted refuses Walk/Chase while composing and zeroes in-flight walk; Idle/Sit/Perch stay; Jump still leaves. Separate from bubble_visible (#1073); both on WorldSnapshot.

Softs

  • (a) Met — dwell 2500ms; Escape not dismiss; leave-during / leave-after / three dismiss / poke / field-drag covered (unchanged).
  • (b) Met — composing walk hold + Jump leaves; coexists with bubble_visible.
  • (c) Met — multi-instance caret singular (DOM focus + id match).
  • (d) Open — #1076 issue body still describes ~200ms dwell / Escape-unless-draft / accent-underline Send; refresh before close.
  • (e) Met — dispose/removeView now clear composing via onChange→syncQuick→reportComposing while Instance still mapped; typing false + dispose-final covered by test.
  • (f) Open — platform CI still pending at gate (ubuntu/macos/windows in progress; Pages build green, deploy skipping).

No merge from Architect — awaiting explicit yes after CI green.

— Cursor agent (Architect), on @omesser's behalf.

Co-authored-by: Oded Messer <odedmesser@gmail.com>

@omesser omesser left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLEARED at tip 3c8773d01064965fe0f6cf00d1dba8a976168e9a.

Tip advance vs last CLEARED 49b873701e09 is Soft (e) hardening only: fix: Clear overlay composing after the view is removed. dispose() still clears text/visible/focused/claimFocus and fires onChange→syncQuick→reportComposing while the Instance is mapped (unchanged from 49b8737). This tip adds a second reportComposing() in removeView after views.delete(id), so a scan cannot still name a gone id even if the dispose-path report were skipped. Source pin in tests/quick-message.test.js asserts dispose → views.delete → reportComposing. No other gate substance moved.

Gate (locked PR Why) — unchanged

  • Dwell: HOVER_DELAY_MS=2500; leave during dwell cancels; leave after pill-up does not dismiss (leaveSprite only cancelHover).
  • Dismiss: outside click / overlay blur → outside; pet drag past DRAG_DISMISS_PX=4 → drag; sprite dblclick → summon (Chat). Poke still reaches pet via press("character"); composer press does not arm petDrag. Escape does not dismiss.
  • Composing vs bubble_visible: overlay reports caret Instance via overlay_composing; tick sets world.composing per-Instance; permitted refuses Walk/Chase while composing and zeroes in-flight walk; Idle/Sit/Perch stay; Jump still leaves. Separate from bubble_visible (#1073); both on WorldSnapshot.

Softs

  • (a) Met — dwell 2500ms; Escape not dismiss; leave-during / leave-after / three dismiss / poke / field-drag covered (unchanged).
  • (b) Met — composing walk hold + Jump leaves; coexists with bubble_visible.
  • (c) Met — multi-instance caret singular (DOM focus + id match).
  • (d) Met — #1076 issue body refreshed to locked UX (2.5s dwell, Escape does not dismiss, accent-circle Send, dispose clears composing); no longer the stale ~200ms / Escape-unless-draft / underline-Send draft.
  • (e) Met — dispose-while-mapped clear retained; tip adds post-views.delete reportComposing + source pin so a stale overlay id cannot stick after remove.
  • (f) Open — platform CI still pending at gate (ubuntu/macos/windows in progress; Pages build green, deploy skipping).

No merge from Architect — awaiting explicit yes after CI green.

— Cursor agent (Architect), on @omesser's behalf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Pop in a quick message above the Character on hover

2 participants