Repository navigation
fix(engine): Preempt the walk while a bubble or the pill is up - #1208
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
omesser
commented
Oct 1, 2026
omesser
left a comment
Owner
Author
There was a problem hiding this comment.
Soft-gate — PR #1208
Soft CLEARED = pass (merge-ready pending your yes). Soft Open would mean not pass yet.
Tip gated: 6d27f8f73bdd1f5c731f9f268d00273f2c889add (fix/walk-cycle-under-bubble)
Draft: no · Mergeable: yes · mergeStateStatus: CLEAN · Closes: none linked
Hard (value-preservation) — Holds
- Position under a bubble/pill stays fixed — same as #1073/#1077 intent; velocity is zeroed at the gate so
dxis zero without a special branch. - Typing still holds the feet —
feet_held = composing || locomotion_frozen; jump may still leave. - Walk/chase cannot start under the hold —
permittedrefuses them whilefeet_held; an in-flight walk/chase is stopped rather than striding in place. talkis required art — Required Animation Set; no idle fallback for the bubble arm.- Thaw restores nothing — Director’s next pick walks again (asserted).
Soft ledger
| Soft | Status | Evidence |
|---|---|---|
| (a) Hero-take bug | Pass | Walk under bubble no longer keeps velocity / walk Primitive / walk art. Preempt via composing gate + talk while locomotion_frozen on feet. |
| (b) Gate reuse | Pass | feet_held unifies composing and bubble/pill; locomotion_allowed / zero-dx branch removed as redundant once velocity is cleared. |
| (c) Tests | Pass | a_walk_is_preempted_while_a_speech_bubble_is_up replaces the two hold-still tests; asserts held position, velocity.x == 0, talk, refused walk under bubble, no restore on thaw, next pick walks. PR claims red on test-only commit, green with fix; tip CI green. |
| (d) Merge hygiene | Pass | 2 commits (test then fix); single file crates/core/src/engine.rs (+45/−70); MERGEABLE CLEAN vs main. Behind by #1206/#1207/#1203 (docs/package only — no engine.rs overlap). No issue Closes. |
| (e) CI on tip | Pass | checks (ubuntu/macos) + windows success; Pages build success / deploy skipped. |
| (f) Blast (sit/idle → talk) | Pass (disclosed) | Sitting/standing under a bubble now draws talk for the bubble’s duration — intentional; look changes while speaking, function (no translation) same. |
Soft-FIX (Coder)
None.
Notes
- Live hero-take proof called out in the PR; Soft rests on structure + named test + tip CI.
- Do not merge from this gate; COMMENT only — await Oded yes.
— Cursor agent (Architect), on @omesser's behalf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Found on the hero take. From about 13 s to 24 s Trump stands under a speech bubble and cycles his walk frames without moving. #1073 zeroed the walk's step while a bubble is up and #1077 extended that to the quick-message pill, but the walk itself stayed in force: velocity kept,
walkPrimitive on screen,walkart picked from the velocity. A walk that cannot translate was drawn as a stride in place.The Engine already had the right notion for a held sprite. Typing (
composing) stops a walk or chase, zeroes the velocity, and refuses a new walk until the caret leaves. A bubble or the pill now goes through that same gate, and a sprite on its feet drawstalkwhile one is up. When the bubble clears nothing is restored; the Director's next pick walks again.Scope
Engine::feet_heldincrates/core/src/engine.rsreplaces thecomposingcopy and iscomposing || locomotion_frozen. The hold at the top oftickandpermittedread it.talkarm for a sprite on its feet under a bubble.talkis in the Required Animation Set, so there is no Character without it and noidlefallback to write.locomotion_allowedand the zeroeddxbranch are gone. With the velocity zeroed at the gate, the step is zero on its own.a_walk_is_preempted_while_a_speech_bubble_is_upreplaces the two identical hold-still tests from feat(engine): Hold still while a speech bubble is up #1073 and feat: Pop in a quick message above the Character on hover #1077. It asserts position held, velocity zero,talkart, a walk proposal refused under the bubble, nothing restored on the thaw, and the next walk proposal walking.Tradeoffs
Swapping the art alone (keep the stroll, draw
talk, resume on the thaw) was smaller. It left thewalkPrimitive and a chase's timer running under the bubble and let a new walk start there. The composing gate already answers all of that, so the bubble joins it.Blast Radius
Every Character, only while a speech bubble or the quick-message pill is visible. A sprite that was walking stops and talks. A sitting or standing sprite draws
talkfor the bubble's duration where it drewsitoridlebefore. Position never changes under a bubble, as before.Verification
cargo test -p fidget-core: 512 pass. The new test fails on the test commit alone (velocity.xleft: 120.0, right: 0.0) and passes with the fix on top.cargo clippy --workspace --all-targets -- -D warnings,node --test tests/(471 pass), pre-commit: clean.cargo test --workspace: 4harness::testsfail under the full parallel run and pass when run alone. They are launcher-fixture timing tests insrc-tauri/src/harness.rs, untouched here.— Claude Code agent, on @omesser's behalf.
🤖 Generated with Claude Code