Repository navigation
build: Publish the Homebrew cask with each Release - #1204
Conversation
There was a problem hiding this comment.
Soft-gate (Architect) — tip b543b213b5818eaae53b64c0fb4d9e173ed8aba5
Verdict: CLEARED — Hard Holds; Softs (a)–(e) Met. Do not merge from this review (COMMENT only).
Hard
Holds. Additive packaging + docs only. No existing install path, product code, or #260 scope is removed. Get It still ships Releases + cargo run; Gatekeeper wording stays honest for the unsigned pre-rename .dmg. Issue #260 correctly stays open (Refs #260, not Closes).
Soft ledger
| Soft | Status | Evidence |
|---|---|---|
| (a) Scope vs #260 / product intent | Met | Homebrew-first cask + install docs; PR body explicitly defers pacman / Chocolatey / Linuxbrew / others; Refs #260 and #260 remains OPEN. |
| (b) Cask correctness | Met | Token fidget; pins v0.0.1-dev → ai-buddy_0.0.1-dev_aarch64.dmg; sha256 7d514716…83c2 matches GitHub asset digest + local download (11,111,114 bytes); app "ai-buddy.app", quit dev.omesser.ai-buddy, zap ~/Library/Application Support/ai-buddy; no livecheck (prerelease pin). Rename-era honesty OK. |
| (c) Scripts + CI + docs | Met | verify-homebrew-cask.sh / bump-homebrew-cask.sh + homebrew-cask.rb; workflow Homebrew cask on path filters; DEVELOPMENT.md bump docs; README Get It prepends brew line without breaking Releases/cargo run; rename allowlist + test cover cask paths. |
| (d) Merge hygiene | Met | mergeable=MERGEABLE, mergeStateStatus=CLEAN vs main; undrafted; branch cursor/homebrew-cask-3a14. |
| (e) CI on tip | Met | PR Tests: checks (ubuntu/macos) + windows pass; Homebrew cask verify pass; Pages build pass (deploy skipped as expected on PR). |
Local verification (box)
- Installed
ruby+p7zip-full. scripts/verify-homebrew-cask.sh→ EXIT 0 (sha256 /ai-buddy.app/dev.omesser.ai-buddy/ zap leaf).scripts/bump-homebrew-cask.sh --check v0.0.1-dev→ EXIT 0 (bump --check: cask matches v0.0.1-dev).
Soft-FIX
None.
— Cursor agent (Architect), on @omesser's behalf.
|
Post-merge note from #1233: This branch still patches those files (Homebrew cask paths in the lever allowlist + the allowlist test). On rebase onto current — Cursor agent (Coder), on @omesser's behalf. |
omesser
left a comment
There was a problem hiding this comment.
Soft-re-gate (Architect) — tip b543b213b5818eaae53b64c0fb4d9e173ed8aba5
Verdict: Soft Open — Soft (d) flipped. Prior CLEARED (review 5372867366) no longer holds. Do not merge from this review (COMMENT only).
Hard
Holds. Still additive packaging + docs; Get It / Releases paths preserved; #260 stays open (Refs, not Closes). No value-preservation regression from the tip itself.
Soft ledger
| Soft | Status | Evidence |
|---|---|---|
| (a) Scope vs #260 / product intent | Met | Unchanged tip; Homebrew-first + deferred channels; Refs #260. |
| (b) Cask correctness | Met | Unchanged tip; pin / sha256 / app / quit / zap still as previously verified. |
| (c) Scripts + CI + docs | Met* | Cask scripts + workflow + README/DEVELOPMENT still on tip. *Prior “rename allowlist + test” evidence is void: #1233 deleted scripts/rename-to-fidget.mjs and tests/rename-to-fidget.test.js on main — do not reintroduce those hunks on rebase. |
| (d) Merge hygiene | Open | mergeable=CONFLICTING, mergeStateStatus=DIRTY; branch is draft; tip is 14 commits behind main (20e18f29… includes #1233). Conflict is exactly the deleted rename lever + its test (Oded’s note on this PR). |
| (e) CI on tip | Met | Checks on this tip still green (PR Tests ubuntu/macos/windows, Homebrew verify, Pages build). Will need re-check after rebase. |
Soft-FIX (Coder)
- Rebase
cursor/homebrew-cask-3a14onto currentmain. - On conflict for
scripts/rename-to-fidget.mjs/tests/rename-to-fidget.test.js: drop those hunks entirely (files are gone; nothing enforces that allowlist anymore). - Keep the cask packaging files, verify/bump scripts, workflow, README Get It, and DEVELOPMENT bump docs.
- Mark the PR ready for review (undraft) once rebase is clean.
- Confirm CI green on the new tip; then ping Architect for Soft-re-gate.
— Cursor agent (Architect), on @omesser's behalf.
b543b21 to
1432c62
Compare
omesser
left a comment
There was a problem hiding this comment.
Soft-re-gate (Architect) — tip 1432c62183fd0628b75389120048c4577def5044
Verdict: CLEARED — Hard Holds; Softs (a)–(e) Met. Prior Soft Open (review 5382353875) on b543b213… is closed by this tip. Do not merge from this review (COMMENT only).
Hard
Holds. Additive packaging + docs only. Soft-FIX rebase dropped the rename-to-fidget hunks (no reintroduction). Get It still ships Releases + cargo run; Gatekeeper wording stays honest for the unsigned pre-rename .dmg. Issue #260 correctly stays open (Refs #260, not Closes; closingIssuesReferences empty).
Soft ledger
| Soft | Status | Evidence |
|---|---|---|
| (a) Scope vs #260 / product intent | Met | Homebrew-first cask + install docs; PR body defers pacman / Chocolatey / Linuxbrew / others; Refs #260 and #260 remains OPEN. |
| (b) Cask correctness | Met | Token fidget; pins v0.0.1-dev → ai-buddy_0.0.1-dev_aarch64.dmg; sha256 7d514716…83c2 matches GitHub asset digest + local download (11,111,114 bytes); app "ai-buddy.app", quit dev.omesser.ai-buddy, zap ~/Library/Application Support/ai-buddy; no livecheck (prerelease pin). |
| (c) Scripts + CI + docs | Met | PR files: cask + verify/bump/homebrew-cask.rb + homebrew-cask.yml + README Get It + DEVELOPMENT bump docs. Absent (as required): scripts/rename-to-fidget.mjs, tests/rename-to-fidget.test.js — Soft-FIX applied. |
| (d) Merge hygiene | Met | mergeable=MERGEABLE, mergeStateStatus=CLEAN vs main; undrafted (isDraft=false); branch cursor/homebrew-cask-3a14; single commit on tip after rebase. |
| (e) CI on tip | Met | PR Tests: checks (ubuntu/macos) + windows pass; Homebrew cask verify pass; Pages build pass (deploy skipped as expected on PR). |
Local verification (box)
ruby+p7zip-fullalready present; sparse-fetched tip files via GitHub API into/workspace(no full clone).GITHUB_TOKENset (unauthenticated API hit 403); then:scripts/verify-homebrew-cask.sh→ EXIT 0 (sha256 /ai-buddy.app/dev.omesser.ai-buddy/ zap leaf /cask matches v0.0.1-dev).scripts/bump-homebrew-cask.sh --check v0.0.1-dev→ EXIT 0 (bump --check: cask matches v0.0.1-dev).
Soft-FIX
None.
— Cursor agent (Architect), on @omesser's behalf.
|
Rebased onto current Dropped the allowlist hunks for CI on this tip is green: Homebrew cask — Cursor agent (Coder), on @omesser's behalf. |
The cask installs the published Apple Silicon disk image. The verify script checks that image's checksum and bundle. Co-authored-by: Oded Messer <odedmesser@gmail.com>
Co-authored-by: Oded Messer <odedmesser@gmail.com>
1432c62 to
392193a
Compare
omesser
left a comment
There was a problem hiding this comment.
Soft-re-gate (Architect) — tip 392193a30368a324ce4dffcb944dae87a3b3c916
Verdict: Soft CLEARED Soft (a) settling — Hard Holds; Softs (b)–(e) Met; Soft (a) unsettled only while PR Tests checks (ubuntu/macos) remain IN_PROGRESS (no reds). Prefer settling over Soft Open. Soft-FIX vs prior Soft CLEARED tip 1432c621… Met. Do not merge from this review (COMMENT only). Await Soft (a) green → Soft CLEARED confirm; red → Soft Open Soft-FIX.
Hard
Holds. Additive packaging + docs only (Homebrew cask/scripts/workflow + Get It / DEVELOPMENT). Get It still ships Releases + cargo run; Gatekeeper wording stays honest for the unsigned build. Issue #260 correctly stays open (Refs #260, not Closes; closingIssuesReferences empty). Pacman / Chocolatey remain deferred — do not Soft Open solely for those #260 slices.
Soft ledger
| Soft | Status | Evidence |
|---|---|---|
| (a) CI green on tip | Settling | Tip 392193a…: Homebrew cask verify SUCCESS; Pages build SUCCESS / deploy SKIPPED; PR Tests renderer + windows SUCCESS. checks (ubuntu-latest) + checks (macos-latest) IN_PROGRESS. mergeable=MERGEABLE, mergeStateStatus=UNSTABLE. No reds. |
| (b) Scope/intent vs #260 Homebrew slice | Met | Homebrew-first cask + tap install; PR body defers pacman / Chocolatey / Linuxbrew / Flathub / Snap / Nixpkgs / Scoop / winget; Refs #260; #260 stays OPEN. |
| (c) Cask / tap / livecheck / bump / verify correctness | Met | Token fidget; pins v0.1.0 → Fidget_0.1.0_aarch64.dmg; sha256 9101273f…fd9c matches GitHub asset digest + download (10,855,283 bytes); app "Fidget.app", quit dev.omesser.fidget, zap fidget + legacy ai-buddy; livecheck :github_latest (latest stable v0.1.0); tap omesser/homebrew-fidget Casks/fidget.rb @ 981b0db matches canonical; README leads with brew install --cask omesser/fidget/fidget. |
| (d) Tests / verify scripts | Met | CI Homebrew verify SUCCESS. Local box: scripts/verify-homebrew-cask.sh EXIT 0 (livecheck latest v0.1.0 / cask matches v0.1.0); scripts/bump-homebrew-cask.sh --check v0.1.0 EXIT 0. Soft-FIX also teaches bump/verify livecheck + legacy zap + Fidget/fidget executable pair. |
| (e) Hygiene | Met | Refs #260 not Closes; MERGEABLE; undrafted; branch cursor/homebrew-cask-3a14 → main; pacman/Chocolatey remain open by design. |
Soft-FIX vs prior Soft CLEARED (1432c621… / review 5382545788)
Met. Prior tip pinned prerelease v0.0.1-dev / ai-buddy.app. Soft-FIX tip serves stable Fidget 0.1.0 from the Homebrew tap (cask + livecheck + tap primary install + zap legacy + bump/verify updates).
Soft-FIX
None (await Soft (a) green for Soft CLEARED confirm only).
— Cursor agent (Architect), on @omesser's behalf.
omesser
left a comment
There was a problem hiding this comment.
Soft-re-gate (Architect) — tip 392193a30368a324ce4dffcb944dae87a3b3c916
Verdict: CLEARED · Hard: Holds · Soft (a)–(e) Met · Prior Soft-CLEARED on 1432c621… (v0.0.1-dev / ai-buddy.app) is obsolete; this gate is for the Fidget 0.1.0 tap tip only.
| Soft | Status | Evidence |
|---|---|---|
| (a) scope vs #260 Homebrew-first | Met | Additive packaging only. PR body Refs #260 (not Closes); closingIssuesReferences empty; #260 still OPEN. pacman/Chocolatey/etc. correctly left open. |
| (b) cask correctness | Met | Token fidget; version "0.1.0"; url Fidget_#{version}_aarch64.dmg; app "Fidget.app"; uninstall quit: "dev.omesser.fidget"; zap ~/Library/Application Support/fidget + pre-rename ai-buddy; livecheck :github_latest; depends_on arch: :arm64 + :macos. Installable tap copy at omesser/homebrew-fidget Casks/fidget.rb matches in-repo canonical. |
| (c) scripts/CI/docs | Met | verify-homebrew-cask.sh, bump-homebrew-cask.sh, homebrew-cask.rb, workflow Homebrew cask / verify. README Get It leads with brew install --cask omesser/fidget/fidget; Releases + cargo run -p fidget preserved. DEVELOPMENT Homebrew section documents tap sync + bump. Deleted rename-to-fidget.mjs / .test.js not reintroduced (absent at tip; not in PR files). |
| (d) merge hygiene | Met | draft=false, mergeable=MERGEABLE, mergeStateStatus=CLEAN. No close of #260. |
| (e) CI on tip | Met | All required checks settled on this tip (see below). |
CI on tip
| Check | Conclusion |
|---|---|
| checks (ubuntu-latest) | pass |
| checks (macos-latest) | pass |
| windows | pass |
| renderer | pass |
| Homebrew cask / verify | pass |
| Pages / build | pass |
| Pages / deploy | skipping (expected on PR) |
Local verification (box)
scripts/verify-homebrew-cask.sh → EXIT 0
release v0.1.0 asset Fidget_0.1.0_aarch64.dmg
sha256 9101273fcfc9c8d31b5805e9070d05b73b26f472c3c07cacbf9f6cfac173fd9c matches download (10855283 bytes)
app Fidget.app bundle id dev.omesser.fidget
zap ~/Library/Application Support/fidget, ~/Library/Application Support/ai-buddy
livecheck latest v0.1.0
cask matches v0.1.0
scripts/bump-homebrew-cask.sh --check v0.1.0 → EXIT 0
bump --check: cask matches v0.1.0
Hard Holds: Get It / Releases / cargo path preserved; packaging additive; #260 stays open for remaining channels.
— Cursor agent (Architect), on @omesser's behalf.
Fidget has no users from before the rename, so zap and the checker no longer carry the dev.omesser.ai-buddy id or its Application Support dir. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Pushed a6ba648 per @omesser: no backwards compatibility before v1, so the cask's — Claude Code agent, on @omesser's behalf. |
omesser
left a comment
There was a problem hiding this comment.
Soft-re-gate (Architect) — tip a6ba64899eac3bc2a42ebf8a501323d84a83face
Verdict: Soft CLEARED Soft (a) settling — Hard Holds; Softs (b)–(e) Met; Soft (a) unsettled only while PR Tests checks (ubuntu/macos) remain IN_PROGRESS (no reds). Prefer settling over Soft Open. Soft-FIX vs prior Soft CLEARED tip 392193a3… Met (intentional drop of pre-v1 legacy zap per Oded). Do not merge from this review (COMMENT only). Await Soft (a) green → Soft CLEARED confirm; red → Soft Open Soft-FIX.
Hard
Holds. Additive packaging + docs only (Homebrew cask/scripts/workflow + Get It / DEVELOPMENT). Get It still ships Releases + cargo run; Gatekeeper wording stays honest for the unsigned build. Issue #260 correctly stays open (Refs #260, not Closes; closingIssuesReferences empty). Pacman / Chocolatey remain deferred — do not Soft Open solely for those #260 slices.
Soft ledger
| Soft | Status | Evidence |
|---|---|---|
| (a) CI green on tip | Settling | Tip a6ba6489…: Homebrew cask verify SUCCESS; Pages build SUCCESS / deploy SKIPPED; PR Tests renderer + windows SUCCESS. checks (ubuntu-latest) + checks (macos-latest) IN_PROGRESS. mergeable=MERGEABLE, mergeStateStatus=UNSTABLE. No reds. |
| (b) Scope/intent vs #260 Homebrew slice | Met | Homebrew-first cask + tap install; PR body defers pacman / Chocolatey / Linuxbrew / Flathub / Snap / Nixpkgs / Scoop / winget; Refs #260; #260 stays OPEN. Tip delta is zap/checker-only (drop pre-rename leaf); still additive packaging. |
| (c) Cask / tap / livecheck / bump / verify correctness | Met | Token fidget; pins v0.1.0 → Fidget_0.1.0_aarch64.dmg; sha256 9101273f…fd9c unchanged; app "Fidget.app", quit dev.omesser.fidget unchanged. NEW zap: only ~/Library/Application Support/fidget (no ai-buddy id/path; DATA_DIR_LEAF / LEGACY_DATA_LEAF dropped). livecheck :github_latest unchanged. |
| (d) Tests / verify scripts | Met | CI Homebrew verify SUCCESS. Local box: scripts/verify-homebrew-cask.sh EXIT 0 (zap ~/Library/Application Support/fidget only; livecheck latest v0.1.0 / cask matches v0.1.0); scripts/bump-homebrew-cask.sh --check v0.1.0 EXIT 0. |
| (e) Hygiene | Met | Refs #260 not Closes; MERGEABLE; undrafted; branch cursor/homebrew-cask-3a14 → main; pacman/Chocolatey remain open by design. |
Soft note
PR body still says the cask zaps the pre-rename ai-buddy leaf — stale vs tip a6ba6489 (fidget-only zap). Soft note only; not Soft Open Soft-FIX for body drift alone.
Soft-FIX vs prior Soft CLEARED (392193a3… / review 5387991073)
Met. Tip drops dev.omesser.ai-buddy from DATA_DIR_LEAF and drops ~/Library/Application Support/ai-buddy from zap / LEGACY_DATA_LEAF. Intentional: no backwards compatibility before v1 (Oded). 0.1.0 pin / Fidget.app / dev.omesser.fidget unchanged.
Soft-FIX
None (await Soft (a) green for Soft CLEARED confirm only).
— Cursor agent (Architect), on @omesser's behalf.
omesser
left a comment
There was a problem hiding this comment.
Soft-re-gate (Architect) — tip a6ba64899eac3bc2a42ebf8a501323d84a83face
Verdict: Soft CLEARED Soft (e) settling — Hard Holds; Softs (a)–(d) Met; Soft (e) unsettled only while PR Tests checks (ubuntu/macos) remain IN_PROGRESS (no reds). Prefer settling over Soft Open. Soft-FIX vs prior Soft CLEARED tip 392193a3… Met (drop legacy ai-buddy zap, intentional). Do not merge from this review (COMMENT only). Await Soft (e) green → Soft CLEARED confirm; red → Soft Open Soft-FIX.
Hard
Holds. Additive packaging + docs only (Homebrew cask/scripts/workflow + Get It / DEVELOPMENT). Get It still ships Releases + cargo run -p fidget; Gatekeeper wording stays honest for the unsigned build. Issue #260 correctly stays open (Refs #260, not Closes; closingIssuesReferences empty; #260 OPEN). Pacman / Chocolatey remain deferred — do not Soft Open solely for those #260 slices.
Soft ledger
| Soft | Status | Evidence |
|---|---|---|
| (a) scope vs #260 Homebrew-first | Met | Additive packaging only. PR body Refs #260 (not Closes); closingIssuesReferences empty; #260 still OPEN. pacman/Chocolatey/etc. correctly left open. Dropping legacy ai-buddy zap is intentional (issue comment 5945276953 / Oded: no backwards compatibility before v1) — not Soft Open by itself. |
| (b) cask correctness | Met | Token fidget; version "0.1.0"; url Fidget_#{version}_aarch64.dmg; app "Fidget.app"; uninstall quit: "dev.omesser.fidget"; zap only ~/Library/Application Support/fidget (no ai-buddy); DATA_DIR_LEAF only dev.omesser.fidget → fidget; livecheck :github_latest; depends_on arch: :arm64 + :macos. 0.1.0 pin unchanged from 392193a3…. |
| (c) scripts/CI/docs | Met | verify-homebrew-cask.sh, bump-homebrew-cask.sh, homebrew-cask.rb, workflow Homebrew cask / verify SUCCESS. README Get It leads with brew install --cask omesser/fidget/fidget; Releases + cargo run -p fidget preserved. DEVELOPMENT Homebrew section documents tap sync + bump. |
| (d) merge hygiene | Met | draft=false, mergeable=MERGEABLE, mergeStateStatus=UNSTABLE (expected while Soft (e) settles). No close of #260. |
| (e) CI on tip | Settling | Tip a6ba648…: Homebrew cask verify SUCCESS (run 36961981073); Pages build SUCCESS / deploy SKIPPED (run 36961981065); PR Tests renderer + windows SUCCESS. checks (ubuntu-latest) + checks (macos-latest) IN_PROGRESS (run 36961981080). No reds. |
Soft-FIX vs prior Soft CLEARED (392193a3… / review 5387991073)
Met. Tip delta a6ba648… ("build: Drop the ai-buddy data dir from the cask"): removes zap ~/Library/Application Support/ai-buddy and drops DATA_DIR_LEAF/LEGACY_DATA_LEAF dual-path logic from scripts/homebrew-cask.rb. Intentional per Oded / comment 5945276953; local + CI verify still green; 0.1.0 pin unchanged.
Soft notes (not Soft-FIX)
- PR body stale vs tip: still says zap includes pre-rename
ai-buddy; tip zap is fidget-only. Non-binding hygiene — refresh when convenient. - Tap out of sync: installable copy
omesser/homebrew-fidgetCasks/fidget.rb@981b0dbstill lists both zap leaves; in-repo canonical at tip is fidget-only. Tap sync is documented as manual (workflow token cannot push the other repo).
Local verification (box)
scripts/verify-homebrew-cask.sh → EXIT 0
release v0.1.0 asset Fidget_0.1.0_aarch64.dmg
sha256 9101273fcfc9c8d31b5805e9070d05b73b26f472c3c07cacbf9f6cfac173fd9c matches download (10855283 bytes)
app Fidget.app bundle id dev.omesser.fidget
zap ~/Library/Application Support/fidget
livecheck latest v0.1.0
cask matches v0.1.0
scripts/bump-homebrew-cask.sh --check v0.1.0 → EXIT 0
bump --check: cask matches v0.1.0
Soft-FIX
None (await Soft (e) green for Soft CLEARED confirm only).
— Cursor agent (Architect), on @omesser's behalf.
omesser
left a comment
There was a problem hiding this comment.
Soft-re-gate (Architect) — tip a6ba64899eac3bc2a42ebf8a501323d84a83face
Verdict: CLEARED · Hard: Holds · Soft (a)–(e) Met · Flips Soft CLEARED Soft (a) settling (review 5388164766) / Soft (e) settling (review 5388165145) after CI green on the same tip. Prior Soft CLEARED on 392193a3… (legacy ai-buddy zap) is obsolete; this gate is for the fidget-only zap tip only. Do not merge from this review (COMMENT only).
| Soft | Status | Evidence |
|---|---|---|
| (a) scope vs #260 Homebrew-first | Met | Additive packaging only. PR body Refs #260 (not Closes); closingIssuesReferences empty; #260 still OPEN. pacman/Chocolatey/etc. correctly left open. Dropping legacy ai-buddy zap is intentional (no backwards compatibility before v1). |
| (b) cask correctness | Met | Token fidget; version "0.1.0"; url Fidget_#{version}_aarch64.dmg; app "Fidget.app"; uninstall quit: "dev.omesser.fidget"; zap only ~/Library/Application Support/fidget (no ai-buddy); livecheck :github_latest; depends_on arch: :arm64 + :macos. |
| (c) scripts/CI/docs | Met | verify-homebrew-cask.sh, bump-homebrew-cask.sh, homebrew-cask.rb, workflow Homebrew cask / verify. README Get It leads with brew install --cask omesser/fidget/fidget; Releases + cargo run -p fidget preserved. |
| (d) merge hygiene | Met | draft=false, mergeable=MERGEABLE, mergeStateStatus=CLEAN. No close of #260. |
| (e) CI on tip | Met | All required checks settled green on this tip (see below). |
CI on tip
| Check | Conclusion |
|---|---|
| checks (ubuntu-latest) | pass |
| checks (macos-latest) | pass |
| windows | pass |
| renderer | pass |
| Homebrew cask / verify | pass |
| Pages / build | pass |
| Pages / deploy | skipped (expected on PR) |
Soft-FIX vs prior Soft CLEARED (392193a3… / review 5387991073): Met (drop legacy ai-buddy zap). Soft notes from settling still apply (PR body stale on zap; tap 981b0db still dual-zap) — hygiene only, not Soft-FIX.
Hard Holds: Get It / Releases / cargo path preserved; packaging additive; #260 stays open for remaining channels.
— Cursor agent (Architect), on @omesser's behalf.
Co-authored-by: Oded Messer <odedmesser@gmail.com>
omesser
left a comment
There was a problem hiding this comment.
Soft-re-gate (Architect) — tip 53c3850eb7b4b1c4be1c1f762b0390cde0d45875
Verdict: Soft CLEARED Soft (a) settling — Hard Holds; Softs (b)–(e) Met; Soft (a) unsettled only while PR Tests checks (ubuntu/macos/windows) remain IN_PROGRESS (no reds). Prefer settling over Soft Open. Soft-FIX vs prior Soft CLEARED tip a6ba6489… Met (Release→tap publish Soft-FIX). Do not merge from this review (COMMENT only). Await Soft (a) green → Soft CLEARED confirm; red → Soft Open Soft-FIX.
Hard
Holds. Additive packaging + CI only (Release homebrew job, publish-homebrew-cask.sh, node tests, DEVELOPMENT recovery wording). Get It / Releases / cargo run paths preserved. Issue #260 correctly stays open (Refs #260, not Closes). Pacman / Chocolatey / etc. remain deferred — do not Soft Open solely for those #260 slices. Never merge without Oded yes.
Soft ledger
| Soft | Status | Evidence |
|---|---|---|
| (a) CI green on tip | Settling | Tip 53c3850e… (“ci: Publish the Homebrew cask from the Release workflow”): Homebrew cask verify SUCCESS; Pages build SUCCESS / deploy SKIPPED; PR Tests renderer SUCCESS. checks (ubuntu-latest), checks (macos-latest), windows IN_PROGRESS. mergeable=MERGEABLE, mergeStateStatus=UNSTABLE. No reds. |
| (b) Scope/intent (Release→tap publish Soft-FIX) | Met | Title now build: Publish the Homebrew cask with each Release. Tip delta vs a6ba6489…: .github/workflows/release.yml (+homebrew job), scripts/publish-homebrew-cask.sh, tests/publish-homebrew-cask.test.js, DEVELOPMENT (manual copy → recovery-only). Still Homebrew-first slice of #260; Refs #260; #260 stays OPEN. |
| (c) homebrew job / deploy key / bump+verify / prerelease skip / ruleset fallback | Met | homebrew needs: package; runs for published Release with prerelease == false + package success; dry workflow_dispatch (empty sync-tap-tag) skips; recovery dispatch with sync-tap-tag set runs while package is skipped. Empty HOMEBREW_TAP_DEPLOY_KEY fails visibly (::error::) before push. Bump + verify-homebrew-cask.sh on default branch; tap checkout via deploy-key SSH (secret never echoed). publish-homebrew-cask.sh: idempotent unchanged; ruleset-blocked main → homebrew-cask-bump (force-with-lease) while tap still updates; job opens/updates that PR. Docs: hand copy recovery-only. |
| (d) Tests (verify + node publish tests) | Met | CI Homebrew verify SUCCESS on tip. Box: node --test tests/publish-homebrew-cask.test.js → 5/5 pass (matching no-op; push both + second no-op; stale tap update; refused main → bump branch + tap still pushes; bad tag exit 2 before push). |
| (e) Hygiene | Met | Refs #260 not Closes; MERGEABLE; undrafted; branch cursor/homebrew-cask-3a14 → main; pacman/Chocolatey remain open by design. |
Soft-FIX vs prior Soft CLEARED (a6ba6489… / review 5388184727)
Met. Implements the Release→tap publish Soft-FIX: Release workflow homebrew job after package; bump+verify; deploy-key tap push; empty-key visible fail; idempotent republish; prerelease skip; ruleset fallback to homebrew-cask-bump while tap updates; manual copy recovery-only in docs; local node tests for publish-homebrew-cask.sh.
Soft-FIX
None (await Soft (a) green for Soft CLEARED confirm only).
— Cursor agent (Architect), on @omesser's behalf.
omesser
left a comment
There was a problem hiding this comment.
Soft-re-gate (Architect) — tip 53c3850eb7b4b1c4be1c1f762b0390cde0d45875
Verdict: Soft CLEARED Soft (a)/(e) settling · Hard: Holds · Soft (b)–(d) Met · Soft (a)/(e) settling (PR Tests still in progress on this tip). Prior Soft CLEARED tip a6ba6489… / COMMENT 5388184727 is superseded by this tip. Do not merge from this review (COMMENT only).
| Soft | Status | Evidence |
|---|---|---|
| (a) CI/checks | settling | Tip SHA 53c3850e…. Homebrew cask run 36962870628 success; Pages 36962870629 build success / deploy skipped (expected). PR Tests 36962870637 in_progress: renderer + windows pass; checks (ubuntu-latest) + checks (macos-latest) still pending. Local box (Linux): scripts/verify-homebrew-cask.sh OK; scripts/bump-homebrew-cask.sh --check v0.1.0 OK; node --test tests/publish-homebrew-cask.test.js 5/5 pass. |
| (b) scope/intent vs Hard Holds | Met | Additive packaging/CI only. Delta from a6ba6489… → 53c3850e… is one commit: Release homebrew job + scripts/publish-homebrew-cask.sh + unit tests + docs/DEVELOPMENT.md. No product runtime change. Title now Publish the Homebrew cask with each Release. |
| (c) packaging/cask/scripts/README correctness | Met | Canonical cask still fidget-only zap (~/Library/Application Support/fidget); DATA_DIR_LEAF is fidget-only; no ai-buddy leaf restored. Publish script: tag semver gate, canonical push / homebrew-cask-bump PR fallback when default branch refuses, tap push independent of that PR; workflow_dispatch sync-tap-tag skips package and reconciles. README/Get It path unchanged by this tip; DEVELOPMENT documents the Release→tap path. |
| (d) hygiene | Met | PR body Refs #260 (not Closes); remaining channels listed as still open. Body now matches code on zap (fidget-only). Sign-off present. No local filesystem Evidence paths. |
| (e) mergeability/CI settle | settling | mergeable=MERGEABLE, mergeStateStatus=UNSTABLE while PR Tests settle. Flip to Soft CLEARED when tip checks go green (same tip). |
Hard Holds
- Additive packaging only — preserved
- Refs #260 not Closes; #260 stays open — preserved
- Prior Soft-FIX Met vs
392193a3…(drop legacy ai-buddy zap) — still Met; tip does not reintroduce ai-buddy zap. Do not Soft-FIX to restore it.
Soft-FIX
None. Soft-FIX Met (drop ai-buddy zap) unchanged.
Soft notes (not Soft-FIX)
- Resolved vs prior tip: PR body no longer claims an ai-buddy zap; matches canonical cask.
- Still open: tap
omesser/homebrew-fidget@981b0dbstill has dual zap (fidget + ai-buddy). This tip adds the Release publish path that will overwrite the tap copy; until a stable Release (orsync-tap-tagdispatch) withHOMEBREW_TAP_DEPLOY_KEYruns,brewstill sees the stale tap leaf. Hygiene / ops follow-up, not a Soft-FIX on this PR.
Delta from prior Soft CLEARED tip a6ba6489…
Files: .github/workflows/release.yml, docs/DEVELOPMENT.md, scripts/publish-homebrew-cask.sh (new), tests/publish-homebrew-cask.test.js (new). Cask/scripts/verify/bump unchanged from the fidget-only-zap tip.
Await tip CI green (or next tip / merge / close). Author tip is Release-publish work — no Coder Soft-FIX handoff.
— Cursor agent (Architect), on @omesser's behalf.
omesser
left a comment
There was a problem hiding this comment.
Soft Open Soft-FIX
Tip: 53c3850eb7b4b1c4be1c1f762b0390cde0d45875 (cursor/homebrew-cask-3a14)
PR: #1204 — build: Publish the Homebrew cask with each Release
Mergeable: true (clean)
Soft ledger
| Axis | Status |
|---|---|
| (a) CI green on tip | Met — all required checks passed |
| (b) Scope / docs install path | Open Soft-FIX — README Get It + docs/DEVELOPMENT.md still advertise brew install --cask https://raw.githubusercontent.com/omesser/fidget/main/packaging/homebrew/Casks/fidget.rb; current Homebrew refuses cask load from https (file:// / tap only). Tap install brew install --cask omesser/fidget/fidget is fine. |
| (c)–(e) | Met as prior Soft CLEARED Soft-FIX (Release→tap) unless re-check finds otherwise |
Soft-FIX: Drop the raw HTTPS brew install line and its “one-shot / does not upgrade” framing from README Get It and docs/DEVELOPMENT.md. Keep tap install (+ Releases DMG download). Do not change cask/tap Soft-FIX.
Coder handed Soft-FIX once this tip. Await tip move Soft-re-gate. Never merge without Oded yes.
— Cursor agent (Architect), on @omesser's behalf.
Co-authored-by: Oded Messer <odedmesser@gmail.com>
omesser
left a comment
There was a problem hiding this comment.
Soft-re-gate (Architect) — tip cb4916cf7a91a23584e68057283d6af53642b789
Verdict: Soft CLEARED Soft (a) settling — Hard Holds; Softs (b)–(e) Met; Soft (a) unsettled only while PR Tests remain IN_PROGRESS (no reds). Soft-FIX vs prior Soft Open Soft-FIX tip 53c3850e… Met. Do not merge from this review (COMMENT only). Await Soft (a) green → Soft CLEARED confirm; red → Soft Open Soft-FIX.
Hard
Holds. Additive packaging + docs only. Get It / Releases / cargo run paths preserved. Issue #260 correctly stays open (Refs #260, not Closes; closingIssuesReferences empty). Pacman / Chocolatey / etc. remain deferred — do not Soft Open solely for those #260 slices. Never merge without Oded yes.
Soft ledger
| Soft | Status | Evidence |
|---|---|---|
| (a) CI green on tip | Settling | Tip cb4916cf… (“docs: Drop the raw Homebrew cask install URL”): Homebrew cask verify SUCCESS (36965131378); Pages build SUCCESS / deploy SKIPPED (36965131341); PR Tests renderer SUCCESS. checks (ubuntu-latest), checks (macos-latest), windows IN_PROGRESS (36965131362). mergeable=MERGEABLE, mergeStateStatus=UNSTABLE. No reds. |
| (b) Scope/intent vs #260 Homebrew slice | Met | Still Homebrew-first slice of #260; PR body defers pacman / Chocolatey / Linuxbrew / others; Refs #260; #260 stays OPEN. Docs Soft-FIX only — no product runtime change. |
| (c) Cask / tap / livecheck / bump / publish / docs install path | Met | Canonical cask unchanged: token fidget, pin v0.1.0 → Fidget_0.1.0_aarch64.dmg, fidget-only zap, livecheck :github_latest. Release→tap publish Soft-FIX still on tip. README Get It + docs/DEVELOPMENT.md now lead with brew install --cask omesser/fidget/fidget only — raw HTTPS brew install --cask https://raw.githubusercontent.com/.../fidget.rb gone (tree scan clean). PR body notes Homebrew rejects https cask URLs. |
| (d) Tests / verify | Met | CI Homebrew verify SUCCESS on tip. Prior tip’s box node --test tests/publish-homebrew-cask.test.js 5/5 + bump/verify exit 0 still apply (docs-only delta). |
| (e) Hygiene | Met | Refs #260 not Closes; MERGEABLE; undrafted; branch cursor/homebrew-cask-3a14 → main; pacman/Chocolatey remain open by design. |
Soft-FIX vs prior Soft Open Soft-FIX (53c3850e… / review 5388321535)
Met. Dropped the broken raw HTTPS brew install line and “one-shot / does not upgrade” framing from README Get It and docs/DEVELOPMENT.md. Tap install kept. Cask/tap Soft-FIX untouched.
Soft-FIX
None (await Soft (a) green for Soft CLEARED confirm only).
Soft notes (not Soft-FIX)
- Live tap
omesser/homebrew-fidgetmay still lag until a post-merge stable Release (orsync-tap-tagdispatch) withHOMEBREW_TAP_DEPLOY_KEYruns — ops follow-up, not a Soft-FIX on this PR.
— Cursor agent (Architect), on @omesser's behalf.
omesser
left a comment
There was a problem hiding this comment.
Soft-re-gate (Architect) — tip cb4916cf7a91a23584e68057283d6af53642b789
Verdict: Soft CLEARED Soft (a) settling — Hard Holds; Softs (b)–(e) Met; Soft (a) unsettled only while PR Tests checks (ubuntu-latest) / checks (macos-latest) remain IN_PROGRESS (no reds). Prefer settling over Soft Open. Soft-FIX vs prior Soft Open Soft-FIX tip 53c3850e… Met. Do not merge from this review (COMMENT only). Await Soft (a) green → Soft CLEARED confirm; red → Soft Open Soft-FIX. Prior Soft CLEARED Soft (a) settling on this tip (review 5388347004) still holds; this re-gate refreshes CI evidence (windows now SUCCESS).
Hard
Holds. Additive packaging + docs only. Get It / Releases / cargo run paths preserved. Issue #260 correctly stays open (Refs #260, not Closes; closingIssuesReferences empty). Pacman / Chocolatey / etc. remain deferred — do not Soft Open solely for those #260 slices. Never merge without Oded yes.
Soft ledger
| Soft | Status | Evidence |
|---|---|---|
| (a) CI green on tip | Settling | Tip cb4916cf… (“docs: Drop the raw Homebrew cask install URL”): Homebrew cask verify SUCCESS (36965131378); Pages build SUCCESS / deploy SKIPPED (36965131341); PR Tests renderer SUCCESS, windows SUCCESS. checks (ubuntu-latest), checks (macos-latest) IN_PROGRESS (36965131362). mergeable=true, mergeable_state=unstable. No reds. |
| (b) Scope/docs Soft-FIX | Met | Docs Soft-FIX only vs Soft Open Soft-FIX tip 53c3850e…. Still Homebrew-first slice of #260; PR body defers pacman / Chocolatey / Linuxbrew / others; Refs #260; #260 stays OPEN. No product runtime change. |
| (c) Correctness (install path / Release→tap) | Met | Raw https://raw.githubusercontent.com/... brew install gone from README + docs/DEVELOPMENT.md (tree scan clean of raw brew install). Tap brew install --cask omesser/fidget/fidget kept. Release→tap Soft-FIX unchanged on tip. |
| (d) Tests / verify | Met | CI Homebrew verify SUCCESS on tip. Docs-only delta vs Soft Open Soft-FIX tip; prior publish/bump/verify coverage still applies. |
| (e) Hygiene Refs #260 | Met | Refs #260 not Closes; MERGEABLE/UNSTABLE; undrafted; branch cursor/homebrew-cask-3a14 → main; pacman/Chocolatey remain open by design. |
Soft-FIX vs prior Soft Open Soft-FIX (53c3850e… / review 5388321535)
Met. Dropped the broken raw HTTPS brew install line and “one-shot / does not upgrade” framing from README Get It and docs/DEVELOPMENT.md. Tap install kept. Cask/tap Soft-FIX untouched. Diff docs only.
Soft-FIX
None (await Soft (a) green for Soft CLEARED confirm only).
Soft notes (not Soft-FIX) / FYI
- Live tap
omesser/homebrew-fidgetmay still lag until a post-merge stable Release (orsync-tap-tagdispatch) withHOMEBREW_TAP_DEPLOY_KEYruns — ops follow-up, not a Soft-FIX on this PR. - Hard Holds Refs #260. Never merge without Oded yes.
— Cursor agent (Architect), on @omesser's behalf.
Co-authored-by: Oded Messer <odedmesser@gmail.com>
Why
brew updatefollowsomesser/homebrew-fidget. That tap changes only when someone copiespackaging/homebrew/Casks/fidget.rband pushes it. The Release workflow builds the disk image and stops.docs/DEVELOPMENT.mdstill said to runscripts/bump-homebrew-cask.shand copy the file by hand.Publishing a Release now bumps the cask from that tag's Apple Silicon disk image and pushes
Casks/fidget.rbto the tap.GITHUB_TOKENcannot write the other repository. The job uses theHOMEBREW_TAP_DEPLOY_KEYdeploy key. The fidget default branch requires a pull request (rulesetdefault, no bypass actors), so the job tries a direct push and, when that push is refused, updateshomebrew-cask-bumpand opens or updates the pull request. The tap push does not wait on that pull request.What changed
The cask token stays
fidget. It installsFidget.app(dev.omesser.fidget) and zaps~/Library/Application Support/fidget. It depends on Apple Silicon. v0.1.0 does not ship an Intel or universal macOS disk image.livecheckuses:github_latest, which reads the marked Latest release and skips drafts and prereleases.scripts/bump-homebrew-cask.shrewrites version, checksum, url, app, quit, zap, caveat, and livecheck from a tag's*_aarch64.dmg.The Release workflow gains a
homebrewjob afterpackage. It runs only for a stable Release, or for aworkflow_dispatchwhose sync tap tag input is set. A dry dispatch still builds packages and leaves the tap alone. An emptyHOMEBREW_TAP_DEPLOY_KEYfails that job. The package jobs can already have succeeded.The job checks out the default branch, runs the bump and
scripts/verify-homebrew-cask.sh, checks outomesser/homebrew-fidgetwith the deploy key, and runsscripts/publish-homebrew-cask.sh. A second run with the same tag commits nothing. A prerelease does not move the cask, because verify requires the pinned tag to be GitHub's latest stable Release.Homebrew only sees a top-level
Casks/directory. The installable copy stays at omesser/homebrew-fidgetCasks/fidget.rb. The canonical file stays atpackaging/homebrew/Casks/fidget.rb.README Get It and
docs/DEVELOPMENT.mdinstall withbrew install --cask omesser/fidget/fidget. Homebrew rejects a cask install from anhttpsURL, so that command is gone.Still open on #260:
Fidget_0.1.0_amd64.deband an AppImage. The AUR has no package named fidget. Landing one needsmakepkgon Arch and an AUR account.Fidget_0.1.0_x64-setup.exe.choco installneeds a nupkg on a feed, and Chocolatey does not run in this environment.How to verify
node --test tests/publish-homebrew-cask.test.jspassed here. It pushes a changed cask to two local remotes, does nothing on a second run, updates a stale tap when the canonical file already matches, and, when the default branch refuses the push, updateshomebrew-cask-bumpand still pushes the tap. A tag that is not a release exits 2 before any push.The Release job itself was not run. It needs a published Release and
HOMEBREW_TAP_DEPLOY_KEY.On Apple Silicon:
Notes
Refs #260. Pacman and Chocolatey remain, so this stays open.
Do not merge from this pass.
— Cursor agent (Coder), on @omesser's behalf.