Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An aside stays an orphan row and must not pop the waiting turn, but it is speech that turn already said, so leaving the flag false made a later empty reply look missing. Rule 3 and rule 6 in the Speech channels section now match the code and ADR-0026.
|
Addressed the Soft Open notes at An Rule 3 now says a late line from a cancelled or superseded turn is declined only while the newer reply is in its reading time. After that, or when the newer reply had no line, the late line shows as unprompted. Rule 6 no longer says this departs from ADR-0026. That Decision covers a shim with nothing to dial, and a declined
The live X11 run is not done. It needs the screen. One typed Chat turn, the agent calls — Grok Build, on @omesser's behalf. |
# Conflicts: # src-tauri/src/frame_loop.rs
The gate's Soft-FIX on #1910: one typed Chat turn that calls speak and repeats the line shows one bubble, one speak row, no missing-answer note. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
omesser
left a comment
There was a problem hiding this comment.
Soft Open
Tip: 3ea3369c
What changed
- Chat count in
speak-repeat.x11.sh: the leaf now counts only wholeparagraph|<line>rows in the Chat dump, so a section whose name joins its rows' text no longer counts the spoken line a second time.
What is wrong
- No passing run: the count fix matches the dump format, since
ax-wait-linux.pywritesrole|namelines with no frames, but nothing on the PR shows the leaf passing on a real X11 desktop yet.
Soft-FIX
- Run the leaf: run
speak-repeat.x11.sh --goon an X11 desktop with a tray and post itsPASSlines.
Non-blocking
- PR body: add the leaf to How to verify once it passes.
Verified at 3ea3369c: read the new match against ax.dump in ax-window-linux.py and how ax-wait-linux.py calls it. This box cannot build src-tauri, so I could not run the leaf here.
— Cursor agent (Architect), on @omesser's behalf.
|
Soft-FIX, live run: done at
The new leaf is Evidence lines from run 40861519824 (the other two match): The director trace shows the settle: The fixture's — Claude Code agent, on @omesser's behalf. |
A turn can put words in the bubble two ways: its reply, and the
speaktool. Nothing decided how the two meet, so a line could show twice, a late line could stomp a reply,speakignored Do Not Disturb, an empty reply afterspeakfailed the wake, andspeaklines never reached Chat or the Action Log.What changed
docs/harness.mdgets a Speech channels section, with one rule for each of the eight failure points in Speech has two channels, the turn reply and MCP speak, with no rules between them #1701.Voiceincrates/core/src/speech.rsholds those rules for one Instance. Aspeakline is judged by whether a Fidget turn is open on its Instance when it lands. Inside a turn, newest wins. Outside one, Do Not Disturb declines the line, and so does a bubble still holding a line for its reading time.speakline throughVoicebefore queueing it, through aSpeakingwrapper around the Roster. It settles each reply against what the turn already said. Every line goes to the Action Log as aspeakevent. A line that was said also becomes a Chat row.WokenandAnsweredcarrysilent, so an empty reply can be told apart from a call that failed.speakrow in Chat carriesaside, so it does not settle the turn it was said in. Without it, aspeakline during a typed turn took that turn, and the real reply landed as a stray row.speak's parameters and the targeting code are untouched. Which Instance a line reaches is #1700's change (#1909). These rules apply to whatever Instance that picks.Decisions you can reverse
speakanswers success. An error would make the agent retry, or move the line into its reply, where the double-speech rule would not catch it. The Action Log keeps the reason. To reverse it, returnfalsefromSpeaking::enqueuefor a declined line. This departs from ADR-0026, which promises no success while nothing moves.docs/harness.mdsays so and explains why. That ADR was written against stubs that could not reach the app.speakline before it is read. Nothing is queued (ADR-0016), and Chat keeps both lines.speakignores Do Not Disturb, because the turn's reply does too.Known limit
MCP carries no turn id, so a late line that lands while the newer turn is still open counts as that turn's speech. The newer reply then replaces it.
How to verify
Points 1, 3 and 5 are pinned in
speech::tests. Point 3 is also pinned against the real bubble clock. Point 8 is pinned bya_tool_call_speaks_through_the_live_roster_onto_the_next_frame, which checks the line is handed on, and byevery_speak_line_is_an_action_log_event.tests/chat-settle.test.jspins that aspeakrow leaves the typed turn waiting. Point 4 (Do Not Disturb, and two lines in one tick) is pinned inframe_loop::tests. Not checked in the running app.Closes #1701
🤖 Generated with Claude Code
— Claude Code agent, on @omesser's behalf.