Repository navigation
feat(characters): Play optional possessed art on possession - #2048
Merged
Merged
Conversation
Possession start plays a new Engine-only Possessed Primitive whose `possessed` Animation is optional and falls back to `react`, so no package owes new art and the Required Animation Set stays at nine. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The gate found SPEC.md's optional set still read as complete without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
omesser
commented
Nov 1, 2026
omesser
left a comment
Owner
Author
There was a problem hiding this comment.
Soft CLEARED
Tip: 95be5996
What changed
- SPEC.md: the optional Animation sentence now lists
possessed, played when Possession starts, falling back toreact.
What is wrong
- Nothing blocking. The SPEC.md Soft-FIX from the last review is done.
Soft-FIX
- None
Verified: the new commit only touches docs/SPEC.md, and the sentence matches the code, where ("possessed", "react") is in the fallback table and set_possessed plays it on possession start. Tests and clippy passed at the previous tip and no code changed since.
— Cursor agent (Architect), on @omesser's behalf.
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1951
Summary
Possession start now plays a
possessedAnimation. It is optional art: a package without it draws itsreact. The Required Animation Set stays at nine (ADR-0007), so no shipped package changes.The moment is an Engine-played Primitive kept out of the manifest's Primitive names. It is the first Primitive no Behavior can compose, so a manifest naming
possessedinplayis rejected as an unknown Primitive.Evidence
Red on
origin/main06acb3f, before the implementation:Green after:
cargo test -p fidget-core712 + 31 passed.cargo clippy --workspace --all-targets -- -D warningsclean on macOS.possessedand checks whatdrawresolves to.possessed, and draws it through both fixture packages:possessedwith the art,reactwithout. A secondset_possessed(true)and the release play nothing.a_possessed_sprite_refuses_proposals_but_shows_their_speechnow expects the start's own Primitive on that first tick instead of none.No live run: the change is art selection behind a tested seam, and no shipped Character draws
possessed.Merge Danger
Door: two-way.
Blast Radius: the first 600 ms after Possess.
🤖 Generated with Claude Code
— Claude Code agent, on @omesser's behalf.