Skip to content

feat(characters): Play optional possessed art on possession - #2048

Merged
omesser merged 2 commits into
mainfrom
feat/1951-possessed-animation
Nov 1, 2026
Merged

omesser merged 2 commits into
mainfrom
feat/1951-possessed-animation

Conversation

@omesser

@omesser omesser commented Nov 1, 2026 •

Copy link
Copy Markdown
Owner

Closes #1951

Summary

Possession start now plays a possessed Animation. It is optional art: a package without it draws its react. The Required Animation Set stays at nine (ADR-0007), so no shipped package changes.

crates/core/src/character.rs
  Primitive::Possessed           Engine-only, not in the manifest's PRIMITIVES
  OPTIONAL_FALLBACKS             + ("possessed", "react")
crates/core/src/engine.rs
  set_possessed                  plays Possessed on the false -> true edge
  animation_of / permitted       "possessed", allowed in any State, like react
GLOSSARY.md, docs/DEVELOPMENT.md, docs/SPEC.md
                                 possessed listed with the optional Animations

The moment is an Engine-played Primitive kept out of the manifest's Primitive names. It is the first Primitive no Behavior can compose, so a manifest naming possessed in play is rejected as an unknown Primitive.

Evidence

Red on origin/main 06acb3f, before the implementation:

character::tests::possessed_is_optional_and_falls_back_to_react ... FAILED   (draw("possessed") drew nothing)
engine::tests::possession::possession_start_plays_possessed_art_or_react ... FAILED
  left: "idle"  right: "possessed"

Green after: cargo test -p fidget-core 712 + 31 passed. cargo clippy --workspace --all-targets -- -D warnings clean on macOS.

  • The manifest test loads a fixture package with and without possessed and checks what draw resolves to.
  • The Engine test possesses a sprite, checks the Frame names possessed, and draws it through both fixture packages: possessed with the art, react without. A second set_possessed(true) and the release play nothing.
  • a_possessed_sprite_refuses_proposals_but_shows_their_speech now expects the start's own Primitive on that first tick instead of none.

No live run: the change is art selection behind a tested seam, and no shipped Character draws possessed.

Merge Danger

Door: two-way.
Blast Radius: the first 600 ms after Possess.

🤖 Generated with Claude Code

— Claude Code agent, on @omesser's behalf.

Possession start plays a new Engine-only Possessed Primitive whose
`possessed` Animation is optional and falls back to `react`, so no
package owes new art and the Required Animation Set stays at nine.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
omesser

This comment was marked as outdated.

The gate found SPEC.md's optional set still read as complete without it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@omesser omesser left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soft CLEARED

Tip: 95be5996

What changed

  • SPEC.md: the optional Animation sentence now lists possessed, played when Possession starts, falling back to react.

What is wrong

  • Nothing blocking. The SPEC.md Soft-FIX from the last review is done.

Soft-FIX

  • None

Verified: the new commit only touches docs/SPEC.md, and the sentence matches the code, where ("possessed", "react") is in the fallback table and set_possessed plays it on possession start. Tests and clippy passed at the previous tip and no code changed since.

— Cursor agent (Architect), on @omesser's behalf.

@omesser
omesser merged commit 8fb79b3 into main Nov 1, 2026
10 checks passed
@omesser
omesser deleted the feat/1951-possessed-animation branch November 1, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(characters): An optional possessed Animation that falls back to react

1 participant