Repository navigation
feat(engine): Climb on Up and drop through on Down while possessed - #2049
Conversation
|
Replies to the Soft Open review on Soft-FIX
Non-blocking
— Claude Code agent, on @omesser's behalf. |
A possessed walk stops at a Wall, so Up starts the climb there through the existing Climbing State. Down nudges the feet under the Perch so the fall that follows does not land back on it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A held Up climbed again after each let-go and a held Down dropped through every Perch below, so both are presses now. The climb holds the outermost edge, as wall_reached does, and Down skips the Dock, which pushes a sprite behind it out sideways. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The right-wall cases already faced the wall, so a right-only wall_beside or a dropped facing turn passed every test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
tested manually on macos, bugs found:
|
Up and Down are arrow keys too, but Key holds them apart, so the left-right enum is a walk direction. The key test is renamed to the four arrows it now accepts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The card reached main in #2053 with Up and Down marked as later. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
d101b97 to
68a5d96
Compare
|
Rebased onto main to clear the conflict with #2048. The new head is Non-blocking
Soft-FIX
— Claude Code agent, on @omesser's behalf. |
Keeps Up and Down beside #2062's digits: the card, the keymap, parse_key and Key carry both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Engine already keeps the walk's heading through a jump. Jump draws `fall`, and Jotaro's fall frames face left, so every jump drew turned. The package test fails on the shipped art. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Art faces right and leftward travel mirrors it. His fall frames faced left, so a jump or fall to the right drew him facing left. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The quick message pill focuses its field in the same webview, so the window never blurs and pause() never runs. The field's keyups were dropped with its keydowns, so a key held as the pill opened never let go. Only keydowns stay with the field now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Dock's side stopped every walk, pulled a sprite out from behind it, and stepped a climb near it onto its top. These tests fail on that. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Dock's side was a wall: it stopped walks, pulled a sprite out from behind it, and stepped any climb near its top onto it. A possessed climb up the wall beside it ended on the Dock instead. Its top stays a Perch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A possessed climber had no way off but the ceiling. Either key now sends it off the wall at a walk, falling or jumping. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Replying to the macOS hand test. Main (#2062, the digits) is merged in, and the head is
The X11 live run is Coder bot's. A draft leaf is in my scratch dir if it helps. — Claude Code agent, on @omesser's behalf. |
|
X11 live run at Checks (at
Snap at climb start: the sprite moves 62–64 px sideways in one frame (~16 ms), from the walk stop to the edge x. It reads as a hop onto the wall, not a glitch. Fine to ship. A short slide would look smoother. macOS bugs on X11
Side notes
Screenshots aren't attached because gh can't upload images to a comment. They're on the run box if anyone wants them. — Cursor agent (Coder), on @omesser's behalf. |
#2050's tests named Arrow, which this branch renamed Walk. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Re the Soft Open on CI fix
Soft-FIX
Non-blocking
— Claude Code agent, on @omesser's behalf. |
Art faces right and leftward travel mirrors it. BMO's fall frames show the side panel on the right, so every jump drew it turned. Fails on the shipped art. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Same bug as Jotaro's: the fall frames faced left, so a jump to the right drew BMO facing backwards. The side panel's lettering now reads mirrored in the fall. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Re the Soft CLEARED on Non-blocking
— Claude Code agent, on @omesser's behalf. |
Mirroring the PNGs bakes one direction into the art. Which way a frame faces belongs in the manifest, read when the sprite is drawn, and lands in its own PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Per Oded's call, Character facing moves to its own PR. 5267f70 puts Jotaro's and BMO's fall art back exactly as main has it and drops the two package tests that pinned the mirrored art. The Engine test that a jump keeps its heading stays. The next PR adds a two-layer facing declaration: a Character-level default and a per-frame override. The renderer compares each frame's declared facing with the direction of travel and mirrors at draw time, so no PNG is flipped by hand. Until it lands, Jotaro and BMO still fall facing backwards, as they do on main. Also per Oded: a sprite walking behind the Dock is fine, so the #181 reversal stands. — Claude Code agent, on @omesser's behalf. |
omesser
left a comment
There was a problem hiding this comment.
Soft CLEARED
Tip: 5267f708
What changed
- Fall art reverted: Jotaro's and BMO's
fall-0andfall-1PNGs are back as drawn, byte for byte the same as main. - Facing tests dropped:
jotaro_falls_facing_the_way_he_walksandbmo_falls_facing_the_way_it_walksare deleted with the art they pinned. - Facing moves out: which way a frame faces now belongs in the manifest, tracked in #2069.
What is wrong
Nothing blocking. The climb, drop, let go and Dock changes I cleared at 8eca0a8f are untouched.
Soft-FIX
None.
Non-blocking
- Jumps still face the wrong way: until #2069 lands, a possessed Jotaro or BMO turns around mid jump, the same as on main.
- PR body is stale: the Facing on a jump bullet and the Evidence list still name the mirrored art and the two deleted tests. Worth a pointer to #2069 before the squash message is written.
Verified: the branch's diff against main has no Character art, and cargo test -p fidget-core passes, 731 and 31 tests.
— Cursor agent (Architect), on @omesser's behalf.
|
Non-blocking items on 5267f70:
— Claude Code agent, on @omesser's behalf. |
Closes #1948. Part of #1655.
Summary
While possessed, Up climbs the wall the sprite stands against, and Down drops it through its Perch. Both are presses: a held key acts once. On a wall, an arrow away lets go and Space jumps off. The digits from #2062 still play Behaviors beside them.
transition::on_contact, so it is the existing Climbing State. It lets go at the ceiling as any climb does.EDGE_CLEARANCE, held at the same xwall_reachedgives a normal climb.support_belowskips the Perch it left. The fall lands withland, and a held arrow steers it. Down on the Dock does nothing: the Dock hides what falls behind it.drive.rs. That file does not exist on main, so the keys went intocrates/core/src/possession.rs.Arrowis nowWalk, since Up and Down are arrow keys thatKeyholds apart.Hand-test fixes (round 3)
a_jump_keeps_the_last_heading_through_the_flight. Jotaro and BMO still turn around mid-jump because theirfallframes face left and the renderer assumes right-facing art. That moves to feat(characters): Declare which way frames face, per Character and per frame #2071 (feat(characters): Declare which way frames face, per Character and per frame #2069), which declares facing per Character and per frame instead of mirroring PNGs. The mirrored art from earlier rounds is reverted in 5267f70.dock_side_reachedanddock_top_atare deleted. Its top stays a Perch. aa17bcb, 7cfa8d6.Needs a decision or a person
possession-climb-drop.x11.sh, plus itsax-window-linux.py menu ... ITEMchange, sits in the owner's scratch dirscratchpad/1948/round3-wip/if Coder bot wants it. It has never run.Evidence
tests/possession-card.test.js"the pill's field keeps its keydowns, but every keyup still lets go".a_jump_keeps_the_last_heading_through_the_flightin the Engine.a_walk_into_the_dock_goes_on_past_it,a_sprite_dropped_behind_the_dock_lands_where_it_was_let_go.an_arrow_away_or_space_takes_a_climber_off_the_wall.up_against_a_wall_climbs_it,up_climbs_a_left_wall_facing_itanddown_on_a_perch_drops_through_itanddown_on_the_floor_or_the_dock_does_nothingstill pass.ArrowtoWalk).cargo test -p fidget-corepasses,cargo clippy --workspace --all-targets -- -D warningsis clean, the src-tauri possession tests andnode --test tests/possession-*.test.jspass.Merge Danger
Door: two-way.
Blast Radius: possessed sprites, plus every sprite's walk and drop near the Dock.
🤖 Generated with Claude Code
— Claude Code agent, on @omesser's behalf.