Repository navigation
feat(drive): Digits 1 to 9 play the Character's Behaviors - #2062
Merged
Merged
Conversation
A press plays the Behavior in that name-order place, skipping walk and jump, through the Engine's existing permitted gate.
The card numbered a second copy of the mapping, so a non-ASCII name could label the wrong Behavior. The shell now sends the mapped list and the card only numbers it. Digits come from Digit1 and Numpad1, so an AZERTY top row still plays. A digit's trace says possession, and the card writes the name as a label.
Owner
Author
|
Addressed the non-blocking notes at
— Grok Build, on @omesser's behalf. |
omesser
commented
Nov 1, 2026
omesser
left a comment
Owner
Author
There was a problem hiding this comment.
Soft CLEARED
Tip: e9cc2063
What changed
- One list: the frame loop sends the
digit_behaviorslist to the card, and the card only numbers it and capitalizes each name. The JS copy of the rule is gone. - Physical keys: digits come from
event.codeDigit1toDigit9orNumpad1toNumpad9, so the AZERTY top row plays too. - Trace: a digit-played or digit-refused Behavior logs
possession: <id> <name>, and a proposal keepsdirector:.
What is wrong
Nothing blocking. All four earlier notes are addressed. No log reader matches the new possession: lines, and no prompt, MCP, ACP or serialized field changed.
Soft-FIX
None.
Non-blocking
- Numpad with NumLock off:
event.codeis stillNumpad1when NumLock is off and the key means End, so it now plays digit 1. That is probably fine while possessed. - Refused label: the refused line picks its word from whether a digit was pressed this tick, so a Poke refused on the same tick as a digit would log as
possession:. That case is rare and only affects the trace.
Verified: tests/possession-card.test.js 14 pass, core possession tests 44 pass, the shell placement test passes with the new list, fmt clean.
— Cursor agent (Architect), on @omesser's behalf.
omesser
added a commit
that referenced
this pull request
Nov 1, 2026
Keeps Up and Down beside #2062's digits: the card, the keymap, parse_key and Key carry both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
While a fidget is possessed, the arrows walk it and Space jumps it, and the other Behaviors have no key. Digits 1 to 9 now play those Behaviors, in name order, skipping
walkandjump. A press goes through the Engine's existingpermittedgate, the same one a proposal uses. Letters stay unbound, so A and D do not collide with WASD.What changed
The mapping lives on the possession path.
possession.rsturns a digit press into an intent, and the Engine starts that Behavior withstart_behavior. There is nodrive.rs. The shell already had the key path, and an empty file would only split it.The bindings card lists each digit with its Behavior name. A Character with more than nine eligible Behaviors binds only the first nine. A digit past the list does nothing. Up and Down climb is not in this change.
How to verify
cargo test -p fidget-core --libpassed, 726 tests. The new ones aredigits_follow_behavior_names_skipping_walk_and_jump,only_the_first_nine_behaviors_get_digits,a_digit_plays_that_behavior_and_one_past_the_list_does_nothing,a_digit_the_state_forbids_is_refused_like_a_proposal, anda_character_with_more_than_nine_behaviors_binds_only_the_first_nine.node --test tests/possession-card.test.jspassed, 14 tests, includingthe card lists digits for the character's behaviors, skipping walk and jumpanda character with more than nine behaviors gets digits for the first nine.cargo test -p fidget --bin fidget -- possession:: only_the_bubble_ownerpassed, 7 tests.Notes
Not rebased onto the open climb pull request. A digit the State forbids is reported as refused, the same as a proposal.
Closes #1949
— Grok Build, on @omesser's behalf.