Repository navigation
fix(overlay): Keep a paused Possession card in the X11 input shape - #2132
Merged
Merged
Conversation
Co-authored-by: Oded Messer <odedmesser@gmail.com>
Co-authored-by: Oded Messer <odedmesser@gmail.com>
Co-authored-by: Oded Messer <odedmesser@gmail.com>
Co-authored-by: Oded Messer <odedmesser@gmail.com>
Co-authored-by: Oded Messer <odedmesser@gmail.com>
… check executable Co-authored-by: Oded Messer <odedmesser@gmail.com>
omesser
commented
Nov 5, 2026
omesser
left a comment
Owner
Author
There was a problem hiding this comment.
Soft CLEARED
Tip: 9e9ea722
What changed
- Windows leaf shebang:
possession-live.win.ps1now opens with#!/usr/bin/env pwsh, like the other Windows leaves. The header parser skips line 1, so before this the# Scenario:line was dropped and the leaf had no indexed header. - Helper mode:
possession-live-check.shgoes from 755 to 644. Both bash leaves source it, so it never needs to run on its own, and the other helpers are 644 too.
What is wrong
Nothing blocking.
Soft-FIX
None
Non-blocking
- Live runs: a run of possession-live on a real Mac and on DESKTOP-UQIE144 is still worth doing before the leaves move out of
manual-only/.
Verified: diffed against 1598ec65, checked every reference to the helper, and ran the fidget-verify tests on Linux, all 52 passing, with the X11 and macOS possession-live fixture cases among them. The Windows fixture case only runs on Windows, so it was not run here.
— Cursor agent (Architect), on @omesser's behalf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
While Possession is paused, the overlay's X11 input shape was a 1×1 dot, so a normal click on the card fell through. The live scenario had also been named for "drive".
What changed
On X11 the input shape is now the only click-through. The sprite mask and every clickable rect, including a paused Possession card, stay applied for as long as the overlay is visible. tao's ignore-cursor call no longer replaces that shape with a dot or the whole window. This changes click-through for every X11 user, not only the scenario.
The live scenario is
possession-liveon macOS, X11, and Windows. It opens the menu the waycontrol-click-menudoes, holds Right and Space, clicks another window, and resumes with a hit-tested click on the card.How to verify
cargo test -p fidget-verify --lib -- possession_liveOne live X11 run of
possession-live.x11.shon Xvfb 1280×800 with xfwm4, after the shape fix. Before the click, the overlay's input shape held the paused card at16,16 99x78, not a 1×1 dot. The click wasxdotool mousemove --syncplusclick 1, with no--window.The full
e2e-linuxsuite passed at422331b9: https://github.com/omesser/fidget/actions/runs/42029367063e76a7d74only shortens the scenario headers so they fit the comment ceiling. It does not change the input shape.macOS and Windows were not run. #1927 stays open until those two pass three live runs. Related to #1927.
— Cursor agent (Coder), on @omesser's behalf.