Skip to content

fix(overlay): Keep a paused Possession card in the X11 input shape - #2132

Merged
omesser merged 6 commits into
mainfrom
cursor/manual-drive-scenario-032b
Nov 5, 2026
Merged

omesser merged 6 commits into
mainfrom
cursor/manual-drive-scenario-032b

Conversation

@omesser

@omesser omesser commented Nov 5, 2026 •

Copy link
Copy Markdown
Owner

Why

While Possession is paused, the overlay's X11 input shape was a 1×1 dot, so a normal click on the card fell through. The live scenario had also been named for "drive".

What changed

On X11 the input shape is now the only click-through. The sprite mask and every clickable rect, including a paused Possession card, stay applied for as long as the overlay is visible. tao's ignore-cursor call no longer replaces that shape with a dot or the whole window. This changes click-through for every X11 user, not only the scenario.

The live scenario is possession-live on macOS, X11, and Windows. It opens the menu the way control-click-menu does, holds Right and Space, clicks another window, and resumes with a hit-tested click on the card.

How to verify

cargo test -p fidget-verify --lib -- possession_live

One live X11 run of possession-live.x11.sh on Xvfb 1280×800 with xfwm4, after the shape fix. Before the click, the overlay's input shape held the paused card at 16,16 99x78, not a 1×1 dot. The click was xdotool mousemove --sync plus click 1, with no --window.

PASS: evidence in /tmp/fidget-scenario-possession-live-20261105-123751 (1827ms)

The full e2e-linux suite passed at 422331b9: https://github.com/omesser/fidget/actions/runs/42029367063

chat-close-pill-type         PASS
chat-header-narrow           PASS
control-click-menu           PASS
landing-link-click           PASS
launcher-dies-at-startup     PASS
no-compositor-clip           PASS
overlay-focus                PASS
poke-mid-climb               PASS
possession-live              PASS
question-bubble              PASS
see-through-chat             PASS
sign-in-button               PASS
thinking-row                 PASS

e76a7d74 only shortens the scenario headers so they fit the comment ceiling. It does not change the input shape.

macOS and Windows were not run. #1927 stays open until those two pass three live runs. Related to #1927.

cargo run -p fidget-verify -- scenario possession-live --go

— Cursor agent (Coder), on @omesser's behalf.

Co-authored-by: Oded Messer <odedmesser@gmail.com>
omesser

This comment was marked as outdated.

Co-authored-by: Oded Messer <odedmesser@gmail.com>
omesser

This comment was marked as outdated.

Co-authored-by: Oded Messer <odedmesser@gmail.com>
@cursor cursor Bot changed the title test(scenarios): Drive a possessed fidget live on macOS, X11 and Windows test(scenarios): Possess a fidget live on macOS, X11 and Windows Nov 5, 2026
omesser

This comment was marked as outdated.

@omesser omesser added the e2e-linux Run the live Linux e2e scenarios on this pull request label Nov 5, 2026 — with Cursor
@cursor cursor Bot changed the title test(scenarios): Possess a fidget live on macOS, X11 and Windows fix(overlay): Keep a paused Possession card in the X11 input shape Nov 5, 2026
Co-authored-by: Oded Messer <odedmesser@gmail.com>
omesser

This comment was marked as outdated.

Co-authored-by: Oded Messer <odedmesser@gmail.com>
omesser

This comment was marked as outdated.

… check executable

Co-authored-by: Oded Messer <odedmesser@gmail.com>

@omesser omesser left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soft CLEARED

Tip: 9e9ea722

What changed

  • Windows leaf shebang: possession-live.win.ps1 now opens with #!/usr/bin/env pwsh, like the other Windows leaves. The header parser skips line 1, so before this the # Scenario: line was dropped and the leaf had no indexed header.
  • Helper mode: possession-live-check.sh goes from 755 to 644. Both bash leaves source it, so it never needs to run on its own, and the other helpers are 644 too.

What is wrong
Nothing blocking.

Soft-FIX
None

Non-blocking

  • Live runs: a run of possession-live on a real Mac and on DESKTOP-UQIE144 is still worth doing before the leaves move out of manual-only/.

Verified: diffed against 1598ec65, checked every reference to the helper, and ran the fidget-verify tests on Linux, all 52 passing, with the X11 and macOS possession-live fixture cases among them. The Windows fixture case only runs on Windows, so it was not run here.

— Cursor agent (Architect), on @omesser's behalf.

@omesser
omesser merged commit 703190f into main Nov 5, 2026
10 checks passed
@omesser
omesser deleted the cursor/manual-drive-scenario-032b branch November 5, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e-linux Run the live Linux e2e scenarios on this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants