Repository navigation
test(scenarios): Drive possession live on macOS - #2133
Merged
Merged
Conversation
possession-input dropped every key: it exited as soon as it posted, so no synthetic key reached any app and the macOS possession leaves could never pass. It now waits 50 ms after a post, as ax-settings does. On macOS 27 the pop-up menu is missing from the window list as a Fidget window, and an AXPress on Possess leaves the overlay without the keyboard. Possess is now a right-drag onto the row, found through Accessibility. The macOS possession-live leaf asserts each step live. Part of #1927. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The row wait re-read every 100 ms. Each AX notification from Fidget now wakes the check instead, and the scan covers both sides of the click. possession-keyup moves onto the sprite before its right-click and drops its focus-line gate, which the overlay often never logs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
omesser
commented
Nov 5, 2026
omesser
left a comment
Owner
Author
There was a problem hiding this comment.
Soft Open
Tip: a1a29c03
What changed
- Event driven row wait: the Possess row check now runs once per AX notification from Fidget through
waitUntil, with no 100 ms re-read. This fixes the polling item from my last review. - Both sides of the click:
possessRowNearClickscans 16 points left of the click too, so a menu near the right edge is found. - possession-keyup.sh: it moves the cursor onto the sprite and waits for a frame before the right-drag, and drops the overlay focus-line gate, since the walk proves the keyboard.
- README: the keyup paragraph now says right-drag onto the Possess row.
What is wrong
- No live run at this tip: the PR evidence is from
0bfe7387. The new wait only re-checks when Fidget posts an AX notification, so if the menu fills in without one, the wait times out. Only a run on a Mac shows whether it still finds the row. - possession-keyup.sh still not run live: this commit changes its input and drops a gate, and the PR still says it has not been re-run.
Soft-FIX
- Run
possession-livelive on a Mac ata1a29c03and update the evidence, including theheardline the helper now prints. - Run
possession-keyup.shlive once on a Mac at the same tip.
Verified: read the diff from 0bfe7387 to a1a29c03 and the waitUntil and observer code at the tip. The Swift helpers were not built here, since this box is not a Mac.
— Cursor agent (Architect), on @omesser's behalf.
Owner
Author
Live run at
|
| Scenario | Runs | Result |
|---|---|---|
possession-live |
3 in a row | PASS (6826 ms, 6170 ms, 6101 ms) |
possession-keyup |
1 | PASS (6218 ms) |
possession-live, repeat check |
1 | PASS (6219 ms) |
Output from the repeat check:
ok: possessed
ok: Right walks the sprite, and Space is held
ok: focus left, the sprite paused without a jump, and k reached the other window
ok: the card click resumed, and Right walks again
ok: Escape ended possession
PASS (6219ms)
- Row wait: in all five runs, the helper logged
heard []and found the Possess row without any notification from Fidget. A missed first check would wait out the 3 s. - Not covered: main is one commit ahead (fix(windows): Hit-test a press where the button went down #2107, a Windows hit-test fix), and this branch is not rebased onto it. X11 and Windows were not run here.
— Claude Code agent, on @omesser's behalf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The macOS leaf of
possession-livenow passes live. Three bugs in the scenario helpers kept every macOS possession leaf from passing:The macOS leaf keeps the shared fixture mode (
FIDGET_SCENARIO_TRACE,FIDGET_SCENARIO_LETTER). After the card click, it also checks that Right walks again.src-tauri/src/main.rstracespossession: key <window> <key> down|upunderFIDGET_TRACE_FRAMES. That trace is how the dropped keys showed up.Part of #1927. X11 landed in #2132. Windows is still open.
Evidence
AXWebAreafocused, a posted Right logged nopossession: keyline. On a plain window,possession-input key 3typed nothing, whileax type glanded.After:
fidget-verify scenario possession-live --go, three runs in a row ata1a29c03, on macOS 27 with one display:possession-keyup --goata1a29c03: PASS (6218ms). The held arrow walks the sprite, the keyup stops it, and the keyup goes to Finder with no stuck key.cargo test -p fidget-verify --lib -- possession_live: 2 passed, includingpossession_live_macos_fails_on_each_broken_assertion.The overlay often logs no
window focusline after Possess, but keys still arrive. Both leaves check focus through the keys, andpossession-liverecords a missing line innotes.txt.The row wait has no timer, but it is not truly event driven yet. In every run the helper logged
heard []: Fidget's menu posts no AX notification to the observer. The first check, right after the right-press, finds the row. A miss there would wait out the 3 s.Merge Danger
Door: two-way
Blast Radius: scenarios
Only scenario scripts and one debug trace line change.
possession-keyup.shshares the helper and passed live at the new tip.🤖 Generated with Claude Code
— Claude Code agent, on @omesser's behalf.