Skip to content

feat(settings): Make the Completer's reasoning effort a Development setting - #656

Merged
omesser merged 2 commits into
mainfrom
feat/638-reasoning-effort-setting
Sep 13, 2026
Merged

omesser merged 2 commits into
mainfrom
feat/638-reasoning-effort-setting

Conversation

@omesser

@omesser omesser commented Sep 12, 2026

Copy link
Copy Markdown
Owner

The reasoning effort #617 hardcoded as low becomes a Development row.

What changed

  • AI_BUDDY_DIRECTOR_REASONING_EFFORT, Settings::director_reasoning_effort and
    TextField::DirectorReasoningEffort, seeded through model::env_or_file in
    dev_flags::seed — a Mutex<String> beside MCP_BIN, because the value is a
    string and not a number.
  • Development → HTTP limits carries a Composite popup of low / medium /
    high that fills in the TextField below it, the same shape as the Completer
    endpoint row from Pick the Completer endpoint from a list, or type one #465. The field is the setting; the popup is a convenience.
    Nothing validates what is typed: on llama.cpp and oMLX the value goes to the
    model's chat template, where the valid set belongs to the model file.
  • Endpoint bakes the level in at endpoint_from, like the timeout and the
    cap, and request_body sends it verbatim on both paths —
    reasoning_effort on chat-completions, reasoning.effort on Responses.
  • Blank, and no variable, still sends low. Not "send nothing", which would
    give back the 17.5% lost-wake rate feat(director): Ask chat-completions for low reasoning effort, and drop it when refused #617 measured away.

Why only three in the picker

They are the only values every documented host takes. OpenAI adds
none/minimal/xhigh/max, xAI has xhigh but not max, Ollama has max
but not xhigh. The free-text field is what covers the rest.

The two traps

  • completer_retargets has a clause for the new field, so an Apply reaches
    the running Director rather than only the file.
    a_changed_reasoning_effort_retargets covers it. The rebuild is also the
    whole of takes_effort's reset path, which is now recorded in a comment
    rather than written as code.
  • A host that takes low and refuses high still latches the field off for
    the session — deliberately, rather than caching a server's validation rules.
    The trace_director retry line now names the value that cost it:
    retrying without reasoning_effort=high.

AnyCompleter::Http is boxed: the new field pushed Endpoint past clippy's
large_enum_variant threshold.

How to verify

cargo test --workspace, cargo clippy --all-targets -- -D warnings,
cargo fmt --all -- --check, node --test tests/ — all pass. New tests cover
the description and its placeholder, the env-frozen row and picker, seeding and
what blank means, the retarget clause, both request shapes verbatim, the level
on the wire out of Endpoint::post, and the retry line.

By hand: Settings → Development → HTTP limits, pick or type a level, then
AI_BUDDY_TRACE_DIRECTOR=1 shows it on the next wake. GTK and Win32 could not
be compiled here (macOS); the Win32 port skips composite popups as it already
does for the Base URL picker, so Windows gets the field and not the picker until
#461.

Closes #638

— Claude Code agent, on @omesser's behalf.

🤖 Generated with Claude Code

omesser and others added 2 commits September 13, 2026 12:26
…etting

The level #617 hardcoded as "low" becomes a Development row: a picker of
low/medium/high plus a free-text field, seeded through
AI_BUDDY_DIRECTOR_REASONING_EFFORT. Blank still sends "low", on both the
chat-completions and the Responses paths.

Closes #638

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ENDPOINT_CUSTOM is now PICKER_CUSTOM: the reasoning-effort picker rests on
the same title, and it names no endpoint.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@omesser
omesser force-pushed the feat/638-reasoning-effort-setting branch from d8545bd to baba3ef Compare September 13, 2026 09:27
@omesser
omesser merged commit 3a0f86d into main Sep 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(settings): Make the Completer's reasoning effort a Development setting

1 participant