Repository navigation
refactor(core): Compact Director and Character comments - #807
Merged
Merged
Conversation
Part of #747 slice 2. Comment-only. Co-authored-by: Oded Messer <odedmesser@gmail.com>
This was referenced Sep 17, 2026
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Slice 2 of #747 (part 3 of #744).
director.rsandcharacter.rsstill carried restatement, issue-history narration, and blocks over the 3-line ceiling. A later reader should get the why without the audit log.#745 lands last because it quotes this source. This PR compacts to the bar in #744.
What changed
Comment-only. Two files. Public one-line summaries stay. Restatement and history go. Issue numbers drop where the fact stands without them.
Three blocks stay over the ceiling, each a named #744 exception.
director.rsmodule doc (16 lines).//!orientation. Untouched.character.rsmodule doc (64 lines).//!orientation, including the```textTOML exemplar and its tag. Untouched.character.rsTrigger(12 lines). Theponytail:marker (no time-of-day condition) left whole.Out of scope.
engine.rs. Slice 1, a separate PR.character/manifest.rs,character/resolve.rs,dispatch.rs,roster.rs,scheduler.rs. Still in open feat(engine): Land a dropped Prop on a Perch #689.docs/agents/comments.mdstill quotes the old five-linePERSONALITY_LIMITblock. That requote is #745.How to verify
No code line changes. Over
git diff -U0 origin/main -- crates/core/src/director.rs crates/core/src/character.rs, every added or removed line is a comment or blank. Local count of non-comment changed lines was 0.Tests, same names.
cargo test -p ai-buddy-core. 510 passed (487 lib + 23character_packages). Pass list sorted against the pre-edit list. Identical.node --test tests/chat-composer-limit.test.js tests/comment-census.test.js. 10 passed.CHAT_LIMITfirst-match is still the real const.python3 scripts/make-character-gallery.py --self-check. 9 Required Animations, defaults fps=8 scale=4 weight=10.cargo clippy --workspace --all-targets -- -D warnings. Green.pre-commit run --files crates/core/src/director.rs crates/core/src/character.rs. Green, including the new-block ceiling hook.Notes
Please add the
windowslabel so the Windows job runs tests, not lint-only.Part of #747. Does not close it. Slice 1 (
engine.rs) and the #689 follow-up remain.— Cursor agent (Coder), on @omesser's behalf.