Skip to content

refactor(core): Compact Engine comments - #808

Merged
omesser merged 1 commit into
mainfrom
cursor/compact-core-engine-comments-7444
Sep 17, 2026
Merged

omesser merged 1 commit into
mainfrom
cursor/compact-core-engine-comments-7444

Conversation

@omesser

@omesser omesser commented Sep 17, 2026

Copy link
Copy Markdown
Owner

Why

Slice 1 of #747 (part 3 of #744). engine.rs was the heaviest comment file in core (1,193 comment lines, 114 blocks over 3). Restatement and issue-history narration buried the why.

#745 lands last because it quotes source. This PR compacts to the bar in #744.

What changed

Comment-only, one file. Public one-line summaries stay. Restatement and history go. Issue numbers drop where the fact stands without them. #177 stays on permitted (the #744 worked example).

File Code Comments before after >3ln before after Ratio before after
engine.rs 5195 1193 814 114 3 23.0% 15.7%

Three blocks stay over the ceiling, each a named #744 exception, and none of them was rewritten.

  • Module doc (6 lines). //! orientation.
  • PRIMITIVE_MS (10 lines). ponytail: marker, left whole.
  • a_short_sample_wobble_does_not_yank (5 lines). Bound that looks arbitrary. #98 ride poll vs yank gate. Left whole.

Out of scope.

How to verify

No code-line changes. Sequence of non-comment, non-blank lines against origin/main is identical (5,195). Trailing // Start facing left. on one assignment was a restatement and was deleted. The assignment stayed.

Tests, same names.

  • cargo test -p ai-buddy-core. 510 passed (487 lib + 23 character_packages). Pass list sorted against the pre-edit list. Identical.
  • cargo clippy --workspace --all-targets -- -D warnings. Green.
  • pre-commit run --files crates/core/src/engine.rs. Green, including the new-block ceiling hook.

Notes

Please keep the windows label so the Windows job runs tests, not lint-only.

Part of #747. Does not close it. Slice 2 is #807. The #689 follow-up remains.

— Cursor agent (Coder), on @omesser's behalf.

Open in Web Open in Cursor 

Part of #747 slice 1. Comment-only.

Co-authored-by: Oded Messer <odedmesser@gmail.com>
@omesser omesser added the windows Run the Windows compile job on this pull request label Sep 17, 2026 — with Cursor
@cursor

cursor Bot commented Sep 17, 2026

Copy link
Copy Markdown

Ready for @omesser.

CI is green (ubuntu, macos, windows). GitHub reports MERGEABLE / CLEAN, the branch contains main, and there are no review threads. Not merging.

— Cursor agent (Coder), on @omesser's behalf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

windows Run the Windows compile job on this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants