Repository navigation
refactor(core): Compact Engine comments - #808
Merged
Merged
Conversation
Part of #747 slice 1. Comment-only. Co-authored-by: Oded Messer <odedmesser@gmail.com>
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Slice 1 of #747 (part 3 of #744).
engine.rswas the heaviest comment file in core (1,193 comment lines, 114 blocks over 3). Restatement and issue-history narration buried the why.#745 lands last because it quotes source. This PR compacts to the bar in #744.
What changed
Comment-only, one file. Public one-line summaries stay. Restatement and history go. Issue numbers drop where the fact stands without them.
#177stays onpermitted(the #744 worked example).Three blocks stay over the ceiling, each a named #744 exception, and none of them was rewritten.
//!orientation.PRIMITIVE_MS(10 lines).ponytail:marker, left whole.a_short_sample_wobble_does_not_yank(5 lines). Bound that looks arbitrary.#98ride poll vs yank gate. Left whole.Out of scope.
director.rsandcharacter.rs. Slice 2, refactor(core): Compact Director and Character comments #807How to verify
No code-line changes. Sequence of non-comment, non-blank lines against
origin/mainis identical (5,195). Trailing// Start facing left.on one assignment was a restatement and was deleted. The assignment stayed.Tests, same names.
cargo test -p ai-buddy-core. 510 passed (487 lib + 23character_packages). Pass list sorted against the pre-edit list. Identical.cargo clippy --workspace --all-targets -- -D warnings. Green.pre-commit run --files crates/core/src/engine.rs. Green, including the new-block ceiling hook.Notes
Please keep the
windowslabel so the Windows job runs tests, not lint-only.Part of #747. Does not close it. Slice 2 is #807. The #689 follow-up remains.
— Cursor agent (Coder), on @omesser's behalf.