Repository navigation
money: implement #89 frontend design - #148
Merged
Merged
Conversation
michielbdejong
force-pushed
the
claude/impl-89-money
branch
from
September 24, 2026 16:19
942bf19 to
8980930
Compare
michielbdejong
force-pushed
the
claude/impl-89-money
branch
from
September 24, 2026 18:01
8980930 to
69b10d4
Compare
This was referenced Sep 24, 2026
Closed
…ild) (M-1) Adds integrations/money/app/: a DOM-free controller with loading, empty, populated and error states over the Bank transactions table the host points the app at, a per-plugin copy of the host store types, a fake store shaped after hostStore.ts (rows outside the app are not writable), and a reproducible one-module build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The --pl-* token map with light fallbacks over the host's --t-* theme, derived --pl-pos and Money tints, and DOM builders for .pl-header, .pl-pill (the status live region), .pl-conn, .pl-empty, .pl-banner, buttons, chips, tabs and the detail panel (region when docked, modal dialog otherwise), plus focus keeping across re-renders and a Tab trap. Kept in its own folder so it can move to a shared kit later; nothing in it knows about money. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
formatAmount formats the amount string through Intl.NumberFormat v3 when the engine formats strings exactly (detected once), and otherwise through a BigInt integer part with the fraction spliced in; both paths are tested with 12345678901234.56789, -0.00001, JPY and BHD. Sums reuse parser.ts's units(); a source check keeps Number()/parseFloat out of amounts.ts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… (M-4) Account switcher (account + currency), search over description and reference, period chips (this month, last month, this year, custom), direction and Uncategorised filters, a day-grouped ledger (captioned table with rowgroup day headers at >=560px, a list of buttons below), 200 rows per window with Show earlier transactions, a per account + currency strip that never sums across currencies, and the no-results state. The table subscription shows rows from a new import without a reload. Adds a Playwright screenshot harness over the fake store. Render budget, measured in Chromium through the harness (500 rows, 200 rendered): first render 32-73 ms, filter re-render 43-76 ms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
money-category (free text) and money-note in the Bank transaction class's recommends, never written by the importer: a reimport of the same statement after annotating a row proposes nothing and leaves both values alone. plugin.js rebuilt with the README's esbuild command. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Read-only 'From your bank' fields and the verbatim narrative; category (a text field suggesting categories already used) and note saved on change through resource.set/remove + save(), with Saving/Saved in the footer and an inline alert with Retry that keeps the typed text. A docked region at >=900px, a modal drawer at 560-899px and a full-screen sheet below; Escape closes and returns focus to the row, arrow keys move between rows, Tab stays inside modals. At the pinned host the save is refused while the app is a view of the importer's table (hostStore.ts only lets an app write beneath itself); the detail says so instead of failing silently. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Parser, camt.053 reader and importer throw StatementError with a stable code and the data a UI needs (BALANCE_MISMATCH with opening, entries sum, expected and actual closing; OVERLAP_WITHOUT_REFERENCES; REPEATED_ and CONFLICTING_REFERENCE; JSON_NARRATIVE with a count; INVALID_FIELD with tag and MT940 line; FILE_TOO_LARGE; TOO_MANY_ENTRIES; MISSING_BALANCE; NOT_A_STATEMENT). Messages are unchanged, so the host shows the same text. Identities and fingerprints move to identity.ts so the Money app's preview uses the importer's own function. plugin.js rebuilt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rtial) Choose or drop a statement file: it is size-checked before reading, decoded as UTF-8 or Windows-1252 like the host does, read with the same readers, and compared with the table through the importer's own identity function. The sheet ticks Read file, Check balances and Compare, then shows one reconciliation card per statement and New / Already imported / Blocked tabs, or a designed banner per error code (balance figures for BALANCE_MISMATCH, In your table / In this file for a changed transaction), with the reader's message under Technical details and focus on the banner title. Applying needs a host op (issues.md M-8) the pinned host lacks, so the preview says to import the same file from the importer's Import tab and the Import button stays disabled. The controller takes an ImportPort for when such an op exists; tests exercise that path with a fake. The finder for bank-fingerprint looks it up by shortname, since bankingSchema() does not list it on the row class. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
One row per statement the table's rows came from (format, account, currency, bank-statement number): period, format, in/out and entries, newest first; a list at narrow widths. Selecting one shows its transactions through a removable Statement filter chip. Opening and closing balances and import dates need stored statements (M-7), which this PR does not add; the tab says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
axe (via the screenshot harness, --axe) reports no serious or critical findings on any frame at 360, 720, 900 and 1200 px, light and dark, after two fixes: the narrow ledger is now a heading plus a list per day (no presentational items inside a list), and the balance difference uses a darker mix of the alert colour on its tinted banner. Measured --pl-pos contrast: 7.53:1 on #fff, 7.76:1 on #000. Adds the '?' shortcuts popover; shortcuts stay off while typing in a field. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JS through esbuild's minify, and both embedded stylesheets through
esbuild.transform(css, { loader: 'css', minify: true }) at build time,
per the owner's bundle-size rule. Measured 82,579 bytes; the build test
limit is 91,000 (measured plus about 10%).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
README: what the app does, what the pinned host does not let it do yet (apply an import, write annotations to the importer's table, install from the catalog), and the harness commands. The importer's e2e passed against 11264e83e with the rebuilt plugin.js on a fresh lane store; a store kept from earlier runs makes the spec fail on plain origin/main too. DESIGN.md records the measured --pl-pos contrast. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…table A new test block in e2e/money.spec.ts (the importer's own test is unchanged): set up the importer and import the synthetic MT940, install the built app test-side as an App that renders bank transactions, add it through the table's Add view menu, and check the ledger, the detail with the host's refusal of the category save (the table is not under the app), and the in-app check (nothing new; a changed transaction blocks). Passed against 11264e83e on a fresh lane store. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The spec found the Bank statements card by name, so a lane store kept from an earlier run (or an earlier test in the same run) listed two and the strict locator failed. Both tests now match the content-addressed release id that the publish returned. Test-only change; passes on a fresh store and twice in a row on a reused one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
getMany loads ledger rows 100 at a time (errors in place are skipped); getTheme/onThemeChange set color-scheme from the host's colorScheme; --pl-pos takes --t-color-success; the import preview's note offers 'Open the importer' through openResource. All feature-detected: the fake store models both the current and an older host, and tests cover both. The importer-run, table-write and multi-class Set up items are not in this pin, so their fallbacks stay. Measured --pl-pos contrast with the host's success colour: 5.34:1 light, 9.31:1 dark. Bundle 83,637 bytes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ble (M-7) The destination gains tables.statements (atomic-server#1768): an Imported statements table of bank-statement-record rows with account, currency, number, period, reconciled opening and closing balance, entry count, format and the date first imported. plugin.ts writes one append-only row per parsed statement beside its transactions, identified by format, account, currency, number and period, so a reimport proposes nothing. config.required gains tables: an importer set up before this pauses until Set up runs again, which adds only the missing table. The 'previously imported transactions skipped' count stays per transaction. plugin.js rebuilt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…, M-11, M-12) Uses the candidate11 host (bc39dac4b), each call feature-detected: - getData().tables.statements: the strip shows the latest closing balance that ends in the period with its date (in/out and net otherwise, never a computed balance); the Imports tab lists stored statements with opening -> closing, entries and import date, and falls back to rows. - rowAccess/requestRowAccess (#1788): the detail says editing needs permission, saving asks in the host's bar while the typed text stays, a refusal is shown with Ask again; with a grant, category and note save. - importer.run (#1774): Import N transactions hands the checked file to the importer and its host review; cancelled returns to the preview, blocked shows the importer's errors. Older hosts keep the pointer to the importer's Import tab. The fake store models the current and an older host; the bundle limit is 98,000 (measured 88,741). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ids not JSON-shaped
The app test now adds Money as a read-only view, imports from inside the
app through importer.run and the host's review (Apply 3 changes: two
transactions and their statement), checks the strip's closing balance
and the Imports tab, clicks the preview's New/Already imported tabs, and
saves a category after clicking the host bar's 'Allow editing' (the
first test of atomic-server#1788). The importer test counts the
statement row.
Statement identities are no longer a flat JSON array of strings, which
legacy storage read as a resource array, so the host refused the write
('did not preserve its source datatype'). After an applied import the app
reads the tables again instead of relying on the subscription alone.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
michielbdejong
force-pushed
the
claude/impl-89-money
branch
from
September 25, 2026 10:17
69b10d4 to
a1d3c52
Compare
The tabs scrolled away with a long list inside the sheet, and in a frame taller than the window a click on them landed on the sheet's body (the click in the screencast). They now stay at the top of the sheet's scroll area. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
michielbdejong
marked this pull request as ready for review
September 25, 2026 10:33
michielbdejong
added a commit
that referenced
this pull request
Sep 29, 2026
money 0.3.0: publish the Money app (disabled), lanes note, READINESS (#148)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For users
Money: your bank transactions, readable and in your own hands
Money turns the statement files you download from your bank into one clear overview of what came in and what went out. You export a statement from your bank as MT940 or camt.053, the formats banks such as bunq, ING, Rabobank and ABN AMRO offer, and drop it on Money. Money checks it, shows you what it will add, and imports it once you confirm. Your data stays in your own Atomic Server: nothing is sent to your bank or to anyone else.
What you get
How it works
Good to know
Part of #89. Implements the Money frontend from
integrations/money/design/(design PR #107), in the order ofdesign/issues.md. Everything is insideintegrations/money/.Plugin shape
A drive app at
integrations/money/app/(shape 1 in AGENTS.md), as DESIGN.md §1 describes:view({ root, store }), one ES module built byapp/build.mjs, plain DOM, no stylesheet file. The sandbox importer (plugin.ts, shape 2) stays in the same package and stays the only writer of imported bank fields. The shapes are not mixed: the app never runs in QuickJS. It imports the importer's pure readers (statement.ts,parser.ts,camt053.ts, and the newidentity.ts) so its in-app check follows the importer's rules exactly.The app is a view of whichever table the host points it at (
store.getData()): the importer's Bank transactions table, added through that table's Add view menu. It makes nostore.proxycalls and has no connect or consent code, so it does not overlap with #54 phase 2 (#142). The branch is rebased on main at pinbc39dac4b(candidate11), which has the host changes Money was waiting for: #1768, #1774 and #1788.issues.md items
hostStore.ts; reproducible build; README paragraphapp/ui/(css.ts"PLUGIN CSS",components.ts,dom.ts,focus.ts), with no Money code in it, so it can move to a shared kit later. Token and class names as in DESIGN.md §4; buttons, chips, tabs and the panel use apl-prefix too (pl-btn,pl-chip,pl-tabs,pl-panel)12345678901234.56789,-0.00001, JPY and BHD. Totals useparser.tsunits(), and a source check keepsNumber()outmoney-category(free text, as the design assumes) andmoney-noteare in the class'srecommends. The importer never writes them, and a reimport proposes nothing and leaves them alone (test).plugin.jsrebuiltnonethe detail says editing needs permission and offers Allow editing. Saving asks in the host's bar (requestRowAccess) and shows "Waiting for you to allow editing…" with the typed text kept.deniedshows the reason and Ask again. The host E2E clicks the real "Allow editing" and checks the category after a reloaddestination.tables.statements(#1768): an Imported statements table ofbank-statement-recordrows holding account, currency, number, period, opening and closing balance, entry count, format and import date. There is one append-only row per statement, and a reimport proposes nothing.config.requiredgainstables, so an importer set up earlier pauses until Set up runs again, which adds only the missing table. The statement identity is deliberately not JSON-shaped: a flat JSON string array was read back as a resource array, and the host refused the writestore.importer.run)errors.tsStatementErrorwithcodeanddata(BALANCE_MISMATCH, OVERLAP_WITHOUT_REFERENCES, REPEATED_REFERENCE, CONFLICTING_REFERENCE, JSON_NARRATIVE with a count, INVALID_FIELD with tag and MT940 line, plus FILE_TOO_LARGE, TOO_MANY_ENTRIES, MISSING_BALANCE and NOT_A_STATEMENT). Messages are unchanged. OVERLAP's data carriesoverlappingDate(value date of the earlier row) instead ofearlierPeriod, because the earlier period is not stored (M-7). CHANGED_TRANSACTION is computed in the app, not byimportRecordsstore.importer.run. The host shows its bar and its own review, and nothing is written before Apply. A cancelled review returns to the preview, and a blocked one shows the importer's errors. On an older host, Import stays disabled and the note points to the importer's Import tab (with Open the importer whereopenResourceexists). The preview's New / Already imported tabs now stay pinned at the top of the sheet (see item 5 below). No Worker (see decisions)--pl-poscontrast is 7.53:1 on #fff and 7.76:1 on #000 (recorded in DESIGN.md). Keyboard:/, ↑/↓, Enter, Esc,i, and a?popovermoneybird/is not touchedHost APIs (feature-detected)
Where the app had fallbacks, it now uses the new host APIs, each feature-detected so an older host still works. The fake store models both hosts, and unit tests cover both paths.
getMany: ledger rows load in batches of 100, several in flight. An entry that comes back as an error is skipped.getTheme/onThemeChange: the host'scolorSchemesetscolor-schemeon the app root, for native controls and scrollbars, and follows a switch.--t-color-success: used for money in, with the earlier colour mix kept as the fallback. Contrast measured 5.34:1 on #fff and 9.31:1 on #000.openResource: the import preview's note ("Apps can't run the importer yet") gets an Open the importer button.getData().tables,importer.run,rowAccess/requestRowAccess(candidate11): see M-6, M-7 and M-10. Each of these also falls back on an older host.Item 5, the preview tabs that wouldn't click in the screencast: this was a real bug. With a long list, the tabs scrolled away inside the sheet's body. In a frame taller than the window, a click on them then landed on the body. The tabs are now sticky at the top of the sheet. The screencast now clicks them, and so does the host E2E.
Decisions
bunq …4567 89). Other identifiers are left as they are.€850.00, not the mockups'€ 850.00.<select>styled like the design, not a custom listbox.bank-fingerprint:bankingSchema()does not list it on the class, so the app finds it by shortname in the class's own ontology. It needs it to detect changed transactions.esbuild.transform(css, { loader: 'css', minify: true }). The bundle measured 88,741 bytes; the build-test limit is 98,000.Needs outside this PR
integrations/catalog.json: a catalog entry and a publishedapps/money/<version>/ui.jsso the app installs from the Integrations page. The e2e installs it test-side. The existingmoneyentry'sversionmust matchpackage.jsonif the importer version is bumped.plugin.jschanged (statements table,tablesinconfig.required) but stays at 0.2.0 here. The owner handles the version bump and the catalog after merge.integrations/lanes.json: the money note describes the e2e contents and could mention the new Money app test. No tier change is needed: certify already runs money's typecheck and unit.integrations/READINESS.md: a row for the Money app (drive app, host E2E as a table view, with import and row editing through the host).money.spec.tspublishes a release on every run and used to find the "Bank statements" card by name. On a lane store kept from an earlier run it then failed, on plain origin/main too, with a strict-mode error: two "Unverified" releases. Both tests now pick the card by the content-addressed release id that the publish returned. This is a test-only change, and the connect/consent steps are untouched. I did not see the 10 slocator.clicktimeout reported on money: frontend design, mockups and implementation issue drafts (#89) #107.How I tested
node integrations/tooling/run-lane.mjs money --tier typecheckand--tier unit: passed. Unit is 158 tests across 10 files: parser, camt, plugin, amounts, ledger, check/import states, controller, UI components and jsdom views.node integrations/tooling/certify.mjs --layer js: money, notion and pets passed. Reproducibleplugin.js.oxlint and
oxfmt --check integrations: clean.tsc -p integrations/tsconfig.e2e.json: clean.run-lane.mjs moneytypecheck, unit and e2e against a locally builtbc39dac4bbinary: all passed on a fresh lane store, then twice more in a row on the same reused store (e2e 2 of 2 each time).Screenshots from
node integrations/money/app/harness/screenshots.mjs --axe, rendered with the fake store in Chromium using the host's light and dark--t-*values from mockups.html. Frames:Compared by eye with mockups.html, they match in structure and tokens. The remaining differences are intentional: the strip shows net where no statement ends in the period, the status copy differs, and the Imports tab has no import-name column. Output goes to
app/dist/screenshots/, which is gitignored.🤖 Generated with Claude Code