Skip to content

money 0.3.0: publish the Money app (disabled), lanes note, READINESS (#148) - #197

Merged
michielbdejong merged 9 commits into
mainfrom
claude/money-148-followups
Sep 29, 2026
Merged

michielbdejong merged 9 commits into
mainfrom
claude/money-148-followups

Conversation

@michielbdejong

Copy link
Copy Markdown
Contributor

Follow-ups for #148. Draft: it waits for #171 (both rewrite READINESS.md and catalog.json) and #179 (the candidate14 pin, which fixes the money e2e's "New app" step, ontola/atomic-server#1846).

  • Importer 0.2.0 → 0.3.0. money: implement #89 frontend design #148 added the statements table and made tables a required config key. An importer set up before 0.3.0 therefore pauses until Set up runs again, which is more than a patch. plugin.js was rebuilt with the README's esbuild command; only its version string changed.
  • Catalog. The money entry now also carries the drive app: apps/money/0.3.0/ui.js (88,968 bytes) and its integrity. enabled stays false. The app and the importer share one version, because apps.mjs resolves the app by shortname and takes the version from integrations/money/package.json.
  • Notes. A lanes.json note on the money lane, and READINESS rows: the importer at 0.3.0, plus a new row, "Money, drive app (enabled: false)".

Known limit, written into the catalog copy, README and READINESS. At pin 2567fc30b, a catalog Install doesn't give a working Money app:

  • createApp gives the app its own row class and an empty table.
  • Add view on the importer's table offers only apps whose renders lists that table's class (useDriveApps.ts appsForClass).
  • store.importer.run refuses an app that isn't shown as a view of an importer's table.

The e2e gets round this by adding the class to renders test-side. This looks like what #177's option 4 addresses: views bound to shared row classes, bank-transaction-v1.

Checks run locally:

  • certify (money, notion, pets);
  • money unit tests: 158/158;
  • apps.mjs check;
  • tooling tests on Node 22: 218/218;
  • the e2e typecheck;
  • oxfmt, and oxlint with 0 errors;
  • the money e2e at 2567fc30b: 2/2, once. Not yet run at candidate14.

🤖 Generated with Claude Code

Michiel de Jong and others added 4 commits September 29, 2026 13:15
#148 changed plugin.js's behaviour at 0.2.0: an Imported statements table
through destination.tables (atomic-server#1768) and `tables` in
config.required, so an importer set up earlier pauses until Set up runs
again. Only the manifest version changes here; plugin.js is rebuilt with
the README's esbuild line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The money entry gains the drive app's app-module (apps/money/0.3.0/ui.js,
written by apps.mjs write) and row names, at the importer's version, with
enabled: false for the soft launch. The copy states that a catalog Install
does not yet give a working Money app: at the pin it creates a table of its
own with no importer, and the importer's table offers under Add view only
apps rendering its class.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The lane note describes the app test and the known host bug
(atomic-server#1846, fixed by #1847 in candidate14 1432e244a). READINESS
gets a Money drive app row and the importer row's 0.3.0 statements table.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@michielbdejong

Copy link
Copy Markdown
Contributor Author

Michiel's decision: a catalog-installed Money app not attaching to the importer's table is handled as part of #177 option 4 (the shared bank-transaction-v1 class), not as a separate host change.

Michiel de Jong and others added 3 commits September 29, 2026 16:25
READINESS.md conflict: kept #197's matrix (the Bank statements row split
into importer and Money drive app rows) and took main's one change to it,
the Willow drop row's catalog id (`willow-drop`).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The lane note, the READINESS Money drive app row and the README's
Verified section said the second e2e test can fail on #1846 at the pin.
main now pins candidate14 1432e244a, which has atomic-server#1847; both
money e2e tests passed once against it on 2026-09-29 (published e2e
image).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Resolve integrations/READINESS.md: take main's rewritten matrix (#171:
calendar, timesheets, issue-tracker and notion rows) and replace its
single Bank statements row with this branch's importer and Money drive
app rows. The Money row's label drops `enabled: false` to match main's
label style; its install column already says so. Realigned with oxfmt.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@michielbdejong
michielbdejong merged commit 51a6486 into main Sep 29, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant