Skip to content

CI follow-ups from #43: overlays-ci dispatch false green, path-filter test, §4 status - #236

Merged
michielbdejong merged 2 commits into
mainfrom
claude/issue-43-ci-followups
Oct 1, 2026
Merged

michielbdejong merged 2 commits into
mainfrom
claude/issue-43-ci-followups

Conversation

@michielbdejong

@michielbdejong michielbdejong commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Closes #43.

I checked each item in #43 against main at bcfab35. Most were already done or handed off to their own issues. This PR does the one open item that was worth doing:

  • §2, the gate's false green on workflow_dispatch. ci.yml, devonian-ci.yml, reflector-ci.yml and syncables-ci.yml were already fixed. overlays-ci.yml still ran dorny/paths-filter on workflow_dispatch (if: github.event_name != 'merge_group'). That event has no pull_request diff, so the filter could come back empty, skip validate and leave a green run that tested nothing. It now gates like the other four: the filter runs on pull_request only, and the output is forced to 'true' otherwise.
  • Regression test. A new test in integrations/tooling/workflow.test.mjs, "path filters run on pull_request only; other events run everything", checks this for every workflow that uses paths-filter. Run against the old overlays-ci.yml it fails with overlays-ci.yml:43: run paths-filter on pull_request only.
  • integrations/PARALLEL_LANES.md §4 status was stale. It said record.mjs and the moneybird fixture were not started. In fact todoist has a recorder and a replay scenario waiting on a live recording (issue-tracker: record a todoist mock-proxy fixture #46), and moneybird (synthetic) and notion (authored) have registered fixtures, neither of them recorded. Still not started: recorded api/ pages and the drift guard.

Board item: willow.spec.ts:95 on #118. This was not a one-off. In run 36834223383 it failed 3 of 4 Playwright attempts across the two job attempts, each time stuck on /app/integrations for 60 s after Install, with no server log after the click. I couldn't find the cause:

I found no test-side race: the spec waits exactly like plugin-routes, fediverse and OCM. I also have no host-side evidence, so I filed no atomic-server issue. Instead, the wait is now leftReview(): on timeout it reports the open dialog's text and any toasts. That tells apart the three ways the store keeps you on the review: an inline refusal, a toast.error, or a dialog closed without navigating. I checked the failure message by forcing the timeout locally.

The rest of #43:

Item State
§1a pets card detaches The pets lane is green (for example on #118).
§1b first green run Obsolete.
§3a fixtures Registry done in #48. moneybird #45 and notion #47 are closed. todoist #46 is open, waiting on a maintainer recording. Recordings and the drift guard are not started (now recorded in §4 above).
§3b Clockify e2e #44 closed. The timesheets lane has an e2e tier.
§3c money tiers #45 closed.
§4a, §4b, §4c Decisions, not CI work. #52 (closed) and #40 (open) carry them.

Checks run: node --test integrations/tooling/workflow.test.mjs (14/14 pass), run-lane.mjs willow --tier e2e (passes), oxlint and oxfmt on the changed files (clean).

🤖 Generated with Claude Code

https://claude.ai/code/session_011qzxyw4dG5n7Fx8TocuWfp


Generated by Claude Code


Generated by Claude Code

claude added 2 commits October 1, 2026 08:57
… filter (#43 §2)

overlays-ci was the one path-gated workflow still running dorny/paths-filter
on workflow_dispatch, where there is no pull_request diff: an empty result
skipped validation and left a green run that tested nothing. It now gates
like the other four (filter on pull_request only, output forced on
otherwise), and workflow.test.mjs asserts that for every workflow that uses
paths-filter.

PARALLEL_LANES.md's §4 status was stale: todoist has a recorder waiting on a
recording (#46), moneybird and notion have registered unrecorded fixtures.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011qzxyw4dG5n7Fx8TocuWfp
On #118 (run 36834223383) willow.spec.ts:95 timed out on /app/integrations
after Install in 3 of 4 attempts, with no server log after the click. It
passed in 9 local runs at the same pin and had no retries in the 18 CI runs
before it, and the trace artifact isn't readable from a cloud session. The
store keeps the user on the review in three ways (an inline refusal, a
toast.error, a dialog closed without navigating), so the timeout now
reports the open dialog's text and any toasts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011qzxyw4dG5n7Fx8TocuWfp
@michielbdejong
michielbdejong merged commit 5781594 into main Oct 1, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follow-ups after the per-plugin CI lane split (#37, #38)

2 participants