Repository navigation
CI follow-ups from #43: overlays-ci dispatch false green, path-filter test, §4 status - #236
Merged
Merged
Conversation
… filter (#43 §2) overlays-ci was the one path-gated workflow still running dorny/paths-filter on workflow_dispatch, where there is no pull_request diff: an empty result skipped validation and left a green run that tested nothing. It now gates like the other four (filter on pull_request only, output forced on otherwise), and workflow.test.mjs asserts that for every workflow that uses paths-filter. PARALLEL_LANES.md's §4 status was stale: todoist has a recorder waiting on a recording (#46), moneybird and notion have registered unrecorded fixtures. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011qzxyw4dG5n7Fx8TocuWfp
On #118 (run 36834223383) willow.spec.ts:95 timed out on /app/integrations after Install in 3 of 4 attempts, with no server log after the click. It passed in 9 local runs at the same pin and had no retries in the 18 CI runs before it, and the trace artifact isn't readable from a cloud session. The store keeps the user on the review in three ways (an inline refusal, a toast.error, a dialog closed without navigating), so the timeout now reports the open dialog's text and any toasts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011qzxyw4dG5n7Fx8TocuWfp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #43.
I checked each item in #43 against
mainat bcfab35. Most were already done or handed off to their own issues. This PR does the one open item that was worth doing:workflow_dispatch.ci.yml,devonian-ci.yml,reflector-ci.ymlandsyncables-ci.ymlwere already fixed.overlays-ci.ymlstill randorny/paths-filteronworkflow_dispatch(if: github.event_name != 'merge_group'). That event has no pull_request diff, so the filter could come back empty, skipvalidateand leave a green run that tested nothing. It now gates like the other four: the filter runs onpull_requestonly, and the output is forced to'true'otherwise.integrations/tooling/workflow.test.mjs, "path filters run on pull_request only; other events run everything", checks this for every workflow that usespaths-filter. Run against the oldoverlays-ci.ymlit fails withoverlays-ci.yml:43: run paths-filter on pull_request only.integrations/PARALLEL_LANES.md§4 status was stale. It saidrecord.mjsand the moneybird fixture were not started. In fact todoist has a recorder and a replay scenario waiting on a live recording (issue-tracker: record a todoist mock-proxy fixture #46), and moneybird (synthetic) and notion (authored) have registered fixtures, neither of them recorded. Still not started: recordedapi/pages and the drift guard.Board item:
willow.spec.ts:95on #118. This was not a one-off. In run 36834223383 it failed 3 of 4 Playwright attempts across the two job attempts, each time stuck on/app/integrationsfor 60 s after Install, with no server log after the click. I couldn't find the cause:playwright-report-willowartifact).I found no test-side race: the spec waits exactly like plugin-routes, fediverse and OCM. I also have no host-side evidence, so I filed no atomic-server issue. Instead, the wait is now
leftReview(): on timeout it reports the open dialog's text and any toasts. That tells apart the three ways the store keeps you on the review: an inline refusal, atoast.error, or a dialog closed without navigating. I checked the failure message by forcing the timeout locally.The rest of #43:
Checks run:
node --test integrations/tooling/workflow.test.mjs(14/14 pass),run-lane.mjs willow --tier e2e(passes), oxlint and oxfmt on the changed files (clean).🤖 Generated with Claude Code
https://claude.ai/code/session_011qzxyw4dG5n7Fx8TocuWfp
Generated by Claude Code
Generated by Claude Code