Skip to content

money 0.4.0: sync into the shared bank-transaction-v1 class (#177 item 8) - #252

Closed
michielbdejong wants to merge 2 commits into
mainfrom
claude/money-bank-transaction-v1
Closed

michielbdejong wants to merge 2 commits into
mainfrom
claude/money-bank-transaction-v1

Conversation

@michielbdejong

Copy link
Copy Markdown
Contributor

Draft: depends on an atomic-server change and a pin bump. At pin a12b74a, both plugin-manifest validators refuse subject on destination properties and classes (server/src/plugins/manifest.rs validate_destination, browser/lib/src/plugin-manifest.ts validateDestination). Publishing money 0.4.0's plugin.js therefore fails with "destination: unknown field subject", and the money lane fails at the current pin. The host patch (both validators accept an optional https subject, with shared fixtures and a provisionDestination test) is posted on #227 for the atomic-server worker. With a12b74a plus that patch, the money lane passed 3 of 3, against the real github.io terms. Stacked on #251.

Known limits:

Checks: money vitest 188/188, tooling tests 249/249, certify, tsc, oxlint, oxfmt, apps and ontology checks.

Refs #177, #94.

🤖 Generated with Claude Code

michielbdejong and others added 2 commits October 1, 2026 15:45
At pin a12b74a a fresh App may not hold `renders` yet, so installApp found
no array to extend, the Bank transaction class was never added, and Add
view never offered "New app" (the second test timed out on every run).
Find the property through the App's class, by its shortname, as
integrations/tooling/e2e/screenshots.spec.ts does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…m 8)

Importer: schema.ts binds the Bank transaction class and its nine fields to
the published ontology subjects (PropertySpec/ClassSpec `subject`); import
bookkeeping and the Bank statement class stay drive-minted. schema.test.ts
runs the host's own ensureSchema against the committed term files (#177
spike S4), including the recorded limitation on drives set up with 0.3.0.
Needs an atomic-server whose manifest validators accept destination
`subject` (not in pin a12b74a; patch reported separately).

App: offered only on tables of exactly bank-transaction-v1 and reads shared
fields by subject through ontology-kit's resolver. On first open it adds
the class to its own App's `renders` and retargets its own table
(adopt.ts), so a catalog install is offered under Add view on the
importer's table (the #94 gap). On its own table it says where it belongs.
An amount that is not an exact decimal shows "Not a valid amount" and is
never summed. Bundle limit re-measured (100,538 bytes; limit 111,000).

E2E installs the app from the catalog and drops the test-side renders
patch. Plugin e2e tests use the real GitHub Pages subjects;
ontology-kit/served.mjs checks up front that Pages serves them, and
ontology-kit/README.md records the decision for later #177 slices.
README notes the paste-the-class-URL step (#177 item 13). Catalog entry
stays enabled: false (ontology gate).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@michielbdejong

Copy link
Copy Markdown
Contributor Author

Superseded by #287. There, the Money drive app writes bank-transaction-v1 rows itself through app writes, which work at pin a12b74a, so the importer's destination doesn't need subject and no host change is needed. #287 also carries over this PR's reusable parts: adopt on first open, the strict resolver, "Not a valid amount", the catalog-install e2e, and the served.mjs test. I'll close this PR when #287 merges.


Generated by Claude Code

@michielbdejong

Copy link
Copy Markdown
Contributor Author

Superseded by #287 (merged): the Money drive app writes bank-transaction-v1 rows itself, so the importer's destination no longer needs subject.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant