Repository navigation
money 0.4.0: sync into the shared bank-transaction-v1 class (#177 item 8) - #252
Closed
michielbdejong wants to merge 2 commits into
Closed
michielbdejong wants to merge 2 commits into
michielbdejong wants to merge 2 commits into
Conversation
At pin a12b74a a fresh App may not hold `renders` yet, so installApp found no array to extend, the Bank transaction class was never added, and Add view never offered "New app" (the second test timed out on every run). Find the property through the App's class, by its shortname, as integrations/tooling/e2e/screenshots.spec.ts does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…m 8) Importer: schema.ts binds the Bank transaction class and its nine fields to the published ontology subjects (PropertySpec/ClassSpec `subject`); import bookkeeping and the Bank statement class stay drive-minted. schema.test.ts runs the host's own ensureSchema against the committed term files (#177 spike S4), including the recorded limitation on drives set up with 0.3.0. Needs an atomic-server whose manifest validators accept destination `subject` (not in pin a12b74a; patch reported separately). App: offered only on tables of exactly bank-transaction-v1 and reads shared fields by subject through ontology-kit's resolver. On first open it adds the class to its own App's `renders` and retargets its own table (adopt.ts), so a catalog install is offered under Add view on the importer's table (the #94 gap). On its own table it says where it belongs. An amount that is not an exact decimal shows "Not a valid amount" and is never summed. Bundle limit re-measured (100,538 bytes; limit 111,000). E2E installs the app from the catalog and drops the test-side renders patch. Plugin e2e tests use the real GitHub Pages subjects; ontology-kit/served.mjs checks up front that Pages serves them, and ontology-kit/README.md records the decision for later #177 slices. README notes the paste-the-class-URL step (#177 item 13). Catalog entry stays enabled: false (ontology gate). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 1, 2026
Contributor
Author
|
Superseded by #287. There, the Money drive app writes Generated by Claude Code |
Contributor
Author
|
Superseded by #287 (merged): the Money drive app writes Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft: depends on an atomic-server change and a pin bump. At pin a12b74a, both plugin-manifest validators refuse
subjecton destination properties and classes (server/src/plugins/manifest.rsvalidate_destination,browser/lib/src/plugin-manifest.tsvalidateDestination). Publishing money 0.4.0'splugin.jstherefore fails with "destination: unknown fieldsubject", and the money lane fails at the current pin. The host patch (both validators accept an optional httpssubject, with shared fixtures and aprovisionDestinationtest) is posted on #227 for the atomic-server worker. With a12b74a plus that patch, the money lane passed 3 of 3, against the real github.io terms. Stacked on #251.schema.tsbindsbank-transaction-v1and its nine fields bysubjectfromontology-kit/terms.mjs. The import bookkeeping fields and the Bank statement class stay drive-local. Version 0.4.0.bank-transaction-v1, and reads the shared fields by subject throughontology-kit/resolver.mjs.app/adopt.ts), it adds the class to its ownrendersand retargets its own table. The importer's table then offers the app under Add view after a catalog install, which closes the Complete catalog installation and publication for drive apps #94 gap.apps/money/0.4.0/ui.js. The catalog entry staysenabled: false.renderspatch. AbeforeAllchecks that Pages serves the terms.ontology-kit/served.mjs.Known limits:
Checks: money vitest 188/188, tooling tests 249/249, certify, tsc, oxlint, oxfmt, apps and ontology checks.
Refs #177, #94.
🤖 Generated with Claude Code