Skip to content

money 0.4.0: the Money app writes bank-transaction-v1 rows itself (#177 item 8), no host change - #287

Merged
michielbdejong merged 5 commits into
mainfrom
claude/money-bank-transaction-app
Oct 2, 2026
Merged

michielbdejong merged 5 commits into
mainfrom
claude/money-bank-transaction-app

Conversation

@michielbdejong

Copy link
Copy Markdown
Contributor

Supersedes draft #252. That PR bound the sandbox importer's destination to the shared class, and both manifest validators at pin a12b74a refused it ("destination: unknown field subject"). This PR takes the route the calendar, timesheets and issue-tracker apps already take at the pin: the Money drive app writes bank-transaction-v1 rows itself, through the frame store, at the published subjects. The importer is unchanged (0.4.0 is 0.3.0's bundle with only the manifest version bumped), and its table reaches the app through a lens on its drive-local class.

  • Complete catalog installation and publication for drive apps #94 gap closed: a catalog Install opens Money on its own table, which the app turns into a bank-transaction-v1 table on first open.

    • Dropping an MT940/camt.053 file there imports it through the app's own writes, with the importer's identity and fingerprint rules: reimports are recognised, changed bookings blocked and reference-free overlaps refused.
    • One statement row per statement is kept under the App, for the closing balance. Category and note save without a grant.
    • The app also lists the importer's class in its renders, so Add view offers it on the importer's table. There, 0.3.0's flow (import through the host's review, Allow editing) runs unchanged.
  • Shared class:

    • Shared fields are read by published subject only, through the strict resolver.
    • The four bookkeeping fields are the App's own Properties, declared as row-extras, so an "Allow editing" grant on a hand-made shared-class table covers an import there too (unit-tested, no e2e).
    • Amounts stay exact strings. A value that isn't an amount shows "Not a valid amount" and is never summed.
  • Release: bundle 108,795 bytes (limit 120,000), published as apps/money/0.4.0/ui.js. The catalog entry 0.4.0 stays enabled: false (ontology gate). Usertest money is usertest-3.

  • E2E (money lane, 4/4 twice at a12b74a, with the real Pages terms):

    • catalog install, then an import into the app's own table, checked on the server (class, subjects, exact strings);
    • the strip and Imports tab, a category saved without a grant;
    • reimport, a changed booking, and a camt.053 file;
    • then Add view on the importer's table and the existing flow.

    beforeAll checks that Pages serves the terms.

Known limits:

  • Two copies of the app importing the same file at the same moment can both write a row; app writes have no server-side uniqueness.
  • Rows missing a required shared field aren't shown yet.
  • Importing into a hand-made shared-class table is unit-tested only.

Checks: money vitest 210/210, tooling tests 254/254, apps and ontology checks, certify, oxlint (0 errors) and oxfmt.

Refs #177 (item 8), #94. Supersedes #252.

🤖 Generated with Claude Code

michielbdejong and others added 3 commits October 2, 2026 17:25
…nge)

Takes from #252 what stays useful: the Pages served check for e2e tests
(ontology-kit/served.mjs), the certify symlink for ontology-kit, and
"Not a valid amount" for rows of the shared class.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…pt, e2e

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…tting

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
# Conflicts:
#	integrations/READINESS.md
# Conflicts:
#	integrations/READINESS.md
#	usertest/catalog.mjs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant