Repository navigation
Money 0.4.1: show a bank transaction missing a required field as incomplete (#177 rule) - #295
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…lete (#177 rule) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
michielbdejong
changed the base branch from
claude/shared-class-incomplete-rows
to
main
October 2, 2026 19:23
This was referenced Oct 2, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # integrations/READINESS.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 2, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #293, for
incompleteNote: merge that first. This is a follow-up to it; #293 left money out because #287 (money 0.4.0) touched the same files.Why.
ontology-kit/README.md's rule for every shared-class view: show an incomplete row instead of skipping it. Money 0.4.0 had two problems:readRowreturnedundefinedfor a row without account, currency, amount or value date, so such a row vanished from the ledger;What.
store.openResource).state.incomplete, apart fromstate.rows, so no balance, total, account list, statement or import check ever counts one. An incomplete row carrying an import's source id is neither "already imported" nor a changed booking.isAthe row class, so a table's Views aren't read as rows.Tests: 7 new unit tests. The e2e commits a row with an empty Amount, the only incomplete row the pin accepts: it refuses a commit missing a required property, and
''isn't a valid date. The row shows up through the subscription, the transaction count is unchanged, and "Open row" navigates to it.Release: 0.4.1,
apps/money/0.4.1/ui.js(111,239 bytes; limit 123,000). Catalog and usertest VERSIONS updated.plugin.jsis rebuilt with only the manifest version changed. READMEs updated.Checks: money vitest 217, tooling tests 256, apps and ontology checks, certify, e2e tsc, oxlint (0 errors), oxfmt, and the money lane e2e (4 passed) at pin a12b74a.
🤖 Generated with Claude Code