Skip to content

Money 0.4.1: show a bank transaction missing a required field as incomplete (#177 rule) - #295

Merged
michielbdejong merged 8 commits into
mainfrom
claude/money-incomplete-rows
Oct 2, 2026
Merged

michielbdejong merged 8 commits into
mainfrom
claude/money-incomplete-rows

Conversation

@michielbdejong

Copy link
Copy Markdown
Contributor

Stacked on #293, for incompleteNote: merge that first. This is a follow-up to it; #293 left money out because #287 (money 0.4.0) touched the same files.

Why. ontology-kit/README.md's rule for every shared-class view: show an incomplete row instead of skipping it. Money 0.4.0 had two problems:

  • readRow returned undefined for a row without account, currency, amount or value date, so such a row vanished from the ledger;
  • it read every child of the table as a row.

What.

  • Listed, not dropped: rows missing a required field appear in an "Incomplete rows" region above the ledger, with what they have, the note ("Incomplete: missing Amount") and "Open row" (store.openResource).
  • Kept apart: they live in state.incomplete, apart from state.rows, so no balance, total, account list, statement or import check ever counts one. An incomplete row carrying an import's source id is neither "already imported" nor a changed booking.
  • Row filter: rows are now filtered by isA the row class, so a table's Views aren't read as rows.
  • Completion: a row completed in the host moves into the ledger on the next table change.

Tests: 7 new unit tests. The e2e commits a row with an empty Amount, the only incomplete row the pin accepts: it refuses a commit missing a required property, and '' isn't a valid date. The row shows up through the subscription, the transaction count is unchanged, and "Open row" navigates to it.

Release: 0.4.1, apps/money/0.4.1/ui.js (111,239 bytes; limit 123,000). Catalog and usertest VERSIONS updated. plugin.js is rebuilt with only the manifest version changed. READMEs updated.

Checks: money vitest 217, tooling tests 256, apps and ontology checks, certify, e2e tsc, oxlint (0 errors), oxfmt, and the money lane e2e (4 passed) at pin a12b74a.

🤖 Generated with Claude Code

michielbdejong and others added 5 commits October 2, 2026 19:07
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…lete (#177 rule)

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
michielbdejong and others added 3 commits October 2, 2026 19:38
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	integrations/READINESS.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@michielbdejong
michielbdejong merged commit 4d4052b into main Oct 2, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant