Repository navigation
Shared-class views show rows missing a required field as incomplete (#177): calendar 0.3.1, issue-tracker 0.3.1, todoist 0.1.1, timesheets 0.6.2 - #293
Merged
Conversation
… (WIP) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ncomplete, never sent Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ever synced, and no longer fails the pass Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… incomplete with Open row Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…unted as running Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…; it refuses a missing Day or Start The server checks a class's required properties on every commit (lib/src/resources.rs check_required_props), so a row of event-v1 without a Day or of time-entry-v1 without a Start cannot exist on this host; the specs check that refusal and exercise the views with an empty Name. The READMEs and ontology-kit's say so. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…s Views and other children Before, every child of the table was read as a row; a View added through Add view has no Day or Start, so it was drawn nowhere or counted as a running timer, and would now have been listed as incomplete. Rebuilt apps/calendar/0.3.1 and apps/timesheets/0.6.2 (unpublished versions). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…is synced; Todoist's Last seen is the seventh column Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…s; the page keeps a refused row in its local outbox Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ontology-kit/README.mdandresolver.d.mtsstate the rule for every shared-class view:read()returnsmissing/completefor the class's required fields "so the view shows an incomplete row instead of skipping it" ("Required fields that are absent: show the row as incomplete, don't skip it"). #177's body and Michiel's decision comments do not use the word "incomplete"; decision 1 (2026-09-25) makes matching strict and says "Views read shared-class properties only". No drive app readmissing: calendar drew a row without a Day nowhere, issue-tracker failed the whole pass on a bound row without a Name ("Invalid Atomic issue") and hid the fact for unbound ones, timesheets counted a row without a Start as a running timer, and the Todoist app showed a nameless row by its task id.What
ontology-kit/resolver.mjs:incompleteNote(missing, labels)→ "Incomplete: missing Name and Day" (shortname when no label;undefinedwhen nothing is missing), typed inresolver.d.mts, tested.event-v1requires Name, Day):CalEvent.incomplete; an "Incomplete rows" section above Agenda/Week lists them with "Open row" (store.openResource); agenda tag and accessible name; drawer note with "Open row". A synced incomplete row is held back whole (rows.invalid, review sheet "Not sent: … (Incomplete: missing Day)"), never "Not sent yet", Google's edits to it not applied.issue-v1requires Name):row()no longer throws; a bound incomplete row shows the Bridge its baseline (nothing sent, GitHub's changes still fill the Name), an unbound one stays out of the Bridge even when asked to publish;IssueRow.incomplete; "(no title)" + tag on card and list row; panel note with "Open row"; Publish disabled; moving disabled; review panel "Not synced until complete: …". Whitespace-only names count as missing.local; a row missing Name marked, "Open row" column when the host can; the pass never writes either. Nothing is ever sent to Todoist, so nothing to hold back.time-entry-v1requires Start):Timesheet.incomplete;timesheetFromRowslists rows without a Start (or with a non-timestamp Start) instead of counting them as running; note above Week/Entries with "Open row". Synced bound rows are restored from Clockify at the next sync (existingsyncRowbehaviour), documented.apps/<id>/<version>/ui.js, catalog,usertest/catalog.mjsVERSIONS, size limits.Money is left out: PR #287 (money 0.4.0) changes the same area; follow-up there.
Checks
(filled in from the run)
🤖 Generated with Claude Code