Repository navigation
Conversation
joepio
added a commit
that referenced
this pull request
Sep 25, 2026
# Conflicts: # browser/CHANGELOG.md # browser/data-browser/src/locales/de.po # browser/data-browser/src/locales/en.po # browser/data-browser/src/locales/es.po # browser/data-browser/src/locales/fr.po
joepio
added a commit
that referenced
this pull request
Sep 25, 2026
Member
Author
|
Landed on develop in ef161c3 via the combined batch #1844 (green on Mancave, run 4645). Closing. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Joep
Before: a personal drive without Cloud Server could still end up syncing to node1. The node refused every write ("Drive … is not enrolled for sync on this node"), the server card sat on "Connecting…" with changes pending, and unticking "Sync this workspace with this server" did nothing.
After: the server card says "Not hosted here" and explains that the server refuses this workspace, pointing at Cloud Server setup or at turning sync off. Turning sync off works in that state and keeps the workspace on this device. A Suspended Cloud Server enrollment no longer makes the app point a drive at a node that won't serve it.
The app treated any enrollment that wasn't Disabled or Pending as hosted, while the node serves only Pending, Active and Error (
is_servablein atomic-saas). A Suspended row (or a manual grant that left one) made the app connect the drive to a node that then refused it. Separately, the sync checkbox was disabled whenever the server wasn't connected, and turning sync off first asked the server for its inventory, which a refusing node can never answer.How:
Store.isDriveRefusedByServerreads the not-enrolled refusal from the last drive sync or a parked outbox entry.makeDriveLocalskips the inventory check for such a drive, registers it local-only and drops its refused outbox entries (turning sync on later resyncs the whole drive).SyncRouteshows the refused state and keeps the checkbox usable.resolveHostedDriveOrigincounts only Active and Error enrollments. Newstore.refused-drive.test.ts;reconcile.test.tscovers Suspended.