Repository navigation
Conversation
A vault restore writes the drive into the local database only. The store still held the lookup from before the restore: a "not found" from the node, or "not available locally" without one. `getResource` returns a cached error as is, so sign-in's check right after the restore read the old answer, concluded the device had nothing, and let `openPrivateHome` create a new home over the restored drive. When it did not, the drive kept the stale error through every later save, and the sidebar showed its raw subject instead of its name. `restoreFromVault` now reloads the drive and its agent once the import has written something, local database first, the way the Sync page restore already did through `reopenRestoredDrive`.
joepio
added a commit
that referenced
this pull request
Sep 25, 2026
# Conflicts: # browser/CHANGELOG.md
joepio
added a commit
that referenced
this pull request
Sep 25, 2026
Member
Author
|
Landed on develop in ef161c3 via the combined batch #1844 (green on Mancave, run 4645). Closing. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: a returning user who signed in on a new device and got their drive back from Cloud Vault often saw the drive's raw identifier (
atomic:9y6J…) as its title, or an empty new "My drive" in its place. The app kept the "not found" it got before the restore and trusted that over the data the restore had just written. The atomic-saas e2ereturning-user-second-browser.spec.tsfailed on this title check in both the node and nodeless jobs.After: once the restore has written the drive, the app reloads it and its agent from the local database. Sign-in sees the drive, no new home is made over it, and the sidebar shows its name.
How:
restoreFromVaultcallsreopenRestoredDriveafter an import that restored anything, like the Sync page restore already does.getResourcereturns a cached error unchanged, so without the reload the sign-in check atGettingStartedFlow.tsx:710read the old error andopenPrivateHomewent on to create "My drive". If that did not happen, later local saves merged the resource into itself and kept the stale error.Related Issues
No issue. Found through atomic-saas PR 152 CI (the "Portal e2e" jobs).
Checklist
Validation: on a local stack running develop 87301c5, the title check failed in 5 of 8 node-mode runs and 1 of 3 nodeless runs. With this commit it passed 4 of 4 node runs and 3 of 3 nodeless runs. Workspace lint, data-browser
tsc --noEmitand the vitest suites forhelpers/managedandviews/getting-started(302 tests) pass.