Repository navigation
Label row-dialog fields by name, keep clicks on the table - #1816
Closed
michielbdejong wants to merge 1 commit into
Closed
michielbdejong wants to merge 1 commit into
michielbdejong wants to merge 1 commit into
Conversation
The expanded-row dialog reused PropVal as the resource page uses it. Each field was labelled with the raw shortname (`due-date`, `body`), and the label was an in-app link, so clicking it left the table for the Property page. The input that opened on edit had no label, so the All day checkbox had no accessible name. Editing also logged a React key warning: wuchale compiled the icon and bare "Save" into one message, and its runtime returns an unkeyed array. - AllProps/PropVal take `labelByName`, which ExpandedRowDialog sets. Fields are then labelled with the property's name through `columnLabel`, as the table headings are, with the shortname and description in a tooltip. The label is a `<label for>` the edited input, and the property opens in a new tab from a separate icon link. Resource pages keep the linked shortname. - ValueForm and ValueFormEdit pass the input id through to InputSwitcher. - ValueFormEdit wraps "Save" in its own span, so the button's children are static and there is no message array. Closes #1796 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
joepio
added a commit
that referenced
this pull request
Sep 25, 2026
#1816 labels the row dialog's fields with the property's name ("Date", "Assignee") instead of its shortname. calendar.spec.ts:84 and kanban.spec.ts:349 still looked for the lowercase shortname and failed on batch run 4630.
Member
|
Landed on develop in 46562ff via the combined batch #1828 (green on Mancave, run 4639). Closing. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1796
Branched from
develop, not stacked on #1812 (#1795). The two PRs change different files and don't conflict. The "Due date … at 02:00:00" in the screenshots below is #1795, which #1812 fixes.Root causes
ExpandedRowDialogrendersAllProps→PropVal, the resource-page component.PropVallabels each value withproperty.shortname.<AtomicLink subject={property}>, which navigates in-app on click.ValueFormEditrenderedInputSwitcherwith noid, and the label was a<span>inside a link.ValueFormEdithad<FaFloppyDisk />followed by a bareSave. Wuchale compiles that into one message (<0/> Save), and its runtime (W_tx_) returns an unkeyed array of fragments, so React warns: "Check the render method ofValueFormEdit. It was passed a child from default."Fix
AllProps/PropValtake a newlabelByNameprop, andExpandedRowDialogsets it. With it:columnLabel, the same helper the table headings use: "Due date", "Description", or a readable shortname when the property has no name. The shortname and description are in the tooltip.<label htmlFor>for the input, not a link.ValueForm→ValueFormEdit→InputSwitcherpass the inputidthrough, so the checkbox, and every other input that forwardsid, is named by its label.ValueFormEdit:<span>Save</span>, so the button's children are static JSX and no longer a message array. This matchesInstallationPage.Catalogs: one new string,
Open {0} in a new tab.<0/> Savemoves to plainSaveand is marked obsolete. They were settled with one vite run afterrm -rf src/locales/.wuchale, and I read the diff by hand.Tests
src/components/PropVal.test.tsx(vitest, jsdom, realStore). The dialog label is the name, is a<label>, has the shortname in its tooltip and has no link ancestor. It falls back to "Due date" when the property has no name. The property link istarget=_blank. After clicking "Empty",getByRole('checkbox', { name: 'Bought' })finds the checkbox, which is its accessible name. The resource page still shows the linked shortname. Againstdevelop, 4 of 5 fail. The resource-page case is the regression guard.browser/e2e/tests/row-dialog.spec.ts(not@smoke). It opens a Grocery list row, checks the name labels, clicks a label and checks the URL doesn't change, then edits Bought and finds the checkbox by accessible name. It runs axe (label,link-name) on the open dialog. The key warning only appears with the wuchale transform, which vitest skips, so this spec's browser-diagnostics fixture is what catches it. Againstdevelopit fails.Locally, vitest needs Node 22, which is what CI uses. Under Node 26, jsdom's
localStorageis undefined, and everyStore-based test fails, including existing ones.Screenshots
Playwright,
en-GB,Europe/Amsterdam. The files are saved locally for review:1796-before-desktop.png:name,status,due-date,body,created-atas links1796-before-375.png1796-after-desktop.png: Name, Status, Due date, Description, Created at, each with a new-tab icon1796-after-375.png1796-before-checkbox-desktop.png: checkbox with no name1796-before-checkbox-375.png1796-after-checkbox-desktop.png: checkbox named "Bought"1796-after-checkbox-375.png🤖 Generated with Claude Code