Skip to content

Calendar: show a moved meeting as moved, not as a gap - #1823

Closed
michielbdejong wants to merge 3 commits into
claude/calendar-day-listfrom
claude/calendar-moved-occurrence
Closed

michielbdejong wants to merge 3 commits into
claude/calendar-day-listfrom
claude/calendar-moved-occurrence

Conversation

@michielbdejong

Copy link
Copy Markdown
Contributor

Closes #1804

Stacking. Base is claude/calendar-day-list (#1819). That branch sits on #1814 and #1810 and merges in #1813, so this builds on all of them. Merge those first.

What changes

In the session, the seeded weekly standup had its Wed 14 Oct instance moved to Thu 15 Oct. The tester saw an empty Wednesday and concluded "it's canceled for the 14th". Nothing linked the gap to the extra Thursday standup.

Occurrence logic (calendarOccurrences.ts). An instance overridden with recurringEventId + originalStartTime to another civil day now appears twice:

  • On its new day, it is marked with movedFrom: '2026-10-14'.
  • On its original day, a placeholder carries movedTo: '2026-10-15'.

Both carry the original instance's key that the expansion already keeps (CalendarOccurrence.key). The key is built from the override record and matched to the expanded occurrence. The placeholder is placed even when the new day is outside the visible month, since the expansion hides the original day either way.

Not marked:

  • A time change within the same day.
  • A cancelled instance, which stays a gap.

Days are computed like the expansion's eventDay: the instance's own zone, else the series' zone, else the date as written.

UI.

  • On the new day, the chip reads "↻ Team standup" with "Moved from Wed 14 Oct" on a second line.
  • On the original day, a faint dashed placeholder reads "↷ Team standup / Moved to Thu 15 Oct". Clicking it opens the moved instance's row.
  • Both show in the day list from Calendar: "+N more" on crowded days, and a day list #1819 in full. Their tooltips give the long date.

Fitting "+N more". Moved chips are two lines, so the fitting from #1819 no longer assumes equal chip heights. Every chip stays rendered, and the ones that don't fit are laid out after "+N more" with visibility: hidden, which also removes them from focus and the accessibility tree. That way each chip can be measured.

Tests

  • Vitest first, failing, then green (calendarOccurrences.test.ts, "moved occurrences (Calendar: a moved occurrence looks like a cancellation #1804)"). Covers the mark on the new day, the placeholder on the original day with the same key, the rest of the series untouched, a placeholder when the new day is off the grid, and no mark for a same-day time change or a cancellation.
  • calendar.spec.ts now counts only visible chips and checks that "+N more" stays inside its cell. It and kanban.spec.ts pass (14 tests). The TablePage and components vitest suites pass (423 tests).
  • TESTING_COVERAGE.md updated.

Screenshots

October 2026 from the session's seed, before and after, at desktop and 375 px, shared with the reviewer in chat:

  • 1804-before-desktop.png, 1804-before-mobile.png: 14 Oct is empty, 15 Oct has an unexplained standup.
  • 1804-after-desktop.png, 1804-after-mobile.png: the placeholder on 14 Oct and the note on 15 Oct.
  • 1804-after-*-day-list-14-oct.png, 1804-after-*-day-list-15-oct.png: the full text.
  • 1804-after-*-placeholder-opens-row.png: the placeholder opens the moved instance (Day = 15/10).

At 375 px the chips are too narrow to read, as with every other chip. Tapping the day opens the list with the full text.

Translations

New strings: "Moved from {0}", "Moved to {0}", "{0} · Moved from {1}" and "{0} · Moved to {1} (opens the moved meeting)". Inside the guarded JSX, wuchale extracted "Moved from" without its date, so each note is now its own small component. Settled by restarting vite after clearing .wuchale, and the second run left the .po diff unchanged.

🤖 Generated with Claude Code

Michiel de Jong and others added 3 commits September 25, 2026 12:59
An instance of a recurring meeting moved to another day (`recurringEventId`
+ `originalStartTime`) left an empty original day, and the tester read it
as a cancellation (#1804). The occurrence buckets now mark the instance on
its new day with `movedFrom`, and put a placeholder with `movedTo` on the
day it used to be. Both carry the original instance's key from the
expansion. The placeholder is there even when the new day is outside the
visible month. A time change within the same day, and a cancellation,
are not marked.

The chip on the new day reads "Moved from Wed 14 Oct" on a second line.
The faint dashed placeholder reads "Moved to Thu 15 Oct" and opens the
moved instance. A second line makes chips unequal in height, so the
"+N more" fitting now measures every chip instead of the first.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Inside the guarded JSX, "Moved from {date}" was extracted as "Moved from"
alone, so a translation could not move the date. Each note is its own
small component now.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@michielbdejong michielbdejong added enhancement New feature or request browser labels Sep 25, 2026
joepio added a commit that referenced this pull request Sep 25, 2026
…) (#1828)

Combined batch, green on Mancave in run 4639 on 3be85ae.

Includes #1809, #1810, #1811, #1812, #1813, #1814, #1815, #1816, #1817,
#1818, #1819, #1820, #1821, #1823, #1824, #1827 and #1765, plus the e2e
label updates for #1816 and settled translation catalogs.

joepio commented Sep 25, 2026

Copy link
Copy Markdown
Member

Landed on develop in 46562ff via the combined batch #1828 (green on Mancave, run 4639). Closing.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

browser enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants