Repository navigation
Conversation
Editing inside the settings section swapped the list for a long form and put the Save/Cancel buttons below it, which felt cramped. The lists stay on the AI settings page; creating or editing an agent, skill or MCP server now opens a shared ConfigEditorDialog with the form and Cancel/Save actions. Escape, the close button and an outside click cancel; Save is disabled until the required fields are filled in. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P648McUYrscNsheXY5Ya81
Collaborator
Author
|
Verification so far:
Not yet run: the updated 🤖 Generated with Claude Code Generated by Claude Code |
Polleps
marked this pull request as ready for review
September 29, 2026 13:29
1 of 3 tasks
joepio
added a commit
that referenced
this pull request
Sep 30, 2026
…ent images, onboarding recovery fixes (#1915) Lands #1889 (edit agents, skills and MCP servers in a dialog), #1890 (sidebar account menu in place of the App panel), #1891 (share dialog role select stays open), #1895 (document images from the local blob store) and #1917 (onboarding recovery, metadata request bursts, local bootstrap), tested together on Mancave.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Feedback: editing agents, skills and MCP servers inline on the settings page felt cramped and hectic. The lists can stay on the settings page, but editing should happen in a dialog.
What changed
ConfigEditorDialog(browser/data-browser/src/chunks/AI/ConfigEditorDialog.tsx): a small wrapper around the existingDialog/useDialog. It has a title, the form as content, and Cancel / Save actions. Escape, the close button and an outside click cancel. Save persists the item and closes the dialog. Editing state is cleared only after the dialog has finished closing, so the close animation doesn't flash an empty form.AgentConfigTab,SkillsConfigTabandMCPConfigTabnow always show their list (the default-agent radio, the skill enable checkboxes, delete and duplicate stay where they were). Create and Edit open the dialog. Titles are "New / Edit Agent", "New / Edit Skill" and "New / Edit MCP Server". Save labels are the same as before.AIConfigurationSectionsdrops the action-portal plumbing (actionPortalElement/onActionsVisibleChange). Each block is now a plainSettingsSection.ai-settings.spec.ts: the create flows run inside the dialog and check that it closes after save. A new step checks that cancelling a skill edit leaves the skill unchanged..pofiles by hand (see notes).Notes
Dialogcomponent, following the same pattern asEditFormDialog..pofiles by hand. In my environment,pnpm clean-translationsdropped hundreds of live strings (for example "AI chat"), so I didn't commit its output.Checklist
browser/CHANGELOG.md)🤖 Generated with Claude Code
https://claude.ai/code/session_01P648McUYrscNsheXY5Ya81
Generated by Claude Code