Skip to content

Edit agents, skills and MCP servers in a dialog - #1889

Closed
Polleps wants to merge 1 commit into
developfrom
claude/nice-rubin-82ayvd-settings-dialogs
Closed

Polleps wants to merge 1 commit into
developfrom
claude/nice-rubin-82ayvd-settings-dialogs

Conversation

@Polleps

@Polleps Polleps commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

Related Issues

Feedback: editing agents, skills and MCP servers inline on the settings page felt cramped and hectic. The lists can stay on the settings page, but editing should happen in a dialog.

What changed

  • New ConfigEditorDialog (browser/data-browser/src/chunks/AI/ConfigEditorDialog.tsx): a small wrapper around the existing Dialog / useDialog. It has a title, the form as content, and Cancel / Save actions. Escape, the close button and an outside click cancel. Save persists the item and closes the dialog. Editing state is cleared only after the dialog has finished closing, so the close animation doesn't flash an empty form.
  • AgentConfigTab, SkillsConfigTab and MCPConfigTab now always show their list (the default-agent radio, the skill enable checkboxes, delete and duplicate stay where they were). Create and Edit open the dialog. Titles are "New / Edit Agent", "New / Edit Skill" and "New / Edit MCP Server". Save labels are the same as before.
  • Save is disabled until the required fields are filled in: name for agents, name and description for skills, name and URL for MCP servers. Before this change only MCP checked its required fields.
  • AIConfigurationSections drops the action-portal plumbing (actionPortalElement / onActionsVisibleChange). Each block is now a plain SettingsSection.
  • e2e ai-settings.spec.ts: the create flows run inside the dialog and check that it closes after save. A new step checks that cancelling a skill edit leaves the skill unchanged.
  • Catalogs: the five new titles were added to the .po files by hand (see notes).

Notes

  • The earlier dialog version is not in this clone's (squashed) history, so the dialog uses the standard Dialog component, following the same pattern as EditFormDialog.
  • I edited the .po files by hand. In my environment, pnpm clean-translations dropped hundreds of live strings (for example "AI chat"), so I didn't commit its output.

Checklist

  • Add changelog entry linking to issue, describe API changes (browser/CHANGELOG.md)
  • Add or update tests if needed
  • Update docs if needed (n/a)

🤖 Generated with Claude Code

https://claude.ai/code/session_01P648McUYrscNsheXY5Ya81


Generated by Claude Code

Editing inside the settings section swapped the list for a long form and
put the Save/Cancel buttons below it, which felt cramped. The lists stay
on the AI settings page; creating or editing an agent, skill or MCP
server now opens a shared ConfigEditorDialog with the form and
Cancel/Save actions. Escape, the close button and an outside click
cancel; Save is disabled until the required fields are filled in.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01P648McUYrscNsheXY5Ya81

Polleps commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

Verification so far:

  • pnpm lint passes in data-browser and e2e. pnpm typecheck passes in both, with all workspace packages built.
  • vitest run src/chunks/AI: 22 files, 91 tests pass.
  • pnpm build (data-browser) succeeds and leaves the .po files unchanged, so the hand-added catalog entries match what the extractor produces.
  • I ran the production build (vite preview) in Chromium through a Playwright script:
    • The agent's Save button is disabled until a name is filled in. Create closes the dialog and the new agent is selected.
    • Skill create works.
    • Escape on a skill edit discards the change.
    • Cancel on a new MCP server saves nothing.
    • The dialog fits a 390px-wide viewport.

Not yet run: the updated e2e/tests/ai-settings.spec.ts against a real server. The shared machine was too loaded for the server build to finish. Screenshots of the list, the agent/skill/MCP dialogs and the mobile view were captured locally but not uploaded; please add them when reviewing, or run the spec with pnpm test-e2e:local tests/ai-settings.spec.ts.

🤖 Generated with Claude Code


Generated by Claude Code

@Polleps
Polleps marked this pull request as ready for review September 29, 2026 13:29
joepio added a commit that referenced this pull request Sep 30, 2026
…ent images, onboarding recovery fixes (#1915)

Lands #1889 (edit agents, skills and MCP servers in a dialog), #1890 (sidebar account menu in place of the App panel), #1891 (share dialog role select stays open), #1895 (document images from the local blob store) and #1917 (onboarding recovery, metadata request bursts, local bootstrap), tested together on Mancave.
@joepio joepio closed this Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants