Skip to content

Replace the sidebar App panel with an account menu - #1890

Closed
Polleps wants to merge 3 commits into
developfrom
claude/nice-rubin-82ayvd-sidebar-dropdown
Closed

Polleps wants to merge 3 commits into
developfrom
claude/nice-rubin-82ayvd-sidebar-dropdown

Conversation

@Polleps

@Polleps Polleps commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Related Issues

No issue. This comes from user feedback: the App section of the sidebar had too many entries. It now works like the account menus in Notion, Claude Code or Codex.

What changed

  • The App panel is gone. The bottom of the sidebar is now a single row:
    • User row (avatar + name): opens a DropdownMenu with Profile (the user page, ⌘/Ctrl+U hint), Notifications (unread count badge), divider, Integrations, Sync (live status icon, with the status as the tooltip), divider, Feedback (opens the feedback dialog), About, and Install App when the browser offers it.
    • Settings gear: an IconButton next to the row (title/aria-label "Settings").
    • A dot on the row shows unread notifications while the menu is closed.
    • When signed out, the row reads "Login / New User". Its first menu item goes to the sign-in/user page, and Notifications is hidden.
  • The menu reuses the existing DropdownMenu, non-searchable. Arrow keys, Enter, Escape and Tab work. The trigger has aria-haspopup/aria-expanded/aria-controls, and focus returns to it when the menu or the feedback dialog closes.
  • The Sync status icon is aria-hidden inside the menu item, so the item's accessible name is "Sync" and not "Connected Sync". The status is still in the tooltip.
  • Refactors needed to put these in a menu:
    • FeedbackMenuItem.tsx becomes FeedbackButton.tsx. The dialog moved into useFeedbackDialog(), which both the floating FeedbackButton and the menu item use. The four floating call sites are updated.
    • SyncMenuItem.tsx becomes syncStatus.tsx (useSyncStatus, getSyncIcon, getSyncLabel).
    • NotificationsMenuItem.tsx and the unused SideBarMenuItem component are removed. The shared row styles stay.
    • AppMenu.tsx becomes AccountMenu.tsx.
  • .po catalogs re-extracted: 5 new strings, 3 obsolete.

E2E

  • New helpers in test-utils.ts: openAccountMenu(page) and clickAccountMenuItem(page, name).
  • signIn() used to wait for an a[href$="/app/agent"] sidebar link. It now waits for [data-testid="account-menu-trigger"][data-signed-in="true"].
  • Updated specs: feedback, notifications, offline-tables, ollama-feedback (now tests hover highlight on the menu item), right-panel-lifecycle, signout-signin-data.

Checks

  • pnpm typecheck (data-browser, e2e): pass
  • pnpm lint (data-browser, e2e; oxlint + oxfmt): pass, no new warnings
  • vitest data-browser: all pass except src/helpers/managed/recovery-enrollment.test.ts (Argon2 60s timeouts under load, unrelated to this change)
  • Checked by hand in the running app (dev-drive, Playwright/Chromium, desktop 1280×800 and mobile 390×844): the menu opens; Sync, Profile and the Settings gear navigate to the right pages; Feedback opens the dialog and focus returns to the row when it closes; Escape returns focus to the row.
  • The Playwright e2e suite was not run locally. The changed specs need CI.

Screenshots of the closed row, the open menu (desktop and mobile) and the feedback dialog were taken locally. They will be attached in a comment.

Checklist

  • Add changelog entry linking to issue, describe API changes
  • Add or update tests if needed
  • Update docs if needed

🤖 Generated with Claude Code

https://claude.ai/code/session_01P648McUYrscNsheXY5Ya81

The App panel at the bottom of the sidebar listed eight entries. It is now
a single row: the current user opens a dropdown with Profile,
Notifications (with the unread count), Integrations, Sync, Feedback,
About and, when available, Install App. Settings sits beside the row as a
gear icon button. Signed out, the row reads "Login / New User" and its
first item leads to the sign-in page.

The row reuses DropdownMenu, so arrow keys, Enter and Escape work and
focus returns to the trigger. An unread-notifications dot shows on the
row while the menu is closed.

To serve both the floating Feedback button and the menu item, the
feedback dialog moved into useFeedbackDialog (FeedbackMenuItem is now
FeedbackButton), and SyncMenuItem became a useSyncStatus hook.

E2E specs that clicked the old panel entries go through the new
openAccountMenu / clickAccountMenuItem helpers, and signIn waits for the
account row instead of a link to /app/agent.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01P648McUYrscNsheXY5Ya81
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01P648McUYrscNsheXY5Ya81
The status icon's SVG title ("Connected", "Offline") became part of the
menu item's accessible name. Hide the icon from assistive tech; the status
is still in the item's tooltip.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01P648McUYrscNsheXY5Ya81
@Polleps
Polleps marked this pull request as ready for review September 29, 2026 13:29
joepio added a commit that referenced this pull request Sep 30, 2026
joepio added a commit that referenced this pull request Sep 30, 2026
…ent images, onboarding recovery fixes (#1915)

Lands #1889 (edit agents, skills and MCP servers in a dialog), #1890 (sidebar account menu in place of the App panel), #1891 (share dialog role select stays open), #1895 (document images from the local blob store) and #1917 (onboarding recovery, metadata request bursts, local bootstrap), tested together on Mancave.
@joepio joepio closed this Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants