Skip to content

Share create-button configuration fields and validate raw preset drafts - #2531

Closed
michielbdejong wants to merge 1 commit into
codex/tablepage-view-write-receiptsfrom
codex/tablepage-quick-add-fields
Closed

michielbdejong wants to merge 1 commit into
codex/tablepage-view-write-receiptsfrom
codex/tablepage-quick-add-fields

Conversation

@michielbdejong

@michielbdejong michielbdejong commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Structurally split — superseded by #2553 (code moves) and #2554 (functionality improvements).

The improvement child’s full Git tree matches this original head exactly. Original refs/review history are preserved. The pair uses this PR’s legacy base for review; later restacking remains necessary and it is not a prerequisite of the independent clean extraction #2536. This is a structural content split, not completion of the whole TablePage port. The original description follows.


Mixed extraction and behavior changes — held for separation.

This branch combines moved UI/model/query code with changed validation, scope, recovery or state behavior. Those changes must be separated before this PR is ready: move the existing complete TablePage first, preserving behavior, then review improvements as follow-ups. The original branch and validation are preserved below; the current legacy stack is not a completed clean split and must not be merged as the TablePage extraction.

See the revised scope.


Table and dashboard create-button configuration now use the actual shared TableQuickAddFields form. Atomic adapters retain metadata compatibility, subscribed option labels, translated text, input styling and checkbox controls.

Incomplete or non-finite numeric presets and unavailable targets block Save before either caller writes; zero persists as a number. Editing the first preset retains additional stored presets with an explicit notice. Multiple mounted editors receive unique input IDs.

Validation: 199 package tests, 180 Atomic adapter tests, package/host typechecks, clean packed-consumer check and repository pre-commit checks. Actual SDK browser verification blocks a raw -, accepts 0, independently reads the persisted preset, and exercises desktop/mobile dialogs. Reviewed screenshots are shown in task chat and kept outside Git at /workspace/artifacts/table-quick-add-fields/editor-desktop.png and editor-mobile.png.

The shared fields and Atomic metadata adapter compile cleanly. Existing compiler suppressions in QuickAddDialog and BlockConfigDialog remain. Their scoped dialog/persistence lifecycle and full page/renderer adoption remain follow-up work.

Stacked on #2530.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant