Repository navigation
Retain page-owned create-button saves and removals until persistence completes - #2532
Draft
michielbdejong wants to merge 1 commit into
Draft
michielbdejong wants to merge 1 commit into
michielbdejong wants to merge 1 commit into
Conversation
michielbdejong
marked this pull request as draft
November 13, 2026 15:56
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deferred functionality — held during the extraction cleanup.
The agreed sequence is to extract the existing complete TablePage first and review functionality improvements separately. This PR preserves work for that follow-up; it is not a prerequisite for the move-only extraction. The legacy stack is still interleaved and needs restacking against the clean extraction, so this draft must not be merged as completion of the TablePage port. Existing validation below describes the original branch, not a completed split.
See the revised scope.
Create-button configuration now stays mounted at page scope rather than inside a saved tab. Save and Remove await their own tracked view-write receipt, so an optimistic removal cannot tear down its editor before persistence finishes. Failed removal retries the accepted removal instead of recreating the button.
The shared dialog lifecycle supports removal without requiring valid form fields while keeping its busy, scope and retained-error guards. Atomic rechecks the captured class/property bindings and current create-button configuration, rejects conflicting peer edits, and patches only this view field. Navigation retains the draft and disables both actions. Proven-unwritten conflicts can be safely abandoned; partially applied operations stay pending for explicit retry.
Validation: all 200 package tests; all 180 Atomic adapter tests; package/host typechecks; packed clean-consumer check; repository pre-commit checks. Actual SDK browser checks independently read persisted numeric zero and removal, retry a failed removal, retain a peer change without overwriting it, safely close an unwritten conflict, and freeze a stale editor after view navigation. Translation cleanup removes six obsolete entries without dropping active messages.
Shared lifecycle, QuickAddDialog and AtomicPropertyFrame compile cleanly; QuickAddDialog no longer needs its old compiler suppression. Existing TableResource suppression and TableViewTabs ref diagnostics remain.
Reviewed desktop/mobile screenshots are shown in task chat and kept outside Git at
/workspace/artifacts/table-quick-add-dialog(includingremove-failed-desktop.png,view-scope-retained.pngandeditor-mobile.png).Stacked on #2531. ELFA create-button configuration is merged separately in database-apps #119. Full page/session and renderer adoption remain unfinished, and catalog/lens discovery stays behind that gate. No rollback or cross-document CAS claim.