Repository navigation
Move quick-add controls with the existing local queue (split #2527) - #2549
Open
michielbdejong wants to merge 1 commit into
Open
michielbdejong wants to merge 1 commit into
michielbdejong wants to merge 1 commit into
Conversation
This was referenced Nov 16, 2026
michielbdejong
marked this pull request as ready for review
November 16, 2026 12:12
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for trekmeester’s content review. Merge remains blocked on clean-base restacking and full Main integration CI.
This is a completed structural code-move split on its preserved legacy review base. Review the move-only diff against the displayed base; this is not an extraction-only merge stack. Dedicated Table package and Flutter checks were verified green at head
d7e0dfe. Do not merge this legacy branch into develop as part of the clean extraction before restacking and revalidating. No automatic merge is requested.Move the existing quick-add input/button and local-state serial submission logic into the shared table package. Preserve clearing the submitted text immediately, Enter queuing while a save runs, existing success/error callbacks and the original component lifetime. Atomic row creation remains in the host adapter.
This is the code-move half of #2527. The separate queue service, owner/scope isolation, stale-notification suppression, synchronous-subscriber serialization and inline failure feedback belong in the deferred improvement child. Original branches/review history are preserved.
Validation:180 package tests including actual deferred-Promise serial submission/input retention,8 Atomic quick-add checks, table/app types, clean compiler checks for control and adapter, mandatory staged workspace lint. Legacy review base retained; later restacking remains and this is not a prerequisite of independent extraction #2536. No resource/property binding API change.