Skip to content

Scope quick-add queues and suppress stale notifications (split #2527) - #2550

Open
michielbdejong wants to merge 3 commits into
codex/split-2527-movefrom
codex/split-2527-improvement
Open

michielbdejong wants to merge 3 commits into
codex/split-2527-movefrom
codex/split-2527-improvement

Conversation

@michielbdejong

@michielbdejong michielbdejong commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Quick-add requests queued before switching table/view must stay bound to their original backend callback. This improvement gives the existing field/button an explicit in-memory queue, starts a fresh UI session when scope changes, suppresses stale success callbacks, serializes accepted requests and displays failed values without automatic retries. It changes no durability or Resource/Store contract.

Accepted writes continue after navigation. Their failures still call the captured original error handler so a failed accepted write cannot disappear silently; adapters should use that callback for reporting, rather than updating current-page state. The review audit adds mounted coverage for this distinction and for reentrant enqueueing from a synchronous subscriber, and documents it. Final queue behavior is preserved; the additional audit work is regression coverage and clarification.

Scope and dependencies

Behavior half of #2527, separated from code moves in #2549. The initial split commit f9c3739 exactly preserves the original mixed head b300f7b; subsequent audit commits add tests/documentation and explain the failure-reporting distinction. Original refs/review history remain preserved. This PR retains legacy ancestry through #2549: review the improvement here, but restack against the eventual complete extraction before merging. It is not a prerequisite of clean extraction #2536. No changes to ELFA's submodule pin, editor binding API or persistence semantics.

Validation

  • 185 table-package tests across 37 files passed during the audit; the final six quick-add regressions pass with retained old-request failure reporting.
  • 8 Atomic quick-add regressions pass.
  • Table package build, typecheck and lint pass; Data Browser typecheck passes after building its workspace dependency graph.
  • Mandatory staged-snapshot full workspace lint runs on each audit commit.
  • Existing QuickAddBar compiles without React Compiler diagnostics, with memoization emitted.
  • Main integration CI was dispatched; its result is separate from local checks. No merge is authorized by a queued run.
  • Existing actual desktop/mobile captures for the original controls were reviewed in the task chat at /workspace/artifacts/table-quick-add; audit additions change no layout and are covered by mounted scope/lifecycle regressions, not a new end-to-end browser claim.

Prepared for trekmeester review; no merge performed. Clean-base restacking and full integration CI remain merge prerequisites.

@michielbdejong
michielbdejong marked this pull request as ready for review November 16, 2026 12:20

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant