Repository navigation
Scope quick-add queues and suppress stale notifications (split #2527) - #2550
Open
michielbdejong wants to merge 3 commits into
Open
michielbdejong wants to merge 3 commits into
michielbdejong wants to merge 3 commits into
Conversation
This was referenced Nov 16, 2026
michielbdejong
marked this pull request as ready for review
November 16, 2026 12:20
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick-add requests queued before switching table/view must stay bound to their original backend callback. This improvement gives the existing field/button an explicit in-memory queue, starts a fresh UI session when scope changes, suppresses stale success callbacks, serializes accepted requests and displays failed values without automatic retries. It changes no durability or Resource/Store contract.
Accepted writes continue after navigation. Their failures still call the captured original error handler so a failed accepted write cannot disappear silently; adapters should use that callback for reporting, rather than updating current-page state. The review audit adds mounted coverage for this distinction and for reentrant enqueueing from a synchronous subscriber, and documents it. Final queue behavior is preserved; the additional audit work is regression coverage and clarification.
Scope and dependencies
Behavior half of #2527, separated from code moves in #2549. The initial split commit
f9c3739exactly preserves the original mixed headb300f7b; subsequent audit commits add tests/documentation and explain the failure-reporting distinction. Original refs/review history remain preserved. This PR retains legacy ancestry through #2549: review the improvement here, but restack against the eventual complete extraction before merging. It is not a prerequisite of clean extraction #2536. No changes to ELFA's submodule pin, editor binding API or persistence semantics.Validation
/workspace/artifacts/table-quick-add; audit additions change no layout and are covered by mounted scope/lifecycle regressions, not a new end-to-end browser claim.Prepared for trekmeester review; no merge performed. Clean-base restacking and full integration CI remain merge prerequisites.