Repository navigation
chore(lib): add test showing no failure if resource scoped to app - #73
Merged
jsteinich merged 2 commits intoApr 6, 2026
Merged
Conversation
A part of open-constructs#57. Adding the test first so that adjusting the behavior is reflected in tests.
krzema12
changed the title
krzema12
marked this pull request as ready for review
March 25, 2026 08:02
1 task done
Contributor
|
@krzema12 would you be able to rebase this so that tests pass (the TypeScript 6 release caused some issues)? The test itself seems good. |
Contributor
Author
|
Ack, sure - will take care of it. |
Contributor
Author
|
@jsteinich I'm pretty sure the failures aren't coming from the new test. I synced my branch with newest main. |
Contributor
Author
|
I think we should add a label to the PR: cdk-terrain/.github/workflows/pr-unit.yml Line 126 in d1f0f64 |
jsteinich
approved these changes
Apr 6, 2026
jsteinich
added a commit
that referenced
this pull request
May 6, 2026
**Breaking changes** ### Python 3.8 is no longer supported We have dropped support for Python 3.8, please update to Python 3.9 or higher. ### Go 1.18-1.24 are no longer supported We have dropped support for Go 1.18 - 1.24, please update to Go 1.25 or higher. ### TypeScript versions less than 4.5 are no longer suppored Provider generation now uses features from TypeScript 4.5. Note that there isn't an official minimum supported TypeScript at this time and using the latest 5.x version is recommended. **Upcoming Breaking Changes** Node version 22.x will become the minimum in an upcoming release as 20.x is now EoL. ### feat - feat(provider-generator): use type modifier on imports [\#150](#150) - feat(lib): add StringMapMap class [\#110](#110) ### chore - chore: clean up yarn install warnings [\#149](#149) - chore(deps): bump the github-actions-backward-compatible group with 6 updates [\#146](#146) - chore: Fix eslint warnings - phase 5 [\#140](#140) - chore: Fix eslint warnings - phase 4 [\#139](#139) - chore: Fix eslint warnings - phase 3 [\#138](#138) - chore: Fix eslint warnings - phase 2 [\#137](#137) - chore: Fix eslint warnings - phase 1 [\#135](#135) - chore(provider-generator): Update retry to terraform init for transient GitHub errors [\#134](#134) - chore: Remove unused dependencies from packages - phase 1 [\#133](#133) - chore(provider-generator): Add retry to terraform init for transient GitHub errors [\#132](#132) - chore(provider-generator): enable typescript declarationMap [\#131](#131) - chore: Fix Java flaky integration test [\#130](#130) - chore: Add missing dependencies to packages [\#129](#129) - chore: Standardise test scripts to only run tests [\#128](#128) - chore: Remove edited from the examples workflow pull_request types [\#127](#127) - chore: Add retry to build-example [\#126](#126) - chore: Bump verdaccio version and add npm install retries [\#122](#122) - chore: Remove `edited` from the test workflow pull_request types [\#121](#121) - chore: Replace depcheck CI check with knip [\#120](#120) - chore: Update test providers to support darwin arm64 [\#119](#119) - chore: Refine eslint configuration [\#118](#118) - chore: emit compiled TS to build/ instead of next to sources [\#116](#116) - chore: Add VSCode Settings and Extension Recommendations [\#114](#114) - chore: Fix eslint auto-fixable issues [\#113](#113) - chore: use new docker image in builds [\#108](#108) - chore: Update docker image to have Go 1.25 and Node 22 [\#97](#97) - chore: Upgrade dependencies for all [\#91](#91) - chore: Upgrade jest to v30 [\#89](#89) - chore(deps): bump the github-actions-backward-compatible group with 4 updates [\#88](#88) - chore(deps): bump the github-actions-breaking group with 5 updates [\#87](#87) - chore: add migration context to bug report issue templates [skip ci] [\#86](#86) - chore: npm-check-updates && yarn upgrade [\#84](#84) - chore: Upgrade dependencies for all [\#83](#83) - chore(lib): add test showing no failure if resource scoped to app [\#73](#73) - chore(deps): Run npx yarn-audit-fix --force [\#59](#59) - chore(cli): Replace node-pty with simple interactive process [\#55](#55) - chore: Upgrade dependencies for JSII [\#20](#20) ### fix - fix(cli): anchor jest testPathIgnorePatterns in typescript template [\#147](#147) - fix(tests): Fix app.test and json-to-hcl.test race condition [\#125](#125) - fix(lib): ForExpression missing iteratorContext and OperatorExpression drops falsy right operands [\#112](#112) - fix(cli): support pre-built provider metadata with cdktn key [\#107](#107) - fix(cli): don't check cdktf-cli version [\#99](#99) - fix(deps): replace archiver with yazl [\#95](#95) - fix(lib): fail on constructs outside of stacks (under feature flag) [\#93](#93) - fix(gha): Fix GitHub release creation [\#90](#90)
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Relates to (doesn't fix yet) #57
Description
Adds a test that shows the current undesired behavior, so that adjusting the behavior is reflected in tests.
Checklist